e07fba5731
Applies the Opus review of Campaign CH slice CH3 (614a1e05):
- B1: UN-9 was a phantom divergence — ACE's CharacterOptions1.cs:47
OR-sum is 0x50C4A54A (its own comment confirms 1355064650), identical
to acdream's literal. The wrong 0x50C48D4A existed only in the research
doc. Row deleted, register §5 reverted to 4 rows, research doc corrected
with dated notes.
- S1/S4: AllegianceBroadcast (0x02000000) is a server-echoing channel —
ACE's GameActionChatChannel handler includes the sender in its real-name
Allegiance.Members broadcast (retail's DoAllegianceBroadcast has no
AddTextToScroll), so the client must skip its local optimistic echo, not
keep it. ChatChannelInfo.Legacy.IsSelfEchoChannel() now returns true for
it; RouteLegacyChannel's comment corrected; Turbine.IsSelfEchoChannel()'s
backwards comment rewritten truthfully.
- S3: retail's /a stays on the legacy AllegianceBroadcast bitflag until
StartupTurbineChatSystem successfully starts Turbine chat — "never
started" (TurbineChatState.Enabled == false) now falls back to legacy in
both LiveSessionCommandRouter.RouteChat and
DirectGameRuntimeCommandAdapter.TrySendChannel, while "enabled but no
allegiance room" still correctly refuses locally.
- S5: added a LiveSessionEventRouter test proving the Options.Replace ->
OnCharacterOptionsChanged seeding order, and RuntimeSettingsTargets /
GameWindowLiveSessionOwnershipTests tests proving the concrete
ICommandBus.Publish wiring and the single LiveSessionCommandSurface
construction site.
- S6: AP-181 rewritten to name both of retail's omitted pre-send checks
(IsMessageSafe silent-drop, then IsMessageSpam) and stop misattributing
either to RouteLegacyChannel, which has no such gates.
- N1-N7: CharacterOptionId moved below SocialActions so its doc comment
re-attaches; TurbineChatMembershipGate reuses TurbineChatDisplayNames
instead of a duplicate table; the gate-to-refusal-text mapping is now
shared via TurbineChatMembershipGate.ResolveRefusalText instead of
duplicated in both hosts; ChatSettings.Default now matches ACE's real
CharacterOptions2.Default (Roleplay/Society start off); a doc-comment
clarifies only the five Hear toggles are server-backed; the register's
§3 header recounted 129 -> 128.
Suite: 11,964 passed / 4 skipped / 0 failed (baseline 11,957/4/0 + 7 new
tests). Campaign ledger CH3 review column updated to APPROVE-WITH-FIXES.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
47 lines
1.5 KiB
C#
47 lines
1.5 KiB
C#
using AcDream.UI.Abstractions.Panels.Settings;
|
|
|
|
namespace AcDream.UI.Abstractions.Tests.Panels.Settings;
|
|
|
|
/// <summary>
|
|
/// L.0: <see cref="ChatSettings"/> default-pin tests.
|
|
/// </summary>
|
|
public sealed class ChatSettingsTests
|
|
{
|
|
[Fact]
|
|
public void Default_values_match_AceCharacterOptions2Default_stance()
|
|
{
|
|
// N4 (CH3 Opus review): ACE's real CharacterOptions2.Default
|
|
// (0x00948700) turns General/Trade/LFG on but leaves Roleplay
|
|
// (0x800) and Society (0x80000) off — this is no longer an
|
|
// invented "all channels on" stance.
|
|
var d = ChatSettings.Default;
|
|
Assert.True(d.HearGeneralChat);
|
|
Assert.True(d.HearTradeChat);
|
|
Assert.True(d.HearLFGChat);
|
|
Assert.False(d.HearRoleplayChat);
|
|
Assert.False(d.HearSocietyChat);
|
|
Assert.False(d.AppearOffline);
|
|
Assert.True(d.ShowTimestamps);
|
|
Assert.True(d.FilterProfanity);
|
|
Assert.Equal(12f, d.FontSize);
|
|
}
|
|
|
|
[Fact]
|
|
public void Equality_is_value_based()
|
|
{
|
|
var a = ChatSettings.Default;
|
|
var b = ChatSettings.Default with { HearTradeChat = false };
|
|
var c = ChatSettings.Default with { HearTradeChat = false };
|
|
Assert.NotEqual(a, b);
|
|
Assert.Equal(b, c);
|
|
}
|
|
|
|
[Fact]
|
|
public void With_expression_clones_one_field()
|
|
{
|
|
var d = ChatSettings.Default with { FontSize = 16f };
|
|
Assert.Equal(16f, d.FontSize);
|
|
Assert.True(d.HearGeneralChat);
|
|
Assert.True(d.ShowTimestamps);
|
|
}
|
|
}
|