Campaign P remaining-physics-divergence, placement cutover slice C3c
(docs/plans/2026-08-02-placement-cutover.md). Both production hosts now
register every initial Create through the residence + continuation-
executor + first-entry-conductor machinery (C0-C3b):
- Graphical (route 1): RegisterEntityWithInitialResidence at Create; the
shared RuntimeFirstEntryDriveController pumps both conductors from the
placement-receipt flow; MaterializeProjection and RebucketLiveEntity
are presentation-only while a residence is ACTIVE (ExecutorCompleted is
the presentation-binding receipt); post-residence entities take the
full legacy path including the prepare_to_enter_world clock edges.
PlayerModeController attaches presentation to the Runtime-published
controller; its legacy resolve/step-heights/host-construction path is
deleted; presentation-only rollback (retail has no entry-flow rollback).
- Headless (route 8): OnSpawned registers with residence when a drive
exists; content-less sessions keep the pre-flip direct registration;
SynchronizeLocalPlayer/CreateController/ApplySetupStepHeights deleted;
prepared-collision read failure is a typed AwaitingCollisionSource
retry; far remotes outside the service window complete celless.
- RuntimeLocalPlayerMovementState.Controller setter sealed internal; all
controller mutation flows through the publication lifecycle.
Fix slices landed within this cutover, each dual-gated:
- F1: live movement-stat/server-physics application routed through the
Runtime ownership seam (post-logout ingest crash on the retired
controller eliminated; RuntimeMovementSkillProjection deleted).
- F2: login activation wedge - collision-admission prefix gate factored
out of the seal (reentrant-commit RejectedAuthority), rearm generation
identity corrected, PlayerModeAutoEntry requires the Runtime-published
controller (world reveal can no longer seal unmaterialized).
- F3: landblock-prefix 0-sentinel replaced by explicit absent-id guards;
map-corner landblocks (grid row/col 0) fully legal through admission,
park/rearm/retire, quiescence, and outdoor shadow seeds.
- F5: local-player first-entry ground contact seeded by the shared
SpawnPlacementSettler (moved App->Core) at FinalizeActivation - the
retail first-gravity-frame touch (enter_world 0x00516170 carries no
seed); the legacy unconditional force-seed is overwritten by a real
floor-found contact; airborne spawns stay airborne; outbound contact
bit verified end-to-end. Fixes the standing-cast 'You can't do that
while in the air!' rejections.
- R1 (dual-review round): login constraint leash armed at the committed
placement (HandleReceivedPosition 0x00453FD0 analog); register rows
AD-61 (settle-timing compression now covering the local player) and
AD-42 (repointed off the deleted resolve split) in this commit;
residence-conversion owner API; wire-landblock guards; drive-pending
ledger in IsConverged; route attach/detach latch; executor-drain drift
model documented + source-pinned.
Gates: Runtime 1,003, App 4,039/3 skips, Headless 79, complete solution
10,816/0 failed/4 skips (Release, -m:1); connected lifecycle/reconnect
gate PASS (logs/connected-world-gate-20260802-175401; graceful exits,
world-visible, zero airborne rejections). The nine-stop soak remains red
for the pre-existing 6b28ff99 whole-world collision-clone throughput
regression (attributed with evidence; scheduled as its own slice before
C5). Dual Opus reviews (retail-conformance + adversarial): delta PASS.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
89 lines
3.1 KiB
C#
89 lines
3.1 KiB
C#
using System.Text.RegularExpressions;
|
|
|
|
namespace AcDream.App.Tests.Physics;
|
|
|
|
public sealed class Issue270ProductionWiringTests
|
|
{
|
|
[Fact]
|
|
public void MovementStats_UseOneEdgeTrackerAndResetItWithTheSession()
|
|
{
|
|
// C3c-F1 (2026-08-02): the #270 invariant is unchanged — exactly one
|
|
// stamina-exhaustion edge tracker, exhaustion dispatched once on the
|
|
// edge, tracker reset with the session — but the wiring moved from
|
|
// the factory's deleted ApplyMovementStats body into
|
|
// LiveMovementStatsApplier, which routes through the Runtime
|
|
// movement owner's typed seam instead of touching the controller.
|
|
string applier = ReadSource("Net", "LiveMovementStatsApplier.cs");
|
|
string factory = ReadSource("Net", "LiveSessionRuntimeFactory.cs");
|
|
|
|
Assert.Contains(
|
|
"_staminaExhaustion.Observe(snapshot.CurrentStamina)",
|
|
applier,
|
|
StringComparison.Ordinal);
|
|
Assert.Single(
|
|
Regex.Matches(
|
|
applier,
|
|
@"_movement\.ReportExhaustion\(\);")
|
|
.Cast<Match>());
|
|
Assert.Contains(
|
|
"_staminaExhaustion.Reset();",
|
|
applier,
|
|
StringComparison.Ordinal);
|
|
Assert.Contains(
|
|
"_movementStats.Reset();",
|
|
factory,
|
|
StringComparison.Ordinal);
|
|
// The factory keeps zero direct controller mutations: both stat
|
|
// callbacks route through the applier's seam.
|
|
Assert.Equal(
|
|
2,
|
|
Regex.Matches(factory, @"_movementStats\.Apply\(").Count);
|
|
Assert.DoesNotContain(
|
|
"Motion.ReportExhaustion",
|
|
factory,
|
|
StringComparison.Ordinal);
|
|
}
|
|
|
|
[Fact]
|
|
public void RemoteSpawnSettle_IsRetriedAndCoversBothCreationRoutes()
|
|
{
|
|
string source = ReadSource(
|
|
"Physics",
|
|
"LiveEntityNetworkUpdateController.cs");
|
|
|
|
Assert.Contains(
|
|
"if (!remote.Body.InContact)",
|
|
source,
|
|
StringComparison.Ordinal);
|
|
Assert.Equal(
|
|
3,
|
|
Regex.Matches(source, @"SeedRemoteSpawnPlacement\(").Count);
|
|
// C3c-F5: the settle helper moved to Core (SpawnPlacementSettler) so
|
|
// the local player's Runtime first-entry activation shares the same
|
|
// tested compressed-first-gravity-frame sweep.
|
|
Assert.Contains(
|
|
"SpawnPlacementSettler.TrySettle(",
|
|
source,
|
|
StringComparison.Ordinal);
|
|
}
|
|
|
|
private static string ReadSource(params string[] relativePath)
|
|
{
|
|
DirectoryInfo? directory = new(AppContext.BaseDirectory);
|
|
while (directory is not null)
|
|
{
|
|
if (File.Exists(Path.Combine(directory.FullName, "AcDream.slnx")))
|
|
{
|
|
return File.ReadAllText(Path.Combine(
|
|
directory.FullName,
|
|
"src",
|
|
"AcDream.App",
|
|
Path.Combine(relativePath)));
|
|
}
|
|
|
|
directory = directory.Parent;
|
|
}
|
|
|
|
throw new DirectoryNotFoundException("Could not find AcDream.slnx.");
|
|
}
|
|
}
|