34d8a3c0e7
Applies the Opus review findings on CH1 (172c6f9a), the exact retail chat
color table. Two blockers plus should-fixes/nits, one commit:
BLOCKER 1 — LegacyChannelChatType.Resolve's channel-bit table was wrong.
Binary Ninja renders retail's `neg esi; sbb esi, esi` idiom (a branchless
select between Channel 0x08 and Channel_Send 0x09) as the trivial pseudo-C
`esi - esi` (always 0), hiding the real values. Corrected by decoding the
raw bytes at the PDB-paired binary: HEAR sbb site VA 0x00570F0A (mask -6 ->
0x08), SEND sbb site VA 0x00570D4F (mask -5 -> 0x09). The generic
admin/audit/sentinel catch-all is Channel/Channel_Send, NOT Abuse (0x0E) —
Abuse is retail's ONLY 0x0E producer (bit 0x0001). The unnamed
FellowBroadcast bit (0x4000000) is hear=Channel(0x08)/send=Fellowship(0x13),
not a flat 0x13. ACE's PDB-sourced Channel enum corroborates. Introduces
`RetailLogTextType`, the 34-value named enum for the wire LogTextType space
(values only, no color — Core stays presentation-free).
BLOCKER 2 — three ChatLog.OnSystemMessage sinks (ChatVM.ShowSystemMessage,
LiveSessionRuntimeFactory's ShowSystemMessage delegate,
HeadlessGameplayOperations.DisplayMessage) were typing ALL
ClientCommandController output 0x1A (bright red), including informational
command output (@version, /loc, friends list, usage lines). Retail types
the great majority of that output 0x00 Default (green) and reserves 0x1A
for genuine refusals/errors. Reverted to 0x00 with a comment noting the
refusal-vs-info split lands with CH2's SpewBox producer rewiring. The five
App composition sites that pass 0x1A for actual refusal text
(InteractionRetainedUiComposition, SessionPlayerComposition) were already
correct and are untouched (aside from converting the literal to the new
enum).
Also: AP-176 divergence-register row for OnWeenieError/OnCombatLine's
single-type approximation of retail's per-code/per-message dispatch; a
carry-forward test for the out-of-range LogTextType color fallback in
ChatWindowController; decomp-confirmed anchors replacing ACE-inferred
citations in CombatChatTranslator and ChatLog.OnPlayerKilled; required
(non-optional) logTextType parameters on OnLocalSpeech/OnTellReceived/
OnCombatLine/OnSelfSent since no production caller relied on a default;
LegacyChannelChatType.Resolve's parameter renamed channelBit -> channelId
with a doc note on multi-bit ids; corrections to the color-table research
doc's §3.3 wire tables; and issue #359 for the pre-existing (not
CH1-introduced) 0x019E PlayerKilled participant-suppression gap retail has
and acdream lacks.
dotnet build clean; full Release suite 11,835 passed / 4 skipped / 0 failed
(11,839 total), up from the CH1 baseline of 11,833/4/0.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
48 lines
1.5 KiB
C#
48 lines
1.5 KiB
C#
using AcDream.Core.Chat;
|
|
|
|
namespace AcDream.Core.Tests.Chat;
|
|
|
|
public sealed class ChatCommandTargetStateTests
|
|
{
|
|
[Fact]
|
|
public void TracksReplyAndRetellTargetsFromCommittedTranscript()
|
|
{
|
|
var chat = new ChatLog();
|
|
using var targets = new ChatCommandTargetState(chat);
|
|
|
|
chat.OnTellReceived("Bestie", "incoming", 0x50000001u, logTextType: 0x03u);
|
|
chat.OnSelfSent(ChatKind.Tell, "outgoing", logTextType: 0x04u, targetOrChannel: "Caith");
|
|
|
|
Assert.Equal("Bestie", targets.LastIncomingTellSender);
|
|
Assert.Equal("Caith", targets.LastOutgoingTellTarget);
|
|
}
|
|
|
|
[Fact]
|
|
public void ResetSessionForgetsTargetsButPreservesTranscript()
|
|
{
|
|
var chat = new ChatLog();
|
|
using var targets = new ChatCommandTargetState(chat);
|
|
chat.OnTellReceived("Bestie", "incoming", 0x50000001u, logTextType: 0x03u);
|
|
chat.OnSelfSent(ChatKind.Tell, "outgoing", logTextType: 0x04u, targetOrChannel: "Caith");
|
|
|
|
targets.ResetSession();
|
|
|
|
Assert.Null(targets.LastIncomingTellSender);
|
|
Assert.Null(targets.LastOutgoingTellTarget);
|
|
Assert.Equal(2, chat.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void DisposeDetachesAndIsIdempotent()
|
|
{
|
|
var chat = new ChatLog();
|
|
var targets = new ChatCommandTargetState(chat);
|
|
|
|
targets.Dispose();
|
|
targets.Dispose();
|
|
chat.OnTellReceived("After", "ignored", 0x50000002u, logTextType: 0x03u);
|
|
|
|
Assert.Null(targets.LastIncomingTellSender);
|
|
Assert.Null(targets.LastOutgoingTellTarget);
|
|
}
|
|
}
|