69ba9486b6
acdream never implemented @pklite. It is a CLIENT command in retail, not a
server one — ACE has no pklite text-command handler — so typing it forwarded as
inert chat text that the server ignored.
Retail: ClientCommunicationSystem::DoPKLite @0x0057A490 rejects with
WeenieError 0x507 when ACCWeenieObject::IsPlayerKiller @0x0058C910 is true
(that returns true when EITHER the PK bit 0x20 OR the PKLite bit 0x2000000 is
set), prints "Please see @help pklite for more..." and sends nothing if given
any argument text, and otherwise calls CM_Character::Event_EnterPKLite
@0x006A13F0 — a bare 12-byte parameterless game action, opcode 0x28F, the same
shape as Event_LoginCompleteNotification beside it. Verb string at 0x007E16B0,
help text at 0x007DF0C8, failure string at 0x007D31E8; one verb, no alias.
HasPlayerFlag is a tri-state (null = the local PublicWeenieDesc has not
arrived). The existing arena gates compare `== false` because they reject on a
known-FALSE flag; retail's DoPKLite gates the other way, rejecting on
known-TRUE. So this case compares `== true` on either bit: an indeterminate
description sends rather than blocks, which matches retail trusting the server
instead of inventing a client-side suppression rule.
Landed as its own commit because it is retail-faithful on its own merits, but
the motivation is C4 route 2: ACE advances SequenceType.ObjectForcePosition in
exactly two places, and the only reachable one is Player.HandleActionEnterPkLite's
entry-collision bump (allow_pkl_bump, default on). Every admin teleport advances
ObjectTeleport instead, so @teleto-style displacement exercises route 3, not
route 2. Without this command route 2 has no connected acceptance gate at all.
Gates: complete Release solution 10,867 passed / 4 skipped / 0 failed
(9966b531 baseline 10,858/4/0; +9 = the 9 tests added). Coverage includes both
known-true rejections, the known-false success case, the tri-state unknown
case, the 12-byte wire envelope, and @pklite resolving as ClientHandled rather
than falling through to the server-text path.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
115 lines
4.9 KiB
C#
115 lines
4.9 KiB
C#
using AcDream.UI.Abstractions;
|
|
using AcDream.UI.Abstractions.Panels.Chat;
|
|
|
|
namespace AcDream.UI.Abstractions.Tests.Panels.Chat;
|
|
|
|
public sealed class RetailClientCommandCatalogTests
|
|
{
|
|
[Theory]
|
|
[InlineData("/lifestone")]
|
|
[InlineData("@lifestone")]
|
|
[InlineData("/lif")]
|
|
[InlineData("@LIF")]
|
|
[InlineData("/ls")]
|
|
[InlineData("@LS")]
|
|
public void RetailAliases_ResolveCaseInsensitively(string input)
|
|
{
|
|
Assert.True(RetailClientCommandCatalog.TryMatch(input, out var match));
|
|
Assert.Equal(ClientCommandId.LifestoneRecall, match.Command);
|
|
Assert.True(match.HasValidArguments);
|
|
Assert.Empty(match.Arguments);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("/marketplace", ClientCommandId.MarketplaceRecall)]
|
|
[InlineData("@MAR", ClientCommandId.MarketplaceRecall)]
|
|
[InlineData("/mp", ClientCommandId.MarketplaceRecall)]
|
|
[InlineData("/pkarena", ClientCommandId.PkArenaRecall)]
|
|
[InlineData("/pka", ClientCommandId.PkArenaRecall)]
|
|
[InlineData("/pklarena", ClientCommandId.PkLiteArenaRecall)]
|
|
[InlineData("/pla", ClientCommandId.PkLiteArenaRecall)]
|
|
[InlineData("/pklite", ClientCommandId.EnterPkLite)]
|
|
[InlineData("@pklite", ClientCommandId.EnterPkLite)]
|
|
[InlineData("/hor", ClientCommandId.HouseRecall)]
|
|
[InlineData("/hr", ClientCommandId.HouseRecall)]
|
|
[InlineData("/hom", ClientCommandId.MansionRecall)]
|
|
[InlineData("/hoa", ClientCommandId.MansionRecall)]
|
|
[InlineData("/age", ClientCommandId.QueryAge)]
|
|
[InlineData("/birth", ClientCommandId.QueryBirth)]
|
|
[InlineData("/framerate", ClientCommandId.ToggleFrameRate)]
|
|
[InlineData("/lockui", ClientCommandId.ToggleUiLock)]
|
|
[InlineData("/version", ClientCommandId.ShowVersion)]
|
|
[InlineData("/loc", ClientCommandId.ShowLocation)]
|
|
[InlineData("/corpse", ClientCommandId.ShowLastCorpseLocation)]
|
|
[InlineData("/cor", ClientCommandId.ShowLastCorpseLocation)]
|
|
public void AdditionalRetailAliases_Resolve(string input, ClientCommandId expected)
|
|
{
|
|
Assert.True(RetailClientCommandCatalog.TryMatch(input, out var match));
|
|
Assert.Equal(expected, match.Command);
|
|
Assert.True(match.HasValidArguments);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("/clear all", ClientCommandId.ClearChat)]
|
|
[InlineData("/saveui hunt", ClientCommandId.SaveUi)]
|
|
[InlineData("/loadui hunt", ClientCommandId.LoadUi)]
|
|
[InlineData("/saveautoui", ClientCommandId.SaveAutoUi)]
|
|
[InlineData("/loadautoui", ClientCommandId.LoadAutoUi)]
|
|
[InlineData("/afk msg lunch", ClientCommandId.Away)]
|
|
[InlineData("/consent who", ClientCommandId.Consent)]
|
|
[InlineData("/e waves", ClientCommandId.Emote)]
|
|
[InlineData("/em waves", ClientCommandId.Emote)]
|
|
[InlineData("/emote waves", ClientCommandId.Emote)]
|
|
[InlineData("/me waves", ClientCommandId.Emote)]
|
|
[InlineData("/emotes", ClientCommandId.ListEmotes)]
|
|
[InlineData("/friends online", ClientCommandId.Friends)]
|
|
[InlineData("/friends_add Alice", ClientCommandId.FriendsAdd)]
|
|
[InlineData("/friends_remove Alice", ClientCommandId.FriendsRemove)]
|
|
[InlineData("/squelch -tell Alice", ClientCommandId.Squelch)]
|
|
[InlineData("/unsquelch Alice", ClientCommandId.Unsquelch)]
|
|
[InlineData("/filter -combat", ClientCommandId.Filter)]
|
|
[InlineData("/unfilter -combat", ClientCommandId.Unfilter)]
|
|
[InlineData("/messagetypes", ClientCommandId.ListMessageTypes)]
|
|
[InlineData("/fillcomps scarabs 500", ClientCommandId.FillComponents)]
|
|
public void CommandFamilies_ResolveToTypedClientCommands(
|
|
string input, ClientCommandId expected)
|
|
{
|
|
Assert.True(RetailClientCommandCatalog.TryMatch(input, out var match));
|
|
Assert.Equal(expected, match.Command);
|
|
Assert.True(match.HasValidArguments);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("/house recall", ClientCommandId.HouseRecall)]
|
|
[InlineData("@house mansion_recall", ClientCommandId.MansionRecall)]
|
|
[InlineData("/house alleg_recall", ClientCommandId.MansionRecall)]
|
|
public void HouseRecallSubcommands_Resolve(string input, ClientCommandId expected)
|
|
{
|
|
Assert.True(RetailClientCommandCatalog.TryMatch(input, out var match));
|
|
Assert.Equal(expected, match.Command);
|
|
Assert.True(match.HasValidArguments);
|
|
}
|
|
|
|
[Fact]
|
|
public void UnsupportedHouseSubcommand_RemainsClientOwnedAndShowsUsage()
|
|
{
|
|
Assert.True(RetailClientCommandCatalog.TryMatch("/house nope", out var match));
|
|
Assert.False(match.HasValidArguments);
|
|
}
|
|
|
|
[Fact]
|
|
public void LifestoneArgument_IsRecognizedButInvalid()
|
|
{
|
|
Assert.True(RetailClientCommandCatalog.TryMatch("/ls now", out var match));
|
|
Assert.Equal("now", match.Arguments);
|
|
Assert.False(match.HasValidArguments);
|
|
Assert.Equal("/lifestone", match.Usage);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("/ci 629")]
|
|
[InlineData("@acehelp")]
|
|
[InlineData("ordinary speech")]
|
|
public void NonClientCommands_DoNotMatch(string input)
|
|
=> Assert.False(RetailClientCommandCatalog.TryMatch(input, out _));
|
|
}
|