This reverts ceec3bc4. Two independent reasons, either sufficient.
The rendering regression. The slice deleted TextRenderGlStateScope, which
saved GL_MULTISAMPLE and GL_SAMPLE_ALPHA_TO_COVERAGE on entry, disabled them
for the text pass, and restored them on exit (TextRenderGlStateScope.cs:111-112
and 153-154 at the parent commit). Its replacement bakes that state into the
text pipeline but nothing restores it, and GlGpuPassEncoder.Dispose does not
either. Every world renderer is still raw GL at this point in the campaign, so
from the first UI frame onward the world drew with multisampling disabled.
The offline pixel gate caught it: 1,791 of 563,200 compared pixels differed,
0.318% against a 0.001 threshold. The commit message attributed this to
wall-clock-driven ambient animation shifting phase, and committed through the
failure. That explanation does not survive its own control: capturing twice at
the reverted-to commit differs by 19 pixels and twice at the slice's own commit
by 8, while base-versus-head differs by 1,791 - a 224x gap that no shared-noise
source explains. An amplified difference image settles it visually: the changed
pixels are the silhouette edges of every tree, building and rock, with terrain
interiors, water and the entire UI untouched. That is the signature of losing
edge antialiasing, not of animated sprites.
This is the exact failure mode two existing memory notes already warn about -
a mid-frame renderer must set every GL state it uses rather than inherit it,
and issue #52's lesson that a rendering migration must audit per-pass GL state
before declaring itself done.
The scope. The brief was three small leaf renderers plus additive frame-
lifecycle wiring, roughly ten files. The commit changed 334 files with 3,665
insertions and 3,845 deletions, including 323 public-to-internal visibility
conversions across the App assembly, 55 test files, two retired conformance
tests, and a self-described temporary escape hatch for bridging raw-GL viewport
textures. Even without the regression, that is not separable into the part
worth keeping and the part worth dropping.
Reverting rather than patching because the good work here - the RHI frame
lifecycle wiring and a genuine render-state-cache staleness fix - is small
enough to redo cleanly against a tightened spec, while untangling it from 300+
files of unrelated churn is not.
Post-revert: Release build clean, App suite back to 3,843 passed / 3 skipped,
offline pixel gate passing at 19 differing pixels.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
83 lines
3.5 KiB
C#
83 lines
3.5 KiB
C#
using System;
|
|
using System.Collections.Concurrent;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Threading;
|
|
|
|
namespace AcDream.App.Rendering.Wb {
|
|
/// <summary>
|
|
/// Resource types for GPU memory tracking.
|
|
/// </summary>
|
|
public enum GpuResourceType {
|
|
Texture,
|
|
Buffer,
|
|
Shader,
|
|
VAO,
|
|
FBO,
|
|
RBO,
|
|
Other
|
|
}
|
|
|
|
/// <summary>
|
|
/// Details about a GPU resource type.
|
|
/// </summary>
|
|
public record GpuResourceDetails(GpuResourceType Type, int Count, long Bytes);
|
|
|
|
/// <summary>
|
|
/// Details about a specific named buffer.
|
|
/// </summary>
|
|
public record NamedBufferDetails(string Name, long CapacityBytes, long UsedBytes);
|
|
|
|
/// <summary>
|
|
/// Tracks manual VRAM allocations for buffers and textures.
|
|
/// </summary>
|
|
public static class GpuMemoryTracker {
|
|
private static long _allocatedBytes;
|
|
private static readonly long[] _allocatedBytesByType = new long[Enum.GetValues<GpuResourceType>().Length];
|
|
private static readonly int[] _resourceCountsByType = new int[Enum.GetValues<GpuResourceType>().Length];
|
|
private static readonly ConcurrentDictionary<string, NamedBufferDetails> _namedBuffers = new();
|
|
|
|
public static long AllocatedBytes => Interlocked.Read(ref _allocatedBytes);
|
|
|
|
public static int VaoCount => _resourceCountsByType[(int)GpuResourceType.VAO];
|
|
public static int ShaderCount => _resourceCountsByType[(int)GpuResourceType.Shader];
|
|
public static int BufferCount => _resourceCountsByType[(int)GpuResourceType.Buffer];
|
|
public static int TextureCount => _resourceCountsByType[(int)GpuResourceType.Texture];
|
|
public static int FboCount => _resourceCountsByType[(int)GpuResourceType.FBO];
|
|
public static int RboCount => _resourceCountsByType[(int)GpuResourceType.RBO];
|
|
|
|
public static void TrackAllocation(long sizeInBytes, GpuResourceType type = GpuResourceType.Other) {
|
|
Interlocked.Add(ref _allocatedBytes, sizeInBytes);
|
|
Interlocked.Add(ref _allocatedBytesByType[(int)type], sizeInBytes);
|
|
}
|
|
|
|
public static void TrackDeallocation(long sizeInBytes, GpuResourceType type = GpuResourceType.Other) {
|
|
Interlocked.Add(ref _allocatedBytes, -sizeInBytes);
|
|
Interlocked.Add(ref _allocatedBytesByType[(int)type], -sizeInBytes);
|
|
}
|
|
|
|
public static void TrackResourceAllocation(GpuResourceType type) => Interlocked.Increment(ref _resourceCountsByType[(int)type]);
|
|
public static void TrackResourceDeallocation(GpuResourceType type) => Interlocked.Decrement(ref _resourceCountsByType[(int)type]);
|
|
|
|
public static void TrackNamedBuffer(string name, long capacityBytes, long usedBytes) {
|
|
_namedBuffers[name] = new NamedBufferDetails(name, capacityBytes, usedBytes);
|
|
}
|
|
|
|
public static void UntrackNamedBuffer(string name) {
|
|
_namedBuffers.TryRemove(name, out _);
|
|
}
|
|
|
|
public static IEnumerable<NamedBufferDetails> GetNamedBufferDetails() => _namedBuffers.Values.OrderBy(b => b.Name);
|
|
|
|
public static IEnumerable<GpuResourceDetails> GetDetails() {
|
|
var types = Enum.GetValues<GpuResourceType>();
|
|
foreach (var type in types) {
|
|
yield return new GpuResourceDetails(
|
|
type,
|
|
_resourceCountsByType[(int)type],
|
|
Interlocked.Read(ref _allocatedBytesByType[(int)type])
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|