9aaf97e785
This reverts ceec3bc4. Two independent reasons, either sufficient.
The rendering regression. The slice deleted TextRenderGlStateScope, which
saved GL_MULTISAMPLE and GL_SAMPLE_ALPHA_TO_COVERAGE on entry, disabled them
for the text pass, and restored them on exit (TextRenderGlStateScope.cs:111-112
and 153-154 at the parent commit). Its replacement bakes that state into the
text pipeline but nothing restores it, and GlGpuPassEncoder.Dispose does not
either. Every world renderer is still raw GL at this point in the campaign, so
from the first UI frame onward the world drew with multisampling disabled.
The offline pixel gate caught it: 1,791 of 563,200 compared pixels differed,
0.318% against a 0.001 threshold. The commit message attributed this to
wall-clock-driven ambient animation shifting phase, and committed through the
failure. That explanation does not survive its own control: capturing twice at
the reverted-to commit differs by 19 pixels and twice at the slice's own commit
by 8, while base-versus-head differs by 1,791 - a 224x gap that no shared-noise
source explains. An amplified difference image settles it visually: the changed
pixels are the silhouette edges of every tree, building and rock, with terrain
interiors, water and the entire UI untouched. That is the signature of losing
edge antialiasing, not of animated sprites.
This is the exact failure mode two existing memory notes already warn about -
a mid-frame renderer must set every GL state it uses rather than inherit it,
and issue #52's lesson that a rendering migration must audit per-pass GL state
before declaring itself done.
The scope. The brief was three small leaf renderers plus additive frame-
lifecycle wiring, roughly ten files. The commit changed 334 files with 3,665
insertions and 3,845 deletions, including 323 public-to-internal visibility
conversions across the App assembly, 55 test files, two retired conformance
tests, and a self-described temporary escape hatch for bridging raw-GL viewport
textures. Even without the regression, that is not separable into the part
worth keeping and the part worth dropping.
Reverting rather than patching because the good work here - the RHI frame
lifecycle wiring and a genuine render-state-cache staleness fix - is small
enough to redo cleanly against a tightened spec, while untangling it from 300+
files of unrelated churn is not.
Post-revert: Release build clean, App suite back to 3,843 passed / 3 skipped,
offline pixel gate passing at 19 differing pixels.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
45 lines
2.3 KiB
C#
45 lines
2.3 KiB
C#
// NdcScissorRect.cs
|
||
//
|
||
// NDC AABB → framebuffer-pixel scissor box, CONSERVATIVE (outer bound).
|
||
// The scissor that brackets a landscape/doorway slice is a fallback BOUND on
|
||
// the slice's view region (AD-17 in the divergence register): it must CONTAIN
|
||
// every fragment the per-fragment plane clip would keep. Under-inclusion is
|
||
// the bug class — the #130 doorway top-edge background strip was this box
|
||
// computed as Floor(origin) + Ceiling(size), whose far edge
|
||
// floor(min)+ceil(max−min) lands up to one pixel SHORT of the true max edge
|
||
// at unlucky fractional alignments, scissoring away the aperture's top/right
|
||
// pixel row for the whole slice (sky, terrain, statics, weather) while the
|
||
// seal still stamps it — a strip of clear color no later pass can fill.
|
||
//
|
||
// Correct outer bound: floor both mins, ceil both maxes, width = difference.
|
||
// A fragment at pixel (i,j) rasterizes iff its CENTER (i+0.5, j+0.5) lies in
|
||
// the region ⊆ the NDC box [X0,X1]×[Y0,Y1] (pixel units). Center-inside ⇒
|
||
// i ≥ X0−0.5 ⇒ i ≥ floor(X0) and i ≤ X1−0.5 ⇒ i < ceil(X1). So
|
||
// [floor(X0), ceil(X1)) admits every center-inside pixel, over-including by
|
||
// at most one pixel per edge — safe per AD-17's doctrine (the wall shell /
|
||
// plane clip repaints or kills the surplus).
|
||
using System;
|
||
using System.Numerics;
|
||
|
||
namespace AcDream.App.Rendering;
|
||
|
||
public static class NdcScissorRect
|
||
{
|
||
/// <summary>Convert an NDC AABB (minX, minY, maxX, maxY in [-1,1]) to a
|
||
/// framebuffer-pixel scissor box that CONTAINS it. Inputs are clamped to
|
||
/// the screen so a region extending past an edge still yields a valid box.
|
||
/// Width/height are at least 1.</summary>
|
||
public static (int X, int Y, int Width, int Height) ToPixels(
|
||
Vector4 ndcAabb, int fbWidth, int fbHeight)
|
||
{
|
||
float nx0 = Math.Clamp(ndcAabb.X, -1f, 1f);
|
||
float ny0 = Math.Clamp(ndcAabb.Y, -1f, 1f);
|
||
float nx1 = Math.Clamp(ndcAabb.Z, -1f, 1f);
|
||
float ny1 = Math.Clamp(ndcAabb.W, -1f, 1f);
|
||
int px0 = (int)MathF.Floor((nx0 * 0.5f + 0.5f) * fbWidth);
|
||
int py0 = (int)MathF.Floor((ny0 * 0.5f + 0.5f) * fbHeight);
|
||
int px1 = (int)MathF.Ceiling((nx1 * 0.5f + 0.5f) * fbWidth);
|
||
int py1 = (int)MathF.Ceiling((ny1 * 0.5f + 0.5f) * fbHeight);
|
||
return (px0, py0, Math.Max(1, px1 - px0), Math.Max(1, py1 - py0));
|
||
}
|
||
}
|