Campaign CT slice A4, and the first slice of Group A that shows on screen: a player's name in a chat line now draws green while the rest of the line keeps its message colour. The colour is AUTHORED, not computed. Retail keeps two parallel index-selected colour arrays on the text element and refreshes both from the same caller index on every append (UIElement_Text::AppendStringInfoWithFont @0x00469DE0): property 0x1B for ordinary glyphs, 0x1D for glyphs under an open tag. Property 0x1D is read exactly the way 0x1B already was, carried on ElementInfo, and seeded onto UiText beside DefaultColor. Measured on the chat transcript (0x2100006F / 0x10000011) as RGB(0,178,0). It deliberately does NOT go into RetailChatColorTable. That table is the runtime-built per-LogTextType mapping; the tag colour is per-element authored data, and filing it there would put it somewhere it would look right in tests and be wrong in principle. RunsForFragment is the load-bearing piece and is pure. Wrapping can drop the space it broke on, so a fragment is NOT simply the next N characters of the line — BuildLines locates each fragment in the source text to keep the span offsets honest, and the mapper clips spans to the fragment window. A tag straddling a wrap break is therefore split across both fragments and stays green on both, instead of changing colour mid-word. Two guards worth naming. A fragment containing no tag returns NULL rather than a single-run list, so the overwhelming majority of lines keep the existing flat draw path untouched. And an element authoring no 0x1D falls back to the line colour, so a name never renders in a colour nobody chose. The run/fragment contract is property-tested across every substring of a tell line, because CT-A1's RunsMatchLine refuses mismatched runs by silently falling back to flat text — a mapping bug here would degrade quietly rather than fail. Solution builds clean; full hermetic gate green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
261 lines
11 KiB
C#
261 lines
11 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Numerics;
|
|
using AcDream.Core.Chat;
|
|
using AcDream.UI.Abstractions.Panels.Chat;
|
|
|
|
namespace AcDream.App.UI.Layout;
|
|
|
|
/// <summary>
|
|
/// Shared word-wrap + retail color-carry-forward transcript line builder.
|
|
/// Factored out of <see cref="ChatWindowController.GetTranscriptLines"/>
|
|
/// (Campaign CH slice CH6b) so <see cref="FloatingChatWindowController"/>
|
|
/// reuses the exact same algorithm instead of duplicating it — both the main
|
|
/// chat window and the four floating windows are views over the SAME
|
|
/// <see cref="ChatVM"/> transcript (J4.1 pattern: one canonical log, many
|
|
/// filtered presentations).
|
|
///
|
|
/// <para>
|
|
/// Pure function — callers own their own per-controller layout cache
|
|
/// (revision/wrap-width/font keyed), matching the caching each controller
|
|
/// already had before this extraction.
|
|
/// </para>
|
|
///
|
|
/// <para>
|
|
/// <see cref="WrapText"/> also lives here (CH6a/b REJECT-review NIT 5 — it
|
|
/// used to live on <see cref="ChatWindowController"/>, which made
|
|
/// <see cref="BuildLines"/> call BACK into its own caller's class, a circular
|
|
/// dependency between this "shared" module and one of its two consumers).
|
|
/// </para>
|
|
/// </summary>
|
|
internal static class ChatTranscriptRenderer
|
|
{
|
|
/// <param name="detailed">Tail of the shared chat log, formatted with retail metadata.</param>
|
|
/// <param name="maxW">Wrap width in pixels.</param>
|
|
/// <param name="measure">Glyph-width measurer for the active font.</param>
|
|
/// <param name="accept">
|
|
/// Optional per-line filter — retail's <c>ChatInterface::TypeIsActive</c>
|
|
/// (or the full <c>ShouldDisplay</c> predicate) for THIS window. Null
|
|
/// accepts every line. CH6a/b REJECT-review SHOULD-FIX 2: the main
|
|
/// window now ALWAYS passes a real predicate too (its own retail default
|
|
/// 0xFBFFFFFF filter via <c>ChatWindowState</c>) — null remains supported
|
|
/// for callers with no filter concept at all (there are none in
|
|
/// production today, but the shape stays general). A line that fails the
|
|
/// filter is dropped from this window's view WITHOUT advancing the
|
|
/// carried-forward color, matching retail's <c>m_curFontColor</c> only
|
|
/// advancing for lines actually appended to THIS window's own scroll
|
|
/// (<c>AppendStringInfoWithFont</c> only runs for displayed lines).
|
|
/// </param>
|
|
/// <param name="defaultColor">
|
|
/// The transcript element's own base fill color — retail's
|
|
/// <c>m_curFontColor</c> BEFORE any <c>AppendTextWithFont</c> call ever
|
|
/// tints it, i.e. the value <c>DoFontReset</c> seeds from the element's
|
|
/// authored LayoutDesc property <c>0x1B</c> (style <c>0x10000372</c>:
|
|
/// <c>ARGB(255,204,204,204)</c> for the main chat transcript). Campaign
|
|
/// CH round 4 (<c>docs/research/2026-08-10-retail-ui-text-style.md</c>
|
|
/// §5.2 Fix 5): this used to be hardcoded to
|
|
/// <c>RetailChatColorTable.TryGetColor(0x00u, ...)</c> (colorGreen) —
|
|
/// the color table's OWN default-slot color, not the ELEMENT's authored
|
|
/// default. The two are unrelated: the table governs the per-message
|
|
/// <c>LogTextType</c> tint (untouched by this parameter — every message
|
|
/// with an in-range type still resolves its own table color exactly as
|
|
/// before), while <paramref name="defaultColor"/> is only the carried-
|
|
/// forward seed for a line whose type falls OUTSIDE the table's 34
|
|
/// entries (matching retail's out-of-range "leave <c>m_curFontColor</c>
|
|
/// unchanged" rule — see <see cref="RetailChatColorTable"/>'s own doc).
|
|
/// Callers pass their transcript's <see cref="UiText.DefaultColor"/>.
|
|
/// </param>
|
|
/// <summary>
|
|
/// The runs covering one wrapped fragment, or <see langword="null"/> when
|
|
/// the fragment is a single colour.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// <para>
|
|
/// Campaign CT slice A4. Wrapping splits a line into fragments, and a tag
|
|
/// can straddle a break, so a fragment may hold part of a tagged run, all
|
|
/// of it, or none.
|
|
/// </para>
|
|
/// <para>
|
|
/// Returns null unless a tag actually falls inside the window — a
|
|
/// single-colour fragment must take the ordinary flat draw path rather
|
|
/// than a one-run list that means the same thing.
|
|
/// </para>
|
|
/// </remarks>
|
|
internal static IReadOnlyList<UiText.TextRun>? RunsForFragment(
|
|
IReadOnlyList<ChatTextSpan> spans,
|
|
int fragmentStart,
|
|
int fragmentLength,
|
|
Vector4 lineColor,
|
|
Vector4 tagColor)
|
|
{
|
|
int fragmentEnd = fragmentStart + fragmentLength;
|
|
var runs = new List<UiText.TextRun>();
|
|
bool sawTag = false;
|
|
int at = 0;
|
|
|
|
foreach (ChatTextSpan span in spans)
|
|
{
|
|
int spanStart = at;
|
|
int spanEnd = at + span.Text.Length;
|
|
at = spanEnd;
|
|
|
|
int from = Math.Max(spanStart, fragmentStart);
|
|
int to = Math.Min(spanEnd, fragmentEnd);
|
|
if (to <= from)
|
|
continue;
|
|
|
|
bool tagged = span.Tag is not null;
|
|
sawTag |= tagged;
|
|
runs.Add(new UiText.TextRun(
|
|
span.Text.Substring(from - spanStart, to - from),
|
|
tagged ? tagColor : lineColor));
|
|
}
|
|
|
|
return sawTag ? runs : null;
|
|
}
|
|
|
|
public static List<UiText.Line> BuildLines(
|
|
IReadOnlyList<FormattedLine> detailed,
|
|
float maxW,
|
|
Func<string, float> measure,
|
|
Func<uint, bool>? accept,
|
|
Vector4 defaultColor,
|
|
Vector4? tagColor = null,
|
|
List<IReadOnlyList<UiText.TextRun>?>? runsPerLine = null)
|
|
{
|
|
var result = new List<UiText.Line>(detailed.Count);
|
|
runsPerLine?.Clear();
|
|
if (detailed.Count == 0)
|
|
return result;
|
|
|
|
// Retail's font-color state (m_curFontColor) persists across every line
|
|
// actually appended to this window — an out-of-range LogTextType leaves it
|
|
// unchanged rather than reverting to a color-table default (color-table doc
|
|
// §3.2). Seed the carry with the ELEMENT's own authored default fill
|
|
// (defaultColor), matching retail's DoFontReset — not the color table's
|
|
// unrelated index-0x00 slot.
|
|
Vector4 currentColor = defaultColor;
|
|
foreach (FormattedLine d in detailed)
|
|
{
|
|
if (accept is not null && !accept(d.LogTextType))
|
|
continue;
|
|
if (RetailChatColorTable.TryGetColor(d.LogTextType, out Vector4 resolved))
|
|
currentColor = resolved;
|
|
// Wrapping can DROP the space it broke on, so a fragment is not
|
|
// simply the next N characters — locate each one in the source
|
|
// line to keep the span offsets honest.
|
|
int searchFrom = 0;
|
|
foreach (string frag in WrapText(d.Text, maxW, measure))
|
|
{
|
|
result.Add(new UiText.Line(frag, currentColor));
|
|
|
|
if (runsPerLine is null)
|
|
continue;
|
|
|
|
if (d.Spans is not { Count: > 0 } spans || frag.Length == 0)
|
|
{
|
|
runsPerLine.Add(null);
|
|
continue;
|
|
}
|
|
|
|
int at = d.Text.IndexOf(frag, searchFrom, StringComparison.Ordinal);
|
|
if (at < 0)
|
|
{
|
|
// Should not happen; a fragment always comes from the line.
|
|
// Fall back to the flat colour rather than mis-colouring.
|
|
runsPerLine.Add(null);
|
|
continue;
|
|
}
|
|
searchFrom = at + frag.Length;
|
|
|
|
runsPerLine.Add(RunsForFragment(
|
|
spans,
|
|
at,
|
|
frag.Length,
|
|
currentColor,
|
|
tagColor ?? currentColor));
|
|
}
|
|
}
|
|
return result;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Greedy word-wrap: split <paramref name="text"/> into fragments that each fit in
|
|
/// <paramref name="maxW"/> pixels (per <paramref name="measure"/>), breaking at spaces.
|
|
/// A word that is itself wider than the line is broken at CHARACTER boundaries (no
|
|
/// hyphen), packed onto the current line first — so a long unbroken token (e.g. a URL
|
|
/// or "wwwww…") wraps instead of overflowing, and a "You say," prefix stays on the same
|
|
/// row as the start of the message. Mirrors retail GlyphList::Recalculate's per-GlyphLine
|
|
/// emission (which breaks mid-glyph-run when a run exceeds the wrap width).
|
|
/// </summary>
|
|
public static IEnumerable<string> WrapText(string text, float maxW, Func<string, float> measure)
|
|
{
|
|
if (string.IsNullOrEmpty(text))
|
|
{
|
|
yield return string.Empty;
|
|
yield break;
|
|
}
|
|
|
|
// Campaign CH user-gate round 1 (item F): server text (e.g. /help's
|
|
// reply) carries embedded '\n's. This function used to hand the
|
|
// WHOLE blob — newlines and all — to the single early-out below,
|
|
// rendering multi-line text as one UiText.Line with literal newline
|
|
// characters in it instead of one rendered line per segment. Split
|
|
// on '\n' FIRST (normalizing "\r\n"/bare "\r" the same way), then
|
|
// word-wrap each segment independently; the early-out is now scoped
|
|
// to one already-newline-free segment, so it only ever collapses a
|
|
// single-segment text to one line, never a multi-line one.
|
|
string normalized = text.Replace("\r\n", "\n").Replace('\r', '\n');
|
|
foreach (string segment in normalized.Split('\n'))
|
|
{
|
|
foreach (string frag in WrapSingleLine(segment, maxW, measure))
|
|
yield return frag;
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Greedy word-wrap for a single, already newline-free line. Split out of
|
|
/// <see cref="WrapText"/> (Campaign CH user-gate round 1, item F) so the
|
|
/// multi-segment split there can call this once per '\n'-delimited
|
|
/// segment without re-deriving the per-line wrap algorithm.
|
|
/// </summary>
|
|
private static IEnumerable<string> WrapSingleLine(string text, float maxW, Func<string, float> measure)
|
|
{
|
|
if (text.Length == 0 || maxW <= 0f || measure(text) <= maxW)
|
|
{
|
|
yield return text;
|
|
yield break;
|
|
}
|
|
|
|
var line = new System.Text.StringBuilder();
|
|
foreach (var word in text.Split(' '))
|
|
{
|
|
string sep = line.Length > 0 ? " " : string.Empty;
|
|
if (measure(line.ToString() + sep + word) <= maxW)
|
|
{
|
|
line.Append(sep).Append(word); // fits on the current line
|
|
continue;
|
|
}
|
|
if (line.Length > 0 && measure(word) <= maxW)
|
|
{
|
|
yield return line.ToString(); // word fits alone → push to a new line
|
|
line.Clear();
|
|
line.Append(word);
|
|
continue;
|
|
}
|
|
// Word too long for any single line: char-wrap it, packing onto the current
|
|
// line's remaining space first (keeps the prefix with the message start).
|
|
if (line.Length > 0) line.Append(' ');
|
|
foreach (char ch in word)
|
|
{
|
|
if (line.Length > 0 && measure(line.ToString() + ch) > maxW)
|
|
{
|
|
yield return line.ToString();
|
|
line.Clear();
|
|
}
|
|
line.Append(ch);
|
|
}
|
|
}
|
|
if (line.Length > 0) yield return line.ToString();
|
|
}
|
|
}
|