User reported the chat input field disappearing when the chat
window was resized smaller — older entries pushed it past the
visible area. Standard ImGui chat-window pattern fixes it: scrollable
nested region for the chat tail, fixed footer for the
separator + input field below it.
IPanelRenderer extensions (Phase J Tier 3):
- BeginChild(string id, Vector2 size, bool border = false) — opens
a nested scrollable region. Size follows ImGui semantics:
0 = fill available, negative = fill available minus this much.
- EndChild() — closes the nested region.
- FrameHeightWithSpacing() — single-line widget height incl. frame
padding + item spacing. Lets panels compute footer reservations
without hardcoding pixel constants.
- SetScrollHereY(float ratio) — forces scroll within current region;
pass 1.0f to keep the latest line visible after new entries
arrive.
ImGuiPanelRenderer impls. ImGui.NET's BeginChild signature changed
across versions (third arg moved from `bool border` to
`ImGuiChildFlags`); we cast a numeric literal (0x01 = Border bit)
to sidestep the rename. FrameHeightWithSpacing maps to
ImGui.GetFrameHeightWithSpacing(); SetScrollHereY to ImGui.SetScrollHereY.
ChatPanel restructured:
- Reserves footer height = FrameHeightWithSpacing() + 6f (small pad
for the separator above the input).
- Wraps the chat tail in BeginChild("##chattail", (0, -footer))
so the inner region scrolls independently of the window.
- Tracks _lastRenderedCount across frames and calls SetScrollHereY(1f)
only when new entries appended — manual scroll-up isn't fought
against; new messages jump the view back down only when they
actually arrive.
- Header Separator removed (the BeginChild border is enough).
FakePanelRenderer extended with the four new methods + recording.
4 new tests in ChatPanelLayoutTests pin the layout invariants:
- Render order: Begin → BeginChild → ... → EndChild → Separator
→ InputTextSubmit → End.
- BeginChild size has X=0 + negative Y at least matching the
injected FrameHeightWithSpacingValue.
- SetScrollHereY fires when entries grow.
- SetScrollHereY does NOT fire when entries don't grow.
Solution total: 1067 green (243 Core.Net + 164 UI + 660 Core),
0 warnings.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
165 lines
6.3 KiB
C#
165 lines
6.3 KiB
C#
using System.Numerics;
|
|
|
|
namespace AcDream.UI.Abstractions.Tests;
|
|
|
|
/// <summary>
|
|
/// In-memory test double for <see cref="IPanelRenderer"/>. Records every
|
|
/// widget call so tests can assert against the recorded trace without
|
|
/// running an ImGui context. New widgets added to the interface must
|
|
/// implement here too — that compilation error IS the TDD red signal.
|
|
/// </summary>
|
|
internal sealed class FakePanelRenderer : IPanelRenderer
|
|
{
|
|
/// <summary>Ordered list of (method, args) pairs recorded across this renderer's lifetime.</summary>
|
|
public List<(string Method, object?[] Args)> Calls { get; } = new();
|
|
|
|
/// <summary>If <see cref="Begin"/> is called, return this value. Defaults to true so panels render.</summary>
|
|
public bool BeginReturns { get; set; } = true;
|
|
|
|
// -- Inputs the panel under test can mutate via ref args -----------
|
|
|
|
/// <summary>Pre-set return value for the next <see cref="Checkbox"/> — caller flips bool to simulate user click.</summary>
|
|
public bool CheckboxNextReturn { get; set; }
|
|
public bool? CheckboxNextValue { get; set; }
|
|
|
|
/// <summary>Pre-set return value for the next <see cref="Button"/> — caller sets to simulate user click.</summary>
|
|
public bool ButtonNextReturn { get; set; }
|
|
|
|
/// <summary>Pre-set return value for the next <see cref="Combo"/>.</summary>
|
|
public bool ComboNextReturn { get; set; }
|
|
public int? ComboNextSelectedIndex { get; set; }
|
|
|
|
/// <summary>Pre-set return for <see cref="SliderFloat"/>.</summary>
|
|
public bool SliderFloatNextReturn { get; set; }
|
|
public float? SliderFloatNextValue { get; set; }
|
|
|
|
/// <summary>Pre-set return for <see cref="CollapsingHeader"/>.</summary>
|
|
public bool CollapsingHeaderNextReturn { get; set; } = true;
|
|
|
|
/// <summary>Pre-set return for <see cref="TreeNode"/>.</summary>
|
|
public bool TreeNodeNextReturn { get; set; } = true;
|
|
|
|
/// <summary>Pre-set return for <see cref="BeginTable"/>.</summary>
|
|
public bool BeginTableNextReturn { get; set; } = true;
|
|
|
|
/// <summary>Pre-set return for <see cref="BeginChild"/>.</summary>
|
|
public bool BeginChildNextReturn { get; set; } = true;
|
|
|
|
/// <summary>Pre-set return value for <see cref="FrameHeightWithSpacing"/>.</summary>
|
|
public float FrameHeightWithSpacingValue { get; set; } = 24f;
|
|
|
|
/// <summary>Pre-set "submitted" string for the next <see cref="InputTextSubmit"/>; null = no submit this frame.</summary>
|
|
public string? InputTextSubmitNextSubmitted { get; set; }
|
|
public string? InputTextSubmitNextBufferAfter { get; set; }
|
|
|
|
public bool Begin(string title)
|
|
{
|
|
Calls.Add(("Begin", new object?[] { title }));
|
|
return BeginReturns;
|
|
}
|
|
|
|
public void End() => Calls.Add(("End", Array.Empty<object?>()));
|
|
|
|
public void Text(string text) => Calls.Add(("Text", new object?[] { text }));
|
|
|
|
public void SameLine() => Calls.Add(("SameLine", Array.Empty<object?>()));
|
|
|
|
public void Separator() => Calls.Add(("Separator", Array.Empty<object?>()));
|
|
|
|
public void ProgressBar(float fraction, float width, string? overlay = null)
|
|
=> Calls.Add(("ProgressBar", new object?[] { fraction, width, overlay }));
|
|
|
|
public void TextColored(Vector4 rgba, string text)
|
|
=> Calls.Add(("TextColored", new object?[] { rgba, text }));
|
|
|
|
public bool CollapsingHeader(string label, bool defaultOpen = true)
|
|
{
|
|
Calls.Add(("CollapsingHeader", new object?[] { label, defaultOpen }));
|
|
return CollapsingHeaderNextReturn;
|
|
}
|
|
|
|
public bool TreeNode(string label)
|
|
{
|
|
Calls.Add(("TreeNode", new object?[] { label }));
|
|
return TreeNodeNextReturn;
|
|
}
|
|
|
|
public void TreePop() => Calls.Add(("TreePop", Array.Empty<object?>()));
|
|
|
|
public bool Checkbox(string label, ref bool value)
|
|
{
|
|
Calls.Add(("Checkbox", new object?[] { label, value }));
|
|
if (CheckboxNextValue is bool nv) value = nv;
|
|
return CheckboxNextReturn;
|
|
}
|
|
|
|
public bool Button(string label)
|
|
{
|
|
Calls.Add(("Button", new object?[] { label }));
|
|
return ButtonNextReturn;
|
|
}
|
|
|
|
public bool Combo(string label, ref int selectedIndex, string[] items)
|
|
{
|
|
Calls.Add(("Combo", new object?[] { label, selectedIndex, items }));
|
|
if (ComboNextSelectedIndex is int idx) selectedIndex = idx;
|
|
return ComboNextReturn;
|
|
}
|
|
|
|
public bool SliderFloat(string label, ref float value, float min, float max)
|
|
{
|
|
Calls.Add(("SliderFloat", new object?[] { label, value, min, max }));
|
|
if (SliderFloatNextValue is float v) value = v;
|
|
return SliderFloatNextReturn;
|
|
}
|
|
|
|
public void PlotLines(
|
|
string label,
|
|
float[] values,
|
|
int count,
|
|
int offset = 0,
|
|
string? overlay = null,
|
|
float? min = null,
|
|
float? max = null,
|
|
Vector2? size = null)
|
|
=> Calls.Add(("PlotLines", new object?[] { label, values, count, offset, overlay, min, max, size }));
|
|
|
|
public void BeginTable(string id, int columns)
|
|
=> Calls.Add(("BeginTable", new object?[] { id, columns }));
|
|
|
|
public void TableNextColumn() => Calls.Add(("TableNextColumn", Array.Empty<object?>()));
|
|
|
|
public void EndTable() => Calls.Add(("EndTable", Array.Empty<object?>()));
|
|
|
|
public bool InputTextSubmit(string label, ref string buffer, int maxLen, out string? submitted)
|
|
{
|
|
Calls.Add(("InputTextSubmit", new object?[] { label, buffer, maxLen }));
|
|
submitted = InputTextSubmitNextSubmitted;
|
|
if (submitted is not null)
|
|
buffer = InputTextSubmitNextBufferAfter ?? string.Empty;
|
|
return submitted is not null;
|
|
}
|
|
|
|
public void Spacing() => Calls.Add(("Spacing", Array.Empty<object?>()));
|
|
|
|
public void Dummy(Vector2 size) => Calls.Add(("Dummy", new object?[] { size }));
|
|
|
|
public void TextWrapped(string text) => Calls.Add(("TextWrapped", new object?[] { text }));
|
|
|
|
public bool BeginChild(string id, Vector2 size, bool border = false)
|
|
{
|
|
Calls.Add(("BeginChild", new object?[] { id, size, border }));
|
|
return BeginChildNextReturn;
|
|
}
|
|
|
|
public void EndChild() => Calls.Add(("EndChild", Array.Empty<object?>()));
|
|
|
|
public float FrameHeightWithSpacing()
|
|
{
|
|
Calls.Add(("FrameHeightWithSpacing", Array.Empty<object?>()));
|
|
return FrameHeightWithSpacingValue;
|
|
}
|
|
|
|
public void SetScrollHereY(float ratio)
|
|
=> Calls.Add(("SetScrollHereY", new object?[] { ratio }));
|
|
}
|