acdream/tests/AcDream.Core.Tests/Physics
Erik 39fc0372a3 fix(test): A6.P3 slice 1 T5 — redesign test to actually catch synthesis regression
Code-review feedback on commit 5f7722a: the test was gamed —
placing the sphere exactly on the floor (worldPosZ = floorZ) made it
pass regardless of whether synthesis was present. With sphere center at
Z=0.48 (= floorZ + SphereRadius), PolygonHitsSpherePrecise's distance
guard fires immediately (|dist|=0.48 > rad=0.478) and
TryFindIndoorWalkablePlane returns false even WITH synthesis code. The
test would have passed even if the strip were reverted.

Redesign: restore worldPosZ = floorZ - 0.05f (sphere center at Z=0.43).
Now |dist|=0.43 < rad=0.478 → the guard passes → TryFindIndoorWalkablePlane
finds the floor polygon → synthesis would fire → CP writes every frame.
Path 5 (Contact branch) is not a concern: the loop moves only in X so
movement = (0.001, 0, 0), Dot(movement, floor_normal=(0,0,1)) = 0 ≥ 0 →
PosHitsSphere front-face cull rejects the floor hit even with sphere
center below the floor. Path 5 returns OK with zero CP writes. Contact
flag is left set to keep the test on the realistic grounded-mover path.

Validated locally by temporarily re-introducing the synthesis call —
test fails with 60 writes (1 per frame) pre-strip, passes with 0
additional writes post-strip. Now a real regression sentinel.

1148 pass + 8 pre-existing fail baseline maintained.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-22 09:28:16 +02:00
..
AnimationCommandRouterTests.cs fix(anim): Phase L.1b route motion commands 2026-04-28 10:46:22 +02:00
AnimationHookRouterTests.cs feat(anim): Phase E.1 hook router + GameWindow wiring 2026-04-18 16:30:23 +02:00
AnimationSequencerTests.cs fix(animation): close #61 + smooth stop from backward/sidestep-left/turn-left 2026-05-18 15:16:20 +02:00
BSPQueryTests.cs test(physics): BSPQuery.FindCollisions writes world-space plane with translated origin 2026-05-20 07:58:37 +02:00
BSPStepUpFixtures.cs feat(physics): Phase L.2.1+L.2.2 — BSP step-up and rooftop landing 2026-04-29 16:16:39 +02:00
BSPStepUpTests.cs fix(physics): L.4 — steep airborne hits slide-tangent (interim, deviates from retail) 2026-04-30 13:22:07 +02:00
CellPhysicsPortalWiringTests.cs feat(physics): Phase 2 — wire CellBSP + Portals into CellPhysics 2026-05-19 16:52:20 +02:00
CellSurfaceTests.cs feat(core): Phase B.3 — CellSurface (indoor floor polygon projection) 2026-04-12 09:51:22 +02:00
CellTransitAddAllOutsideCellsTests.cs feat(physics): Phase 2 — port CellTransit + wire into ResolveCellId 2026-05-19 17:14:04 +02:00
CellTransitCheckBuildingTransitTests.cs refactor(physics): Phase 2 — code-review polish on BuildingPhysics commit 2026-05-19 18:01:44 +02:00
CellTransitFindCellListTests.cs feat(physics): Phase 2 — BuildingPhysics + CheckBuildingTransit 2026-05-19 17:34:38 +02:00
CellTransitFindCellSetTests.cs feat(physics): A4 — CellTransit.FindCellSet overload exposes candidate set 2026-05-20 16:11:31 +02:00
CellTransitFindTransitCellsSphereTests.cs feat(physics): Phase 2 — port CellTransit + wire into ResolveCellId 2026-05-19 17:14:04 +02:00
CollisionExemptionTests.cs fix(phys L.2g slice 1b): widen CollisionExemption to ETHEREAL alone 2026-05-13 18:27:06 +02:00
CollisionPrimitivesTests.cs feat(physics): port 9 collision primitives from acclient.exe (chunk_00530000.c) 2026-04-12 23:53:47 +02:00
EntityCollisionFlagsTests.cs feat(physics): live-entity collision plumbing (Commit A) 2026-04-29 13:12:56 +02:00
FindEnvCollisionsMultiCellTests.cs Reapply "feat(physics): A4 — wire CheckOtherCells into FindEnvCollisions" 2026-05-20 20:06:14 +02:00
IndoorContactPlaneRetentionTests.cs fix(test): A6.P3 slice 1 T5 — redesign test to actually catch synthesis regression 2026-05-22 09:28:16 +02:00
IndoorWalkablePlaneTests.cs Revert "fix(physics): remove per-frame indoor walkable-plane synthesis" 2026-05-20 09:17:24 +02:00
InterpolationManagerTests.cs feat(motion): L.3 M1 — fresh InterpolationManager port + retail spec 2026-05-05 14:56:42 +02:00
MotionCommandResolverTests.cs fix(anim): Phase L.1b route motion commands 2026-04-28 10:46:22 +02:00
MotionInterpreterTests.cs test(physics): MyRunRate fallback test for GetMaxSpeed (L.3.1 Task 2 polish) 2026-05-02 19:20:39 +02:00
PhysicsBodyTests.cs feat(core): port decompiled AC client physics — CollisionPrimitives + PhysicsBody 2026-04-12 23:54:51 +02:00
PhysicsDiagnosticsTests.cs feat(physics): A6.P1 — add ProbePushBackEnabled toggle 2026-05-21 18:24:22 +02:00
PhysicsEngineTests.cs fix(physics): Cluster A #84 + #85 — indoor cell tracking 2026-05-19 15:20:36 +02:00
PlayerWeenieTests.cs feat(physics): PlayerWeenie with retail Run/Jump formulas 2026-04-13 23:15:25 +02:00
PortalInfoTests.cs feat(physics): Phase 2 — wire CellBSP + Portals into CellPhysics 2026-05-19 16:52:20 +02:00
PortalPlaneTests.cs feat(core): Phase B.3 — PortalPlane (plane math + crossing detection) 2026-04-12 18:17:48 +02:00
PositionManagerTests.cs fix(motion): project anim root motion onto terrain plane (slope staircase) 2026-05-05 21:37:42 +02:00
RemoteMoveToDriverTests.cs fix(retail): rotation rate, useability gate, retail toast strings 2026-05-16 12:17:54 +02:00
ResolveCellIdTests.cs feat(physics): Phase 2 — BuildingPhysics + CheckBuildingTransit 2026-05-19 17:34:38 +02:00
ServerControlledLocomotionTests.cs fix(anim): Phase L.1c match MoveTo run speed 2026-04-28 20:58:22 +02:00
ShadowObjectRegistryTests.cs feat(phys L.2g slice 1): ShadowObjectRegistry.UpdatePhysicsState 2026-05-12 22:22:32 +02:00
SphereIntersectsCellBspTests.cs fix(physics): #90 — sphere-overlap cell stickiness at doorway threshold 2026-05-20 20:30:36 +02:00
TerrainSurfaceTests.cs fix(scenery): #49 9×9 loop, per-spawn building check, triangle slope 2026-05-07 21:15:11 +02:00
TransitionCheckOtherCellsTests.cs feat(physics): A4 — Transition.CheckOtherCells + ApplyOtherCellResult 2026-05-20 16:14:05 +02:00
TransitionTests.cs feat(physics): Transition.FindTransitionalPosition core algorithm 2026-04-13 23:52:45 +02:00
TransitionTypesTests.cs Revert "fix(physics): remove per-frame indoor walkable-plane synthesis" 2026-05-20 09:17:24 +02:00
WalkMissDiagnosticTests.cs feat(physics): WalkMissDiagnostic aggregator for ISSUES #83 probe spike 2026-05-20 10:31:39 +02:00