Procedural-scenery foliage (trees/bushes — entity ids in the ProceduralSceneryIdAllocator's 0x8XXYYIII namespace) sways with weather in mesh_atmospheric.vert and all four directional_shadow_world_* caster vertex shaders, both calling the identical new foliage_wind.glsl include so the shadow moves with the leaf by construction. Classification (FoliageWindClassification, AcDream.App.Rendering.Wb): two new BatchData.flags bits, computed once per (entity, subset) from four inputs — entity id (bit 31 for procedural scenery), the pack's declared FoliageExclusions membership, the subset's TranslucencyKind, and ObjectRenderData.HasCutoutSubset (computed once per mesh at build time, not per frame). Bit 1 marks an alpha-cutout leaf subset; bit 2 marks an opaque trunk subset (only when its own mesh also owns a cutout subset, so rocks stay still). WbDrawDispatcher.ClassifyBatches (world receiver) and AddDirectionalShadowBatches (caster) call this with the same four inputs, so casters and receivers classify identically without needing to share state. Retail's mesh_modern/terrain_modern/mesh_detail pipelines never read these bits, so pack-off output is unaffected. Motion model (foliage_wind.glsl, mirrored bit-for-bit in the new FoliageWindModel for hermetic CPU tests): height-squared-scaled slow lean for every foliage subset, plus branch swing and per-vertex-hash-decorrelated flutter for cutout subsets only. AtmosphericPostProcessGraph.ResolveFoliageWind resolves the wind block once per frame.Serial — advanced by whichever of RenderDirectionalShadows (which runs first) or RenderPostProcess is called first that frame, with the second reading the already-advanced state, which is what keeps the caster and receiver reading byte-identical clock/strength values. The per-day-group mean/gust target (AtmospherePolicyDeclaration. FoliageWindByDayGroup, keyed by the same day-group index convention ActiveDayGroupMultipliers already established: Clear/Cloudy/Overcast/Rainy) eases toward its target over WeatherSystem.TransitionSeconds (10s) so a weather change never snaps; wind-enabled off or indoor instead gates the OUTPUT to an exact zero (not an asymptotic approach) so a settings toggle or cell transition is immediate. The wind clock is a Stopwatch started at graph construction (monotonic, session-relative magnitude for GPU sin() accuracy), overridable by the same ACDREAM_SKY_PHASE_SECONDS pin SkyRenderer already uses, for deterministic offline gates. New settings: wind-enabled, wind-strength, wind-direction-degrees (225° default — no authored retail wind direction exists to read), wind-lean-metres, wind-branch-metres, wind-flutter-metres (0 on Low), wind-canopy-height-metres. Register row IA-25 files this as an intentional, strictly opt-in divergence: retail applies no per-vertex wind displacement to any geometry. Known, accepted limitation: classification is per mesh-subset (one BatchData.flags word per indirect-draw batch), not per entity instance, so the rare case of one mesh subset being reachable from both a procedural-scenery and a non-scenery placement would classify all of that subset's instances alike. Tests: FoliageWindClassificationTests (the full classification matrix), FoliageWindModelTests (identity on non-foliage/calm-wind/base-vertex, canopy-top displacement bound, z-never-increases, trunk has no flutter term), RenderPackAtmospherePolicyEvaluationTests (exact day-group lookup, no interpolation across day-group ids, easing convergence without overshoot or discontinuity), AtmosphericShaderAbiTests (each of the five shaders calls acdreamFoliageDisplace exactly once; mesh_modern/terrain/mesh_detail call it never), and four AtmosphericPostProcessGraphTests additions (indoor/disabled exact-zero gating, settings-to-UBO wiring, same-frame-Serial idempotency — the last proxies the caster/receiver agreement invariant without needing this hermetic harness's WbDrawDispatcher/TerrainModernRenderer dependency chain to exercise RenderDirectionalShadows directly). App hermetic filter: 6015/6017 (the same 2 pre-existing failures as VM6a, confirmed unrelated). Core.Tests hermetic: 4697/4697. RenderPackValidator.Tests: 30/30. Full solution Debug and Release builds green. Shader recompile touched exactly the 5 edited files' .spv (plus manifest); the retail oracle set and every other pack shader are byte-identical. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
146 lines
5 KiB
C#
146 lines
5 KiB
C#
using AcDream.App.Rendering.Packs;
|
|
using AcDream.Plugin.Abstractions.Rendering;
|
|
|
|
namespace AcDream.App.Tests.Rendering.Packs;
|
|
|
|
/// <summary>
|
|
/// Campaign VM VM6: <see cref="RenderPackAtmospherePolicyEvaluation.FoliageWind"/>
|
|
/// (the exact per-day-group mean/gust lookup) and
|
|
/// <see cref="RenderPackAtmospherePolicyEvaluation.EaseTowardTarget"/> (the
|
|
/// smoothing step that keeps a day-group change from snapping).
|
|
/// </summary>
|
|
public sealed class RenderPackAtmospherePolicyEvaluationTests
|
|
{
|
|
[Fact]
|
|
public void FoliageWindLooksUpExactDayGroupMatchOnly()
|
|
{
|
|
FoliageWindDayGroupPoint[] table =
|
|
[
|
|
new(0, 0.25, 0.15),
|
|
new(1, 0.45, 0.30),
|
|
new(2, 0.60, 0.35),
|
|
new(3, 0.85, 0.60),
|
|
];
|
|
|
|
(float mean, float gust) = RenderPackAtmospherePolicyEvaluation.FoliageWind(table, 3);
|
|
|
|
Assert.Equal(0.85f, mean);
|
|
Assert.Equal(0.60f, gust);
|
|
}
|
|
|
|
[Fact]
|
|
public void FoliageWindReturnsZeroForADayGroupAbsentFromTheTable()
|
|
{
|
|
FoliageWindDayGroupPoint[] table = [new(0, 0.25, 0.15)];
|
|
|
|
(float mean, float gust) = RenderPackAtmospherePolicyEvaluation.FoliageWind(table, 99);
|
|
|
|
Assert.Equal(0f, mean);
|
|
Assert.Equal(0f, gust);
|
|
}
|
|
|
|
[Fact]
|
|
public void FoliageWindReturnsZeroForANullTable()
|
|
{
|
|
(float mean, float gust) = RenderPackAtmospherePolicyEvaluation.FoliageWind(null, 0);
|
|
|
|
Assert.Equal(0f, mean);
|
|
Assert.Equal(0f, gust);
|
|
}
|
|
|
|
[Fact]
|
|
public void FoliageWindDoesNotInterpolateBetweenDayGroupIndices()
|
|
{
|
|
// Day-group ids are not ordered by "how windy" — index 1 sitting
|
|
// between 0 and 2 in the table must not produce a value between
|
|
// their mean/gust. This asserts the lookup is an exact match, not
|
|
// continuous interpolation across the index axis.
|
|
FoliageWindDayGroupPoint[] table = [new(0, 0.0, 0.0), new(5, 1.0, 1.0)];
|
|
|
|
(float meanAtUnlistedMidpoint, float gustAtUnlistedMidpoint) =
|
|
RenderPackAtmospherePolicyEvaluation.FoliageWind(table, 2);
|
|
|
|
Assert.Equal(0f, meanAtUnlistedMidpoint);
|
|
Assert.Equal(0f, gustAtUnlistedMidpoint);
|
|
}
|
|
|
|
[Fact]
|
|
public void EaseTowardTargetDoesNotMoveWithZeroDelta()
|
|
{
|
|
float result = RenderPackAtmospherePolicyEvaluation.EaseTowardTarget(
|
|
current: 0.25f,
|
|
target: 0.85f,
|
|
deltaSeconds: 0f,
|
|
transitionSeconds: 10f);
|
|
|
|
Assert.Equal(0.25f, result);
|
|
}
|
|
|
|
[Fact]
|
|
public void EaseTowardTargetConvergesWithoutOvershootOrDiscontinuity()
|
|
{
|
|
// Sample the same weather change (Clear 0.25 -> Rainy 0.85) many
|
|
// times over the transition window at a fixed per-tick delta and
|
|
// assert the sequence is monotonically non-decreasing and never
|
|
// jumps by more than one tick's proportional share — "no
|
|
// discontinuity across the delta window."
|
|
const float start = 0.25f;
|
|
const float target = 0.85f;
|
|
const float transitionSeconds = 10f;
|
|
const float tickSeconds = 0.1f;
|
|
float current = start;
|
|
float previous = current;
|
|
// A fixed-rate-per-tick ease is exponential decay toward the
|
|
// target, not a linear ramp: after N ticks the remaining gap is
|
|
// (1 - tickSeconds/transitionSeconds)^N of the original gap. 4000
|
|
// ticks (400 s of simulated time, 40x the transition window) leaves
|
|
// a remaining fraction of (0.99)^4000 ~= 4e-18 — comfortably
|
|
// converged without asserting a false linear-ramp expectation.
|
|
const int ticks = 4000;
|
|
|
|
for (int i = 0; i < ticks; i++)
|
|
{
|
|
current = RenderPackAtmospherePolicyEvaluation.EaseTowardTarget(
|
|
current,
|
|
target,
|
|
tickSeconds,
|
|
transitionSeconds);
|
|
|
|
Assert.True(
|
|
current >= previous - 1e-6f,
|
|
$"tick {i}: value regressed from {previous} to {current}");
|
|
Assert.True(
|
|
current <= target + 1e-6f,
|
|
$"tick {i}: value {current} overshot target {target}");
|
|
previous = current;
|
|
}
|
|
|
|
Assert.True(MathF.Abs(current - target) < 0.01f, $"did not converge: {current}");
|
|
}
|
|
|
|
[Fact]
|
|
public void EaseTowardTargetSnapsInOneStepWhenTransitionSecondsIsZeroOrLess()
|
|
{
|
|
float result = RenderPackAtmospherePolicyEvaluation.EaseTowardTarget(
|
|
current: 0f,
|
|
target: 1f,
|
|
deltaSeconds: 0.001f,
|
|
transitionSeconds: 0f);
|
|
|
|
Assert.Equal(1f, result);
|
|
}
|
|
|
|
[Fact]
|
|
public void EaseTowardTargetClampsAnOversizedDeltaInsteadOfOvershooting()
|
|
{
|
|
// A delta larger than the transition window (e.g. after a long
|
|
// pause) must not overshoot past the target.
|
|
float result = RenderPackAtmospherePolicyEvaluation.EaseTowardTarget(
|
|
current: 0f,
|
|
target: 1f,
|
|
deltaSeconds: 1000f,
|
|
transitionSeconds: 10f);
|
|
|
|
Assert.Equal(1f, result);
|
|
}
|
|
}
|