e4c99f54c0
Some checks are pending
Headless portability / portable-headless (ubuntu-latest) (push) Waiting to run
Headless portability / portable-headless (windows-latest) (push) Waiting to run
Headless portability / linux-graphical (push) Waiting to run
Headless portability / linux-vulkan (push) Waiting to run
The combat bar and spell bar could not be moved at all: their window mounts Draggable=false (correct - retail never whole-surface-drags them) and the authored move mechanism was missing. Retail registers element class 2 as UIElement_Dragbar (Register @ 0x0046C840); a press inside it calls UIElement::StartMovement on its parent window (StartMouseMoving @ 0x0046C760) and release calls StopMovement (@ 0x0046C7C0). The combat/spell bar layout (LayoutDesc 0x21000073) authors exactly one such element - a 600 x 5 strip along the top edge, which is where the user expects the move cursor. The powerbar, vitals, indicators, radar, and examination layouts author dragbars too, so they all gain their retail handles from this one port. Our importer knew Type 2 by name but built it as a generic UiDatElement - ClickThrough decoration, so the strip never even claimed the pointer. Now: - UiElement.WindowMoveHandle marks an authored handle; the DAT factory sets it for Type-2 elements and opts them out of ClickThrough. - A left-press inside a handle subtree moves the handle's top-level window (the outer frame directly under the root - the mounted analogue of retail's dragbar parent) even when that window is not whole-surface Draggable. Edge-resize still wins; UiLocked still gates, matching the retail locked/fixed parent-flag check. - HoverWindowMove reports the handle so the window-move cursor shows over the strip - and only there - on non-Draggable windows. Four new tests: handle press moves a non-Draggable window and stops on release, hover shows the move cursor over the strip but not the body, UiLocked suppresses both, and the factory builds Type 2 as a pointer-claiming move handle. App Release suite 3,966 / 3 skips. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| fixtures | ||
| AppraisalUiControllerTests.cs | ||
| CharacterControllerTests.cs | ||
| CharacterLayoutImportProbe.cs | ||
| CharacterSheetProviderTests.cs | ||
| CharacterStatControllerTests.cs | ||
| ChatLayoutConformanceTests.cs | ||
| ChatLayoutFixtureGenerator.cs | ||
| ChatWindowControllerTests.cs | ||
| CombatLayoutConformanceTests.cs | ||
| CombatUiControllerTests.cs | ||
| CreatureAppraisalRowsTests.cs | ||
| DatWidgetFactoryFontResolveTests.cs | ||
| DatWidgetFactoryTests.cs | ||
| EffectsUiControllerTests.cs | ||
| ElementReaderTests.cs | ||
| ExternalContainerControllerTests.cs | ||
| FixtureLoader.cs | ||
| IndicatorBarControllerTests.cs | ||
| IndicatorDetailPanelControllerTests.cs | ||
| InventoryControllerTests.cs | ||
| InventoryFrameImportProbe.cs | ||
| ItemAppraisalTextFormatterTests.cs | ||
| ItemCooldownUiControllerTests.cs | ||
| ItemListCellTemplateTests.cs | ||
| JumpPowerbarControllerTests.cs | ||
| JumpPowerbarLayoutConformanceTests.cs | ||
| LayoutConformanceTests.cs | ||
| LayoutImporterTests.cs | ||
| PaperdollClickMapTests.cs | ||
| PaperdollControllerTests.cs | ||
| PaperdollSlotBackgroundTests.cs | ||
| PaperdollToggleTests.cs | ||
| RadarControllerTests.cs | ||
| RadarLayoutConformanceTests.cs | ||
| RadarLayoutFixtureGenerator.cs | ||
| RadarSnapshotProviderTests.cs | ||
| RetailDialogFactoryTests.cs | ||
| RetailFixtureConformanceTests.cs | ||
| RetailFpsControllerTests.cs | ||
| RetailLayoutFixtureGenerator.cs | ||
| RetailPanelUiControllerTests.cs | ||
| RetailWindowFrameTests.cs | ||
| SelectedObjectControllerTests.cs | ||
| SpellbookRowStyleTests.cs | ||
| SpellbookWindowControllerTests.cs | ||
| SpellcastingUiControllerTests.cs | ||
| SpellExamineComponentTemplateFactoryTests.cs | ||
| ToolbarControllerTests.cs | ||
| ToolbarInputControllerTests.cs | ||
| UiDatElementTests.cs | ||
| UiPropertyBagTests.cs | ||
| UiTextLayoutCacheTests.cs | ||
| UiViewportFactoryTests.cs | ||
| VitalsBindingTests.cs | ||
| VividTargetIndicatorLayoutTests.cs | ||