Campaign P remaining-physics-divergence, placement cutover slice C3c
(docs/plans/2026-08-02-placement-cutover.md). Both production hosts now
register every initial Create through the residence + continuation-
executor + first-entry-conductor machinery (C0-C3b):
- Graphical (route 1): RegisterEntityWithInitialResidence at Create; the
shared RuntimeFirstEntryDriveController pumps both conductors from the
placement-receipt flow; MaterializeProjection and RebucketLiveEntity
are presentation-only while a residence is ACTIVE (ExecutorCompleted is
the presentation-binding receipt); post-residence entities take the
full legacy path including the prepare_to_enter_world clock edges.
PlayerModeController attaches presentation to the Runtime-published
controller; its legacy resolve/step-heights/host-construction path is
deleted; presentation-only rollback (retail has no entry-flow rollback).
- Headless (route 8): OnSpawned registers with residence when a drive
exists; content-less sessions keep the pre-flip direct registration;
SynchronizeLocalPlayer/CreateController/ApplySetupStepHeights deleted;
prepared-collision read failure is a typed AwaitingCollisionSource
retry; far remotes outside the service window complete celless.
- RuntimeLocalPlayerMovementState.Controller setter sealed internal; all
controller mutation flows through the publication lifecycle.
Fix slices landed within this cutover, each dual-gated:
- F1: live movement-stat/server-physics application routed through the
Runtime ownership seam (post-logout ingest crash on the retired
controller eliminated; RuntimeMovementSkillProjection deleted).
- F2: login activation wedge - collision-admission prefix gate factored
out of the seal (reentrant-commit RejectedAuthority), rearm generation
identity corrected, PlayerModeAutoEntry requires the Runtime-published
controller (world reveal can no longer seal unmaterialized).
- F3: landblock-prefix 0-sentinel replaced by explicit absent-id guards;
map-corner landblocks (grid row/col 0) fully legal through admission,
park/rearm/retire, quiescence, and outdoor shadow seeds.
- F5: local-player first-entry ground contact seeded by the shared
SpawnPlacementSettler (moved App->Core) at FinalizeActivation - the
retail first-gravity-frame touch (enter_world 0x00516170 carries no
seed); the legacy unconditional force-seed is overwritten by a real
floor-found contact; airborne spawns stay airborne; outbound contact
bit verified end-to-end. Fixes the standing-cast 'You can't do that
while in the air!' rejections.
- R1 (dual-review round): login constraint leash armed at the committed
placement (HandleReceivedPosition 0x00453FD0 analog); register rows
AD-61 (settle-timing compression now covering the local player) and
AD-42 (repointed off the deleted resolve split) in this commit;
residence-conversion owner API; wire-landblock guards; drive-pending
ledger in IsConverged; route attach/detach latch; executor-drain drift
model documented + source-pinned.
Gates: Runtime 1,003, App 4,039/3 skips, Headless 79, complete solution
10,816/0 failed/4 skips (Release, -m:1); connected lifecycle/reconnect
gate PASS (logs/connected-world-gate-20260802-175401; graceful exits,
world-visible, zero airborne rejections). The nine-stop soak remains red
for the pre-existing 6b28ff99 whole-world collision-clone throughput
regression (attributed with evidence; scheduled as its own slice before
C5). Dual Opus reviews (retail-conformance + adversarial): delta PASS.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
161 lines
5.5 KiB
C#
161 lines
5.5 KiB
C#
using AcDream.App.Streaming;
|
|
using AcDream.App.World;
|
|
using AcDream.Core.Net;
|
|
using AcDream.Core.Net.Messages;
|
|
|
|
namespace AcDream.App.Tests.World;
|
|
|
|
public sealed class DeferredLiveEntityRuntimeComponentLifecycleTests
|
|
{
|
|
[Fact]
|
|
public void TearDownBeforeBind_FailsFast()
|
|
{
|
|
var bridge = new DeferredLiveEntityRuntimeComponentLifecycle();
|
|
|
|
Assert.False(bridge.IsBound);
|
|
Assert.Throws<InvalidOperationException>(() => bridge.TearDown(null!));
|
|
}
|
|
|
|
[Fact]
|
|
public void Bind_IsSingleAssignmentAndForwardsExactRecord()
|
|
{
|
|
var bridge = new DeferredLiveEntityRuntimeComponentLifecycle();
|
|
LiveEntityRecord? observed = null;
|
|
var owner = new DelegateLiveEntityRuntimeComponentLifecycle(record => observed = record);
|
|
var replacement = new DelegateLiveEntityRuntimeComponentLifecycle(_ => { });
|
|
LiveEntityRecord record = CreateRecord();
|
|
|
|
bridge.Bind(owner);
|
|
bridge.TearDown(record);
|
|
|
|
Assert.True(bridge.IsBound);
|
|
Assert.Same(record, observed);
|
|
Assert.Throws<InvalidOperationException>(() => bridge.Bind(replacement));
|
|
}
|
|
|
|
[Fact]
|
|
public void BindRejectsNullAndSelf()
|
|
{
|
|
var bridge = new DeferredLiveEntityRuntimeComponentLifecycle();
|
|
|
|
Assert.Throws<ArgumentNullException>(() => bridge.Bind(null!));
|
|
Assert.Throws<ArgumentException>(() => bridge.Bind(bridge));
|
|
}
|
|
|
|
[Fact]
|
|
public void OwnedBindingReleasesExactlyAndAllowsRebind()
|
|
{
|
|
var bridge = new DeferredLiveEntityRuntimeComponentLifecycle();
|
|
int firstCalls = 0;
|
|
int secondCalls = 0;
|
|
var first = new DelegateLiveEntityRuntimeComponentLifecycle(
|
|
_ => firstCalls++);
|
|
var second = new DelegateLiveEntityRuntimeComponentLifecycle(
|
|
_ => secondCalls++);
|
|
|
|
IDisposable firstBinding = bridge.BindOwned(first);
|
|
Assert.Throws<InvalidOperationException>(() => bridge.BindOwned(second));
|
|
|
|
firstBinding.Dispose();
|
|
using IDisposable secondBinding = bridge.BindOwned(second);
|
|
firstBinding.Dispose();
|
|
bridge.TearDown(CreateRecord());
|
|
|
|
Assert.Equal(0, firstCalls);
|
|
Assert.Equal(1, secondCalls);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ConcurrentBind_HasOneWinnerAndPublishesThatOwner()
|
|
{
|
|
var bridge = new DeferredLiveEntityRuntimeComponentLifecycle();
|
|
int firstCalls = 0;
|
|
int secondCalls = 0;
|
|
var owners = new ILiveEntityRuntimeComponentLifecycle[]
|
|
{
|
|
new DelegateLiveEntityRuntimeComponentLifecycle(_ => Interlocked.Increment(ref firstCalls)),
|
|
new DelegateLiveEntityRuntimeComponentLifecycle(_ => Interlocked.Increment(ref secondCalls)),
|
|
};
|
|
using var ready = new CountdownEvent(2);
|
|
using var start = new ManualResetEventSlim();
|
|
|
|
Task<bool>[] attempts = owners.Select(owner => Task.Run(() =>
|
|
{
|
|
ready.Signal();
|
|
start.Wait();
|
|
try
|
|
{
|
|
bridge.Bind(owner);
|
|
return true;
|
|
}
|
|
catch (InvalidOperationException)
|
|
{
|
|
return false;
|
|
}
|
|
})).ToArray();
|
|
|
|
ready.Wait();
|
|
start.Set();
|
|
bool[] results = await Task.WhenAll(attempts);
|
|
LiveEntityRecord record = CreateRecord();
|
|
bridge.TearDown(record);
|
|
|
|
Assert.Single(results, value => value);
|
|
Assert.True(bridge.IsBound);
|
|
Assert.Equal(1, firstCalls + secondCalls);
|
|
}
|
|
|
|
[Fact]
|
|
public void RuntimeTeardownBeforeBind_RetainsTombstoneAndRetryConverges()
|
|
{
|
|
const uint guid = 0x70000002u;
|
|
var bridge = new DeferredLiveEntityRuntimeComponentLifecycle();
|
|
var runtime = LiveEntityRuntimeFixture.Create(
|
|
new GpuWorldState(),
|
|
new DelegateLiveEntityResourceLifecycle(_ => { }, _ => { }),
|
|
bridge);
|
|
WorldSession.EntitySpawn spawn = CreateSpawn(guid);
|
|
LiveEntityRecord record = runtime.RegisterAndMaterializeProjection(spawn);
|
|
var delete = new DeleteObject.Parsed(guid, InstanceSequence: 1);
|
|
|
|
Assert.Throws<AggregateException>(() =>
|
|
runtime.UnregisterLiveEntity(delete, isLocalPlayer: false));
|
|
Assert.Equal(1, runtime.PendingTeardownCount);
|
|
|
|
int calls = 0;
|
|
bridge.Bind(new DelegateLiveEntityRuntimeComponentLifecycle(exact =>
|
|
{
|
|
Assert.Same(record, exact);
|
|
calls++;
|
|
}));
|
|
|
|
Assert.True(runtime.UnregisterLiveEntity(delete, isLocalPlayer: false));
|
|
Assert.Equal(1, calls);
|
|
Assert.Equal(0, runtime.PendingTeardownCount);
|
|
}
|
|
|
|
private static LiveEntityRecord CreateRecord()
|
|
{
|
|
var runtime = LiveEntityRuntimeFixture.Create(
|
|
new GpuWorldState(),
|
|
new DelegateLiveEntityResourceLifecycle(_ => { }, _ => { }));
|
|
return runtime.RegisterAndMaterializeProjection(
|
|
CreateSpawn(0x70000001u));
|
|
}
|
|
|
|
private static WorldSession.EntitySpawn CreateSpawn(uint guid) =>
|
|
new WorldSession.EntitySpawn(
|
|
Guid: guid,
|
|
Position: null,
|
|
SetupTableId: null,
|
|
AnimPartChanges: Array.Empty<CreateObject.AnimPartChange>(),
|
|
TextureChanges: Array.Empty<CreateObject.TextureChange>(),
|
|
SubPalettes: Array.Empty<CreateObject.SubPaletteSwap>(),
|
|
BasePaletteId: null,
|
|
ObjScale: null,
|
|
Name: "test",
|
|
ItemType: null,
|
|
MotionState: null,
|
|
MotionTableId: null,
|
|
InstanceSequence: 1).WithConsistentPhysics();
|
|
}
|