acdream/tests/AcDream.Runtime.Tests/Session/RuntimeCharacterSelectionStateTests.cs
Erik ef96c55489 fix(ui,net): Campaign LA gate round 2 — char-select exit confirmation, authored row justify, world name
Finding 1 (Exit button dead): retail's gmCharacterManagementUI Exit
button (element 0x100003A4, offset 7 from the listbox base in
ListenToElementMessage@0x004ed5a0) opens MakeConfirmExitDialog
(0x004ed250), whose exact ID_CharacterManagement_ConfirmExit text
(table 0x23000002) and m_confirmExitDialogContext re-entry guard are
now ported. On confirm (matching RecvNotice_CloseDialog@0x004ed760
case 1's ConfirmationResult check) the client exits through the
EXISTING graceful window-close seam (CharacterSelectionRuntimeBindings
.RequestExit -> d.Window.Close, the same delegate
GameplayInputCommandController's Escape fallback already uses) so
disconnected/exited status events still fire via GameWindow.OnClosing
-> CompleteShutdown. Retail's real post-confirm destination is
QueueUIMode(0x10000009) -> gmEpilogueUI, an epilogue screen this round
does not port — recorded as AD-99. Credits (element 0x100003A3,
QueueUIMode(0x10000005) -> gmCreditsUI) stays visibly ghosted like
Create, same treatment, out of scope this round.

Finding 2 (row names center-aligned, retail is left): the character
row template (LayoutDesc 0x21000004, element 0x100003A5, live-DAT
confirmed HJustify=Left with three stateful Type-3 highlight-art
children and no Type-12 caption child) authors its OWN justify
directly, with no separate text child to lift a label from.
DatWidgetFactory.BuildButton's Left-justify branch required
!ReferenceEquals(labelInfo, info) — true only when a label was LIFTED
from a distinct child — so a button's own direct HJustify=Left was
silently dropped to UiButton's Center default. Widened the branch to
also honor the direct case, preserving the existing lifted-child
LabelOffsetX behavior and leaving genuinely-centered buttons
(CREATE/ENTER/DELETE/RESTORE) untouched.

Finding 3 (World box empty): parsed ACE's GameMessageServerName
(opcode 0xF7E1, ACE.Server/Network/GameMessages/Messages/
GameMessageServerName.cs; retail CM_Login::DispatchUI_WorldInfo
@0x006ad860 -> ClientUISystem::Handle_Login__WorldInfo@0x005641a0 ->
ECM_Login::SendNotice_WorldName@0x00692b10, notice 0x186a2, consumed
by gmCharacterManagementUI::UpdateWorldName@0x004ec120 /
RecvNotice_WorldName@0x004ec360 onto element 0x1000039B) as
src/AcDream.Core.Net/Messages/ServerName.cs, cross-checked against
holtburger's ServerNameData. WorldSession.ServerNameReceived fires
alongside CharacterListReceived (ACE sends both in one
SendConnectResponse batch); RuntimeCharacterSelectionState.
ApplyWorldName is the new J-owner field (ungated by lifecycle, since
either message can arrive first); CharacterManagementUiController
binds it onto the WorldTextElementId UiText. Per the LA1 status
vocabulary, the characterList STATUS event's worldName field is
intentionally NOT added this round (kept bounded to the client-side
fix) — a follow-up if the launcher UI wants it.

Also corrects AD-44, discovered stale while filing AD-99: its opening
claim ("acdream has no retained character-management screen") was
false as of this session — LA7/LA8 shipped the screen in earlier
commits without updating this row.

Tests: exit-confirm open/cancel/confirm/re-entry-guard flow;
DatWidgetFactory own-HJustify-Left/Center regression tests plus the
live-DAT pinned row-justify assertion; ServerName parse round-trip
(byte-exact vs ACE's AceWireWriter fixture, truncation/wrong-opcode
cases); WorldSession dispatch test (roster+world in one wire batch);
RuntimeCharacterSelectionState.ApplyWorldName tests (order-independent
of ApplyRoster, unchanged-value no-op, Reset clears); controller test
binding the World text element to the live snapshot. Extended the
shared RetailDialogFactoryTests.BuildDialogLayout test fixture with a
Confirmation-type branch (Accept/Reject buttons) since this is its
first RetailDialogType.Confirmation consumer.

Suites: full solution Release build green; AcDream.App.Tests 5100/6
skips, AcDream.Core.Net.Tests 965/0, AcDream.Runtime.Tests 1665/0, all
Release, 0 failures; live-DAT probes (ACDREAM_PROBE_LIVE_MOUNT=1)
green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-15 11:50:45 +02:00

346 lines
13 KiB
C#

using AcDream.Core.Net.Messages;
using AcDream.Runtime;
using AcDream.Runtime.Session;
namespace AcDream.Runtime.Tests.Session;
public sealed class RuntimeCharacterSelectionStateTests
{
private sealed class Collector : IRuntimeCharacterSelectionVisitor
{
public List<RuntimeCharacterSelectionEntry> Entries { get; } = [];
public void Visit(in RuntimeCharacterSelectionEntry character) =>
Entries.Add(character);
}
private sealed class Observer(
Action<RuntimeCharacterSelectionDelta> onDelta)
: IRuntimeCharacterSelectionObserver
{
public void OnCharacterSelectionChanged(
in RuntimeCharacterSelectionDelta delta) =>
onDelta(delta);
}
private sealed class ManualTimeProvider : TimeProvider
{
private long _timestamp;
public override long TimestampFrequency => TimeSpan.TicksPerSecond;
public override long GetTimestamp() => _timestamp;
public void Advance(TimeSpan elapsed) =>
_timestamp += elapsed.Ticks;
}
[Fact]
public void ApplyRoster_PortsRetailOrderFallbackAndDisabledButtonMatrix()
{
using var state = new RuntimeCharacterSelectionState();
state.Begin(new RuntimeGenerationToken(7));
state.ApplyRoster(Roster(
new(0x50000001u, "Zulu", 1u),
new(0x50000002u, "Bravo", 0u),
new(0x50000003u, "Alpha", 0u),
new(0x50000004u, "Able", 9u)));
RuntimeCharacterSelectionSnapshot snapshot = state.Snapshot;
Assert.Equal(RuntimeCharacterSelectionLifecycle.AwaitingSelection, snapshot.Lifecycle);
// Retail falls back in CharacterSet wire order, independently of the
// alphabetized display order.
Assert.Equal(0x50000002u, snapshot.HighlightedCharacterId);
Assert.True(snapshot.Buttons.CanEnter);
Assert.True(snapshot.Buttons.CanDelete);
Assert.False(snapshot.Buttons.CanRestore);
Assert.True(snapshot.Buttons.DeleteVisible);
Assert.False(snapshot.Buttons.RestoreVisible);
var collector = new Collector();
state.View.Visit(collector);
Assert.Equal(
[
(0x50000003u, 2, false),
(0x50000002u, 1, false),
(0x50000004u, 3, true),
(0x50000001u, 0, true),
],
collector.Entries.Select(entry =>
(entry.CharacterId, entry.ActiveIndex, entry.IsPendingDelete)));
Assert.True(state.TryHighlight(0x50000004u));
snapshot = state.Snapshot;
Assert.False(snapshot.Buttons.CanEnter);
Assert.False(snapshot.Buttons.CanDelete);
Assert.True(snapshot.Buttons.CanRestore);
Assert.False(snapshot.Buttons.DeleteVisible);
Assert.True(snapshot.Buttons.RestoreVisible);
}
[Fact]
public void ApplyRoster_PreservesHighlightedGuidAcrossDeleteRefresh()
{
using var state = new RuntimeCharacterSelectionState();
state.Begin(new RuntimeGenerationToken(3));
state.ApplyRoster(Roster(
new(0x50000001u, "One", 0u),
new(0x50000002u, "Two", 0u)));
Assert.True(state.TryHighlight(0x50000002u));
Assert.True(state.TryRequestDelete(out uint requested));
Assert.Equal(0x50000002u, requested);
Assert.True(state.TryTakeDeleteConfirmation(
out RuntimeCharacterSelectionEntry deleted,
out string account));
Assert.Equal(1, deleted.ActiveIndex);
Assert.Equal("Canonical", account);
state.ApplyDeleteAcknowledged();
Assert.Equal(
RuntimeCharacterSelectionOperation.DeleteAcknowledged,
state.Snapshot.Operation);
state.ApplyRoster(Roster(
new(0x50000001u, "One", 0u),
new(0x50000002u, "Two", 1u)));
RuntimeCharacterSelectionSnapshot snapshot = state.Snapshot;
Assert.Equal(0x50000002u, snapshot.HighlightedCharacterId);
Assert.Equal(RuntimeCharacterSelectionOperation.None, snapshot.Operation);
Assert.True(snapshot.Buttons.CanRestore);
Assert.False(snapshot.Buttons.CanEnter);
}
[Fact]
public void DeleteConfirmation_CancelIsIdempotentlyGenerationLocal()
{
using var state = new RuntimeCharacterSelectionState();
state.Begin(new RuntimeGenerationToken(4));
state.ApplyRoster(Roster(
new LiveSessionRosterEntry(0x50000001u, "One", 0u)));
Assert.True(state.TryRequestDelete(out _));
Assert.Equal(0x50000001u, state.Snapshot.PendingDeleteCharacterId);
Assert.False(state.TryHighlight(0x50000001u));
Assert.False(state.BeginEnter(out _));
Assert.True(state.Cancel());
Assert.Equal(0u, state.Snapshot.PendingDeleteCharacterId);
Assert.False(state.Cancel());
state.Reset(new RuntimeGenerationToken(5));
Assert.Equal(RuntimeCharacterSelectionLifecycle.Inactive, state.Snapshot.Lifecycle);
Assert.Equal(0, state.Snapshot.RosterCount);
Assert.Equal(new RuntimeGenerationToken(5), state.Snapshot.Generation);
}
[Fact]
public void Restore_IsFireAndObserveAndSuccessUpdatesTheCanonicalEntry()
{
using var state = new RuntimeCharacterSelectionState();
state.Begin(new RuntimeGenerationToken(11));
state.ApplyRoster(Roster(
new LiveSessionRosterEntry(0x50000001u, "Grey", 1u)));
Assert.True(state.TryBeginRestore(out RuntimeCharacterSelectionEntry request));
Assert.Equal(0x50000001u, request.CharacterId);
Assert.Equal(
RuntimeCharacterSelectionOperation.RestoreRequested,
state.Snapshot.Operation);
// No response is required to keep using the state. ACE's unknown-guid
// branch intentionally sends no reply.
Assert.True(state.TryHighlight(0x50000001u));
state.ApplyRestore(new CharacterRestore.Parsed(
VerificationFlag: 1u,
Guid: 0x50000001u,
Name: "Restored",
SecondsGreyedOut: 0u));
Assert.True(state.View.TryGet(0x50000001u, out var restored));
Assert.Equal("Restored", restored.Name);
Assert.False(restored.IsPendingDelete);
Assert.True(state.Snapshot.Buttons.CanEnter);
Assert.Equal(
RuntimeCharacterSelectionOperation.RestoreSucceeded,
state.Snapshot.Operation);
}
[Fact]
public void DelayedFlagOnlyRestoreResponse_CannotCompleteNewerRequest()
{
var time = new ManualTimeProvider();
using var state = new RuntimeCharacterSelectionState(time);
state.Begin(new RuntimeGenerationToken(12));
state.ApplyRoster(Roster(
new(0x50000001u, "First", 1u),
new(0x50000002u, "Second", 1u)));
Assert.True(state.TryBeginRestore(out _));
Assert.True(state.TryHighlight(0x50000002u));
Assert.False(state.TryBeginRestore(out _));
time.Advance(RuntimeCharacterSelectionState.RestoreCorrelationTimeout);
Assert.True(state.SweepRestoreCorrelation());
Assert.True(state.TryBeginRestore(out _));
long revision = state.Snapshot.Revision;
state.ApplyRestore(new CharacterRestore.Parsed(
VerificationFlag: 2u,
Guid: null,
Name: null,
SecondsGreyedOut: null));
Assert.Equal(
RuntimeCharacterSelectionOperation.RestoreRequested,
state.Snapshot.Operation);
Assert.Equal(0x50000002u, state.Snapshot.LastRestoreRequestedCharacterId);
Assert.Equal(revision, state.Snapshot.Revision);
Assert.True(state.View.TryGet(0x50000001u, out var first));
Assert.True(first.IsPendingDelete);
Assert.True(state.View.TryGet(0x50000002u, out var second));
Assert.True(second.IsPendingDelete);
Assert.False(state.Snapshot.Buttons.CanRestore);
}
[Fact]
public void NoReplyRestoreTimeout_ReleasesOnlyRestoreGate()
{
var time = new ManualTimeProvider();
using var state = new RuntimeCharacterSelectionState(time);
state.Begin(new RuntimeGenerationToken(13));
state.ApplyRoster(Roster(
new(0x50000001u, "Pending", 1u),
new(0x50000002u, "Ready", 0u)));
Assert.True(state.TryHighlight(0x50000001u));
Assert.True(state.TryBeginRestore(out _));
Assert.False(state.Snapshot.Buttons.CanRestore);
Assert.True(state.TryHighlight(0x50000002u));
Assert.True(state.BeginEnter(out var ready));
Assert.Equal(0x50000002u, ready.CharacterId);
state.ReturnToSelection();
Assert.True(state.TryHighlight(0x50000001u));
Assert.True(state.TryBeginRestore(out _));
time.Advance(RuntimeCharacterSelectionState.RestoreCorrelationTimeout);
Assert.True(state.SweepRestoreCorrelation());
Assert.Equal(
RuntimeCharacterSelectionOperation.None,
state.Snapshot.Operation);
Assert.True(state.Snapshot.Buttons.CanRestore);
}
[Fact]
public void CharacterErrors_MapKnownAndUnknownButNeverPublishNumErrorsSentinel()
{
using var state = new RuntimeCharacterSelectionState();
state.Begin(new RuntimeGenerationToken(2));
state.ApplyRoster(Roster(
new LiveSessionRosterEntry(0x50000001u, "One", 0u)));
var deltas = new List<RuntimeCharacterSelectionDelta>();
using IDisposable subscription = state.View.Subscribe(
new Observer(deltas.Add));
state.ApplyError(new CharacterError.Parsed(
(uint)CharacterError.Code.Delete));
RuntimeCharacterSelectionError known =
Assert.IsType<RuntimeCharacterSelectionError>(state.Snapshot.Error);
Assert.Equal(CharacterError.Code.Delete, known.Code);
Assert.Contains("delete", known.Message, StringComparison.OrdinalIgnoreCase);
Assert.True(state.Cancel());
state.ApplyError(new CharacterError.Parsed(0xDEADBEEFu));
RuntimeCharacterSelectionError unknown =
Assert.IsType<RuntimeCharacterSelectionError>(state.Snapshot.Error);
Assert.Contains("0xDEADBEEF", unknown.Message, StringComparison.Ordinal);
long revision = state.Snapshot.Revision;
int count = deltas.Count;
state.ApplyError(new CharacterError.Parsed(
(uint)CharacterError.Code.NumErrors));
Assert.Equal(revision, state.Snapshot.Revision);
Assert.Equal(count, deltas.Count);
Assert.Equal(0xDEADBEEFu, state.Snapshot.Error!.Value.RawCode);
}
[Fact]
public void Deltas_AreMonotonicAndReentrantMutationsStayOrdered()
{
using var state = new RuntimeCharacterSelectionState();
state.Begin(new RuntimeGenerationToken(9));
var deltas = new List<RuntimeCharacterSelectionDelta>();
var observer = new Observer(delta =>
{
deltas.Add(delta);
if (delta.Kind == RuntimeCharacterSelectionDeltaKind.RosterChanged)
Assert.True(state.TryHighlight(0x50000002u));
});
using IDisposable subscription = state.View.Subscribe(observer);
state.ApplyRoster(Roster(
new(0x50000001u, "Ready", 0u),
new(0x50000002u, "Grey", 1u)));
Assert.Equal(
[
RuntimeCharacterSelectionDeltaKind.RosterChanged,
RuntimeCharacterSelectionDeltaKind.HighlightChanged,
],
deltas.Select(delta => delta.Kind));
Assert.True(deltas[0].Sequence < deltas[1].Sequence);
Assert.All(
deltas,
delta => Assert.Equal(new RuntimeGenerationToken(9), delta.Generation));
}
[Fact]
public void ApplyWorldName_PopulatesSnapshot_IndependentOfRoster()
{
// Campaign LA gate round 2 finding 3: ACE sends ServerName in the
// same batch as CharacterList; ApplyWorldName must not require
// ApplyRoster to have run first (arrival order is not guaranteed).
using var state = new RuntimeCharacterSelectionState();
state.Begin(new RuntimeGenerationToken(5));
Assert.Equal(string.Empty, state.Snapshot.WorldName);
state.ApplyWorldName("sawato");
Assert.Equal("sawato", state.Snapshot.WorldName);
state.ApplyRoster(Roster(
new LiveSessionRosterEntry(0x50000001u, "One", 0u)));
Assert.Equal("sawato", state.Snapshot.WorldName);
Assert.Equal(0x50000001u, state.Snapshot.HighlightedCharacterId);
}
[Fact]
public void ApplyWorldName_UnchangedValue_DoesNotBumpRevisionOrPublish()
{
using var state = new RuntimeCharacterSelectionState();
state.Begin(new RuntimeGenerationToken(6));
state.ApplyWorldName("sawato");
var deltas = new List<RuntimeCharacterSelectionDelta>();
using IDisposable subscription = state.View.Subscribe(
new Observer(deltas.Add));
long revision = state.Snapshot.Revision;
state.ApplyWorldName("sawato");
Assert.Equal(revision, state.Snapshot.Revision);
Assert.Empty(deltas);
}
[Fact]
public void Reset_ClearsWorldName()
{
using var state = new RuntimeCharacterSelectionState();
state.Begin(new RuntimeGenerationToken(8));
state.ApplyWorldName("sawato");
state.Reset(new RuntimeGenerationToken(9));
Assert.Equal(string.Empty, state.Snapshot.WorldName);
}
private static LiveSessionRosterReport Roster(
params LiveSessionRosterEntry[] entries) =>
new("Canonical", 11, entries);
}