acdream/tests/AcDream.Core.Tests/Items
Erik c1a84cbe0c fix(D.2b): wield is ContainerId-based — drop the WielderId write (code review)
Code-quality review (needs-changes) on Task 3: WieldItemOptimistic wrote
item.WielderId directly, but RollbackMove (via MoveItem) never cleared it
→ a wield-rollback left a pack item with a stale WielderId=player.

Root-cause fix (vs the reviewer's snapshot-WielderId suggestion): acdream's
existing WieldObject 0x0023 confirm models a wielded item as ContainerId=
wielder + equip=mask and does NOT touch WielderId. So the optimistic path
must match — drop the WielderId write entirely. Optimistic state now equals
the confirmed state, rollback fully restores through MoveItem alone, and the
stale-state class is structurally eliminated. The paperdoll's
(WielderId==p || ContainerId==p) filter still matches optimistic wields via
ContainerId (login-equipped items match via WielderId from their CreateObject).

Also: + the wield+move outstanding-count combo test (spec §8), MoveItem doc
note that it doesn't manage WielderId, and the test pins WielderId==0 post-
optimistic-wield to document the model. Core 74/74 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 22:15:18 +02:00
..
BurdenMathTests.cs fix(ui): D.2b-B — address phase-boundary review (burden % saturation + equipped filter) 2026-06-21 09:28:29 +02:00
ClientObjectTableBurdenTests.cs feat(core): D.2b-B — ClientObjectTable.SumCarriedBurden (carried-Burden fallback) 2026-06-21 08:55:35 +02:00
ClientObjectTableTests.cs fix(D.2b): wield is ContainerId-based — drop the WielderId write (code review) 2026-06-22 22:15:18 +02:00
ClientObjectTableUpdateTests.cs feat(core): D.2b-B B-Wire — ClientObjectTable.UpdateStackSize 2026-06-21 18:48:54 +02:00
EquipMaskTests.cs fix(D.2b): correct EquipMask to canonical retail INVENTORY_LOC + numeric-pin test 2026-06-22 21:56:06 +02:00
ShortcutStoreTests.cs refactor(core): D.5.3/B.2 — move ShortcutStore to Core.Items (decouple Load from the wire type) 2026-06-20 15:50:33 +02:00