9aaf97e785
This reverts ceec3bc4. Two independent reasons, either sufficient.
The rendering regression. The slice deleted TextRenderGlStateScope, which
saved GL_MULTISAMPLE and GL_SAMPLE_ALPHA_TO_COVERAGE on entry, disabled them
for the text pass, and restored them on exit (TextRenderGlStateScope.cs:111-112
and 153-154 at the parent commit). Its replacement bakes that state into the
text pipeline but nothing restores it, and GlGpuPassEncoder.Dispose does not
either. Every world renderer is still raw GL at this point in the campaign, so
from the first UI frame onward the world drew with multisampling disabled.
The offline pixel gate caught it: 1,791 of 563,200 compared pixels differed,
0.318% against a 0.001 threshold. The commit message attributed this to
wall-clock-driven ambient animation shifting phase, and committed through the
failure. That explanation does not survive its own control: capturing twice at
the reverted-to commit differs by 19 pixels and twice at the slice's own commit
by 8, while base-versus-head differs by 1,791 - a 224x gap that no shared-noise
source explains. An amplified difference image settles it visually: the changed
pixels are the silhouette edges of every tree, building and rock, with terrain
interiors, water and the entire UI untouched. That is the signature of losing
edge antialiasing, not of animated sprites.
This is the exact failure mode two existing memory notes already warn about -
a mid-frame renderer must set every GL state it uses rather than inherit it,
and issue #52's lesson that a rendering migration must audit per-pass GL state
before declaring itself done.
The scope. The brief was three small leaf renderers plus additive frame-
lifecycle wiring, roughly ten files. The commit changed 334 files with 3,665
insertions and 3,845 deletions, including 323 public-to-internal visibility
conversions across the App assembly, 55 test files, two retired conformance
tests, and a self-described temporary escape hatch for bridging raw-GL viewport
textures. Even without the regression, that is not separable into the part
worth keeping and the part worth dropping.
Reverting rather than patching because the good work here - the RHI frame
lifecycle wiring and a genuine render-state-cache staleness fix - is small
enough to redo cleanly against a tightened spec, while untangling it from 300+
files of unrelated churn is not.
Post-revert: Release build clean, App suite back to 3,843 passed / 3 skipped,
offline pixel gate passing at 19 differing pixels.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
80 lines
2.9 KiB
C#
80 lines
2.9 KiB
C#
// src/AcDream.App/Rendering/FlyCamera.cs
|
|
using System.Numerics;
|
|
|
|
namespace AcDream.App.Rendering;
|
|
|
|
public sealed class FlyCamera : ICamera
|
|
{
|
|
public Vector3 Position { get; set; } = new(96, 96, 150);
|
|
public float Yaw { get; set; } = MathF.PI / 2f; // facing +Y
|
|
public float Pitch { get; set; } = -0.3f; // looking slightly down
|
|
public float FovY { get; set; } = MathF.PI / 3f;
|
|
public float Aspect { get; set; } = 16f / 9f;
|
|
|
|
/// <summary>
|
|
/// Default move speed in world units per second. AC's character walks
|
|
/// at ~4 u/s and runs at ~7 u/s; 12 here is comfortable for navigating
|
|
/// scenery without overshooting and roughly tracks a fast jog. Hold
|
|
/// shift while moving to enter "boost" mode at <see cref="BoostSpeed"/>.
|
|
/// </summary>
|
|
public float MoveSpeed { get; set; } = 12f;
|
|
public float BoostSpeed { get; set; } = 50f;
|
|
public float MouseSensitivity { get; set; } = 0.003f;
|
|
|
|
private const float PitchLimit = 1.5533f; // ~89 degrees
|
|
|
|
public Matrix4x4 View
|
|
{
|
|
get
|
|
{
|
|
var forward = Forward();
|
|
return Matrix4x4.CreateLookAt(Position, Position + forward, Vector3.UnitZ);
|
|
}
|
|
}
|
|
|
|
// Near plane 0.1 m = retail Render::znear (see RetailChaseCamera.Projection).
|
|
public Matrix4x4 Projection
|
|
=> Matrix4x4.CreatePerspectiveFieldOfView(FovY, Aspect, 0.1f, 5000f);
|
|
|
|
/// <summary>
|
|
/// Integrate position for one frame based on WASD + vertical keys.
|
|
/// W/S move forward/back in the horizontal plane (ignoring pitch).
|
|
/// A/D strafe left/right. Up/down translate along world Z.
|
|
/// </summary>
|
|
public void Update(double dt, bool w, bool a, bool s, bool d, bool up, bool down, bool boost = false)
|
|
{
|
|
float speed = boost ? BoostSpeed : MoveSpeed;
|
|
float step = (float)(speed * dt);
|
|
|
|
// Forward in the horizontal plane (ignore pitch so W doesn't dive into ground).
|
|
var flatForward = new Vector3(MathF.Cos(Yaw), MathF.Sin(Yaw), 0f);
|
|
var right = new Vector3(MathF.Sin(Yaw), -MathF.Cos(Yaw), 0f);
|
|
|
|
if (w) Position += flatForward * step;
|
|
if (s) Position -= flatForward * step;
|
|
if (a) Position -= right * step;
|
|
if (d) Position += right * step;
|
|
if (up) Position += Vector3.UnitZ * step;
|
|
if (down) Position -= Vector3.UnitZ * step;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Apply accumulated mouse deltas (pixels since last frame). Positive deltaX
|
|
/// rotates the view to the right (decreases yaw), positive deltaY rotates
|
|
/// down (decreases pitch).
|
|
/// </summary>
|
|
public void Look(float deltaX, float deltaY)
|
|
{
|
|
Yaw -= deltaX * MouseSensitivity;
|
|
Pitch = Math.Clamp(Pitch - deltaY * MouseSensitivity, -PitchLimit, PitchLimit);
|
|
}
|
|
|
|
private Vector3 Forward()
|
|
{
|
|
float cp = MathF.Cos(Pitch);
|
|
return new Vector3(
|
|
cp * MathF.Cos(Yaw),
|
|
cp * MathF.Sin(Yaw),
|
|
MathF.Sin(Pitch));
|
|
}
|
|
}
|