2bff44a9fa
The launcher spawned the headless host as
acdream-headless --config <path>
but HeadlessCommandLine.Parse reads arguments[0] as the COMMAND and accepts
only "validate" or "run". So every launcher-started headless session and every
"Refresh characters" died on its first instruction with
Invalid command. Run --help for usage. (exit 64)
The user's own cache shows it six times over two days. It was invisible because
the failure is an exit code in a status file, not something the UI says out
loud — which is how it survived a whole campaign whose gates exercised the
headless host through its CLI directly, never through the launcher's spec.
The graphical host takes a bare "--session-config" and has no command word;
this sibling call was written to match it. Both headless call sites now pass
"run" first. A probe is an ordinary "run" whose session config carries
mode: "probe" — the difference is in the document, not the command line, so
one fix repairs refresh and headless play together.
LauncherHeadlessCommandLineContractTests is the connection that was missing:
it takes the argument vector the launcher will really use and hands it to the
parser the host will really use, for probe and for headless play, and pins that
the graphical arguments are deliberately NOT a headless command line. The two
sides cannot drift again without failing here. Headless.Tests already
referenced both assemblies, so this needed no new coupling.
Also LU7, at the user's direction: a selected character now offers only Play
and Headless. Choosing a character means choosing to play AS that character, so
"Character select" — which deliberately picks no character — belongs to the
account page alone, where it already lives. The per-character GuiSelect command
and its capability are removed rather than left as dead surface.
Full solution 14,374 passed, 0 failed under the release-gate filter.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
94 lines
3.7 KiB
C#
94 lines
3.7 KiB
C#
using AcDream.Headless.Configuration;
|
|
using AcDream.Launcher.Core.Launching;
|
|
using AcDream.Launcher.Core.Orchestration;
|
|
using AcDream.Launcher.Core.Profiles;
|
|
|
|
namespace AcDream.Headless.Tests;
|
|
|
|
/// <summary>
|
|
/// The launcher spawns the headless host; the headless host decides what a
|
|
/// valid command line is. Nothing connected those two facts, and they drifted:
|
|
/// the launcher passed <c>--config <path></c> while
|
|
/// <see cref="HeadlessCommandLine.Parse"/> reads <c>arguments[0]</c> as the
|
|
/// command and accepts only <c>validate</c> or <c>run</c>. Every
|
|
/// launcher-started headless session and every character refresh therefore died
|
|
/// instantly with "Invalid command. Run --help for usage." — visible only as an
|
|
/// exit code in a status file, which is why it survived a whole campaign.
|
|
///
|
|
/// <para>These tests are the missing connection: they take the argument vector
|
|
/// the launcher will really use and hand it to the parser the host will really
|
|
/// use. The two cannot drift again without failing here.</para>
|
|
/// </summary>
|
|
public sealed class LauncherHeadlessCommandLineContractTests : IDisposable
|
|
{
|
|
private readonly string _root = Path.Combine(
|
|
Path.GetTempPath(),
|
|
"acdream-headless-cli-contract",
|
|
Guid.NewGuid().ToString("N"));
|
|
|
|
public LauncherHeadlessCommandLineContractTests()
|
|
{
|
|
// The spec builders refuse to name an executable that is not there, so
|
|
// the contract can only be exercised against files that exist.
|
|
Directory.CreateDirectory(AppDirectory);
|
|
string suffix = OperatingSystem.IsWindows() ? ".exe" : string.Empty;
|
|
File.WriteAllText(Path.Combine(AppDirectory, "AcDream.App" + suffix), "stub");
|
|
File.WriteAllText(Path.Combine(AppDirectory, "acdream-headless" + suffix), "stub");
|
|
}
|
|
|
|
public void Dispose()
|
|
{
|
|
if (Directory.Exists(_root))
|
|
{
|
|
Directory.Delete(_root, recursive: true);
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public void ProbeArgumentsParseAsAHeadlessRunCommand()
|
|
{
|
|
LauncherProcessSpec spec = ExecutableSet().CreateProbeSpec(ConfigPath);
|
|
|
|
HeadlessCommandLine parsed = HeadlessCommandLine.Parse(spec.Arguments);
|
|
|
|
Assert.Equal("run", parsed.Command);
|
|
Assert.Equal(ConfigPath, parsed.ConfigurationPath);
|
|
}
|
|
|
|
[Fact]
|
|
public void HeadlessPlayArgumentsParseAsAHeadlessRunCommand()
|
|
{
|
|
LauncherProcessSpec spec = ExecutableSet()
|
|
.CreatePlaySpec(LaunchMode.Headless, ConfigPath);
|
|
|
|
HeadlessCommandLine parsed = HeadlessCommandLine.Parse(spec.Arguments);
|
|
|
|
Assert.Equal("run", parsed.Command);
|
|
Assert.Equal(ConfigPath, parsed.ConfigurationPath);
|
|
}
|
|
|
|
/// <summary>
|
|
/// The graphical host is a DIFFERENT program with a different grammar — it
|
|
/// takes a bare <c>--session-config</c> and has no command word. Copying
|
|
/// that shape onto the headless call is exactly the mistake this file
|
|
/// exists to prevent, so pin the difference rather than leaving it implied.
|
|
/// </summary>
|
|
[Theory]
|
|
[InlineData(LaunchMode.Gui)]
|
|
[InlineData(LaunchMode.GuiSelect)]
|
|
public void GraphicalArgumentsAreNotAHeadlessCommandLine(LaunchMode mode)
|
|
{
|
|
LauncherProcessSpec spec = ExecutableSet().CreatePlaySpec(mode, ConfigPath);
|
|
|
|
Assert.Equal(["--session-config", ConfigPath], spec.Arguments);
|
|
Assert.Throws<HeadlessCommandLineException>(
|
|
() => HeadlessCommandLine.Parse(spec.Arguments));
|
|
}
|
|
|
|
private string AppDirectory => Path.Combine(_root, "app");
|
|
|
|
private string ConfigPath => Path.Combine(_root, "session.json");
|
|
|
|
private LauncherExecutableSet ExecutableSet() =>
|
|
LauncherExecutableSet.FromDirectory(AppDirectory);
|
|
}
|