ece2104189
Owner direction 2026-09-06: the owner visually accepted all three connected
gates from the plugin-shelf/DAT-icon work — the movable plugin shelf
(Slice A), the DAT icon markup (Slice B), and the retained-UI outline-order
fix (761a7519f). With that gate passed, the Smoke plugin's job as the gate
artifact is done, so it is deleted outright rather than merely hidden:
src/AcDream.Plugins.Smoke/ (SmokePlugin.cs, SmokeIconPanel.cs, csproj, lock
files).
Reference sites cleaned:
- AcDream.slnx: removed the project entry.
- src/AcDream.App/AcDream.App.csproj: removed the Smoke ProjectReference and
the CopySmokePluginToBuildOutput/CopySmokePluginToPublishOutput targets;
the MossTank equivalents are untouched.
- .github/workflows/headless-portability.yml: the Linux package-contract
step no longer asserts a Smoke plugin.dll/plugin.json pair — repointed at
MossTank's, since the step's job was to prove the plugin-copy packaging
mechanism works end to end, not specifically to prove Smoke.
- tests/AcDream.Core.Tests/Plugins/PluginManifestTests.cs: the inline JSON
fixture used Smoke's manifest values as arbitrary test data; swapped for
MossTank's so the parser test still proves the same thing.
- tests/AcDream.App.Tests/Rendering/LinuxPlatformBoundaryTests.cs: the
shipped-plugin-copy shape test counted 4 GetTargetPath targets (Smoke +
MossTank, build + publish); now 2 (MossTank only).
- tests/AcDream.App.Tests/Plugins/AppAutomationSurfaceIconInstalledDatTests.cs:
reworded a doc comment that named the now-deleted SmokeIconPanel.
- README.md, docs/plugin-ui-markup.md: dropped Smoke-specific mentions,
kept the icon markup example/grammar (now citing MossTank's own real
IconSurfaceId).
- docs/plans/2026-09-06-plugin-shelf-and-dat-icons.md: recorded the owner's
2026-09-06 acceptance and the Smoke removal in the review ledger; deleted
the now-moot "before shipment" Smoke-in-release-zip warning.
- docs/reviews/coverage-ledger.md, docs/reviews/findings-ledger.md: left
untouched — both are frozen audit snapshots ("complete for baseline
<hash>"), so their Smoke rows are historical record, not live claims.
- docs/ISSUES.md: left untouched — its Smoke mentions are inside closed
issue #193's historical write-up of a past investigation.
MossTank plugin shelf icon: MossTankPlugin.cs's PluginPanelDescriptor now
sets IconSurfaceId = 0x06002C41 (IconText = "MT" remains the fallback).
Verified against the installed retail DAT with a new InstalledDat-lane test,
tests/AcDream.App.Tests/UI/MossTankIconInstalledDatTests.cs, mirroring
RetailMarkupIconResolverInstalledDatTests's convention: confirms the id is a
real Portal/HighRes RenderSurface and that RetailMarkupIconResolver.ResolveDid
returns a non-zero texture for it.
Verified: dotnet build AcDream.slnx -c Release green; a stale
plugins/AcDream.Plugins.Smoke output folder from a prior build was deleted
and a fresh build does not recreate it. Full App suite: 7,363 passed / 97
skipped / 36 failed (was 7,362/97/36) — the failing set is unchanged and
none are plugin-related; the one new pass is the MossTank DAT-icon test.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
63 lines
2.7 KiB
C#
63 lines
2.7 KiB
C#
using AcDream.App.Plugins;
|
|
using AcDream.App.Tests.Rendering;
|
|
using AcDream.Content;
|
|
using AcDream.Core.Spells;
|
|
using AcDream.Plugin.Abstractions;
|
|
using DatReaderWriter;
|
|
using DatReaderWriter.Options;
|
|
using Xunit;
|
|
|
|
namespace AcDream.App.Tests.Plugins;
|
|
|
|
/// <summary>
|
|
/// Slice B item 11 (<c>docs/plans/2026-09-06-plugin-shelf-and-dat-icons.md</c>):
|
|
/// <see cref="PluginSpellInfo.IconId"/> must carry the REAL installed
|
|
/// portal.dat SpellTable (<c>0x0E00000E</c>) icon field through
|
|
/// <see cref="AppAutomationSurface"/> unchanged, not just a synthetic
|
|
/// <see cref="SpellMetadata"/> fixture. Mirrors the
|
|
/// <see cref="AcDream.App.Tests.Rendering.ChargenPreviewEntityBuilderTests"/>
|
|
/// installed-DAT gate convention: <see cref="InstalledDatTestPath"/> +
|
|
/// <c>[Trait("Lane", "InstalledDat")]</c>, <c>Assert.Fail</c> with the
|
|
/// standard message when no DAT is configured (see docs/release-gate.md).
|
|
/// </summary>
|
|
[Trait("Lane", "InstalledDat")]
|
|
public sealed class AppAutomationSurfaceIconInstalledDatTests
|
|
{
|
|
/// <summary>Retail's Strength Other I — a well-known always-present spell
|
|
/// id, usable as a fallback when the local character has learned nothing
|
|
/// yet.</summary>
|
|
private const uint KnownSpellId = 1u;
|
|
|
|
[Fact]
|
|
public void KnownSpell_IconId_MatchesTheInstalledSpellTablesIconFieldExactly()
|
|
{
|
|
string? datDir = InstalledDatTestPath.Resolve();
|
|
if (datDir is null)
|
|
{
|
|
Assert.Fail(
|
|
"Lane=InstalledDat requires an installed retail DAT directory; see docs/release-gate.md.");
|
|
return;
|
|
}
|
|
|
|
using var dats = new DatCollection(datDir, DatAccessType.Read);
|
|
using var adapter = new DatCollectionAdapter(dats);
|
|
MagicCatalog catalog = MagicCatalog.Load(adapter);
|
|
|
|
Assert.True(
|
|
catalog.SpellTable.TryGet(KnownSpellId, out SpellMetadata expected),
|
|
$"expected spell {KnownSpellId} (Strength Other I) to exist in the installed SpellTable");
|
|
// A real production install's SpellTable always has non-zero art for
|
|
// an ordinary named spell; a zero here would mean the projector
|
|
// silently dropped SpellBase.Icon rather than proving the pipeline.
|
|
Assert.NotEqual(0u, expected.IconId);
|
|
|
|
using var runtime = GameRuntimeTestFactory.Create();
|
|
runtime.CharacterOwner.InstallSpellMetadata(catalog.SpellTable);
|
|
runtime.CharacterOwner.Spellbook.OnSpellLearned(KnownSpellId);
|
|
using var surface = new AppAutomationSurface();
|
|
surface.Bind(runtime, runtime.CharacterOwner, runtime.ActionOwner.SpellCast);
|
|
|
|
Assert.True(surface.Spells.TryGet(KnownSpellId, out PluginSpellInfo info));
|
|
Assert.Equal(expected.IconId, info.IconId);
|
|
}
|
|
}
|