acdream/tests/AcDream.Runtime.Tests/Gameplay
Erik 067cbea8a5 feat: secure trade with other players - wire, RuntimeTradeState, the
authored gmSecureTradeUI window, and both retail open paths

Three-lane research first (docs/research/2026-08-14-trade-lane{A,B,C}):
retail gmSecureTradeUI decode, the byte-exact ACE/decomp/holtburger
three-way wire agreement, and the acdream seam map (which found both
open paths ALREADY classified by the ported policy - OpenSecureTrade on
Use-a-player, StartSecureTrade on drag-item-onto-player with the
DragItemOnPlayerOpensSecureTrade option - dead-ending at a stub toast).

- Core.Net: TradeRequests builders (0x1F6-0x204, retail's CM_Trade
  senders byte-checked against ACE's readers; the ACE-discarded
  AcceptTrade echo carries zero-count item lists - AD-94), corrected +
  completed inbound parsers (0x1FD-0x208; the old AddToTrade parser
  missed the SIDE dword, TradeFailure missed the reason), delegate-hole
  registrars, six WorldSession sends. 10 golden-byte tests.
- Runtime: RuntimeTradeState, the third sibling J-owner (fellowship/
  allegiance shape): session-scoped, clears at generation reset (new
  stage Trade=14), staged teardown stage 11 (Identity/EntityObjects
  shift 12/13, TeardownStageCount 14 - the FA2-era per-stage-flag test
  caught the mapping exactly as designed), combined ownership ledger,
  event routing with ACE's wrong-initiator RegisterTrade landmine
  honored (partner = whichever guid is not mine). 7 conformance tests.
- App: SecureTradeUiController binds the dedicated authored LayoutDesc
  0x2100000D (root 0x1000007A - gmSecureTradeUI::PostInit's exact ids):
  partner name/status/count/grid, the authored 'Trade' accept toggle
  (accept <-> decline withdraw), 'Clear All' (ACE clears BOTH sides -
  surfaced honestly), the X close, drop-on-your-grid staging, per-mode
  accept cues (partner icon's authored Highlight state + Trade button
  Selected latch). Mounted via the vendor recipe (nine-slice chrome,
  hidden until RegisterTrade). ItemInteractionController's two policy
  arms now raise SecureTradeRequested instead of the stub toast; the
  drag path queues the dragged item until the window registers
  (ClientTradeSystem::AttemptToTradeItem @0x0056DF80's shape).

Register: AD-94 (accept-echo zero-count lists), AD-95 (numeric-only
count texts pending template verification).

Suites: App 4,990/3, Core.Net 905, Runtime 1,626 - all green. The
panel itself is user-gate acceptance (two-client connected trade), the
#372-class lesson: fixture-green alone is not acceptance for a mount.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-14 11:49:13 +02:00
..
CharacterOptionTableTests.cs fix(runtime,net): OP1 review fixes — server-seed gate, tick-wired auto-save/logout flush, fellowship mutual exclusion 2026-08-11 00:39:51 +02:00
InteractionStateTests.cs refactor(runtime): own canonical action state 2026-07-26 10:44:09 +02:00
LocalPlayerImmediatePositionTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
LocalPlayerOutboundCombatStyleTests.cs refactor(runtime): own local movement and outbound cadence 2026-07-26 12:33:53 +02:00
PlayerMouseLookMovementTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
PlayerMovementControllerTests.cs fix: airborne jump refusal fires at RELEASE, not press (user retail 2026-08-14 08:31:22 +02:00
PlayerOutboundPositionTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
PlayerPhysicsQuantumCaptureTests.cs fix(physics): port retail slope landing stop 2026-07-31 09:10:53 +02:00
RuntimeActionStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeActionTestFactory.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeAllegianceStateTests.cs fix(net,runtime): FA2 fix-round MUST-FIX -- allegiance clears at reset, 0x027C stops seeding 2026-08-12 02:17:04 +02:00
RuntimeCharacterStateTests.cs feat(ui): Campaign OP slice OP4 — the Character tab 2026-08-11 04:31:34 +02:00
RuntimeCombatAttackStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeCombatModeStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeCombatTargetStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeCommunicationStateTests.cs fix(ui,runtime): OP4 re-review residuals R1-R4 (coordinator pass) — OP4 CLOSED 2026-08-11 06:36:14 +02:00
RuntimeFellowshipStateTests.cs feat(runtime): FA4 -- fellowship roster enumeration + Social selection source 2026-08-12 04:40:19 +02:00
RuntimeFriendlyTargetQueryTests.cs fix(headless): FA6 — name-match the Recruit bot instead of nearest-any-player 2026-08-12 09:53:46 +02:00
RuntimeGameplayOwnershipTests.cs feat: secure trade with other players - wire, RuntimeTradeState, the 2026-08-14 11:49:13 +02:00
RuntimeHostileTargetQueryTests.cs feat(headless): complete deterministic bot command parity 2026-07-27 08:23:36 +02:00
RuntimeInteractionTransactionStateTests.cs fix(vendor): grand-gate findings — wire-truth container counts, the live split bar, arrival-gated use, prepend-order race 2026-08-08 14:03:57 +02:00
RuntimeInventoryStateTests.cs refactor(runtime): close canonical gameplay ownership 2026-07-26 09:48:51 +02:00
RuntimeLocalPlayerFirstEntryStateTests.cs feat(physics): C4 route 4b-3 — remote teleport + cell-less through the canonical placement 2026-08-04 16:00:10 +02:00
RuntimeLocalPlayerFrameControllerTests.cs fix(headless): #365 — collision-admission-open window drove the first-entry conductor into a permanent seal refusal 2026-08-10 11:34:36 +02:00
RuntimeLocalPlayerMovementStateTests.cs feat(ui): Campaign OP slice OP4 — the Character tab 2026-08-11 04:31:34 +02:00
RuntimeLocalPlayerPhysicsPublicationStateTests.cs fix(runtime): transient collision-seal failure no longer terminal for login (#357) 2026-08-09 12:32:53 +02:00
RuntimeSpellCastStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeTradeStateTests.cs feat: secure trade with other players - wire, RuntimeTradeState, the 2026-08-14 11:49:13 +02:00
RuntimeVendorLifecycleTests.cs fix(vendor): gate-findings pass — the X button HIDES like retail, clicks return, the dropdown scrolls, pyreal suffix, staged-tab slots 2026-08-08 10:29:39 +02:00
RuntimeVendorRangeQueryTests.cs fix(runtime/core): Slice 5.3 review corrections — retirement/transit close, per-unit pricing, guarded auto-close dispatch 2026-08-07 16:15:57 +02:00
TurbineChatMembershipGateTests.cs fix(chat): CH4 review fixes — allegiance ownership guard, house-abandon confirmation 2026-08-09 21:59:35 +02:00
VendorShopItemMaterializerTests.cs fix(vendor): evidence-based pass — max-first stack ceiling; the local player resolves never-animated MoveTo targets 2026-08-08 17:17:04 +02:00