erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions
acdream/src/AcDream.App/UI/Layout
History
Erik 0a37a28e76 fix(ui): Campaign CT5 fix round — Normal-state row media, geometry test, padding, doc corrections 
Opus review of CT5 (f532f28c) found 0 blockers, 4 SHOULD-FIX, 6 NOTEs; all
applied here.

SHOULD-FIX 1 (visible retail gap): unselected attribute/skill rows now draw
the row template's Normal-state media (0x06004CC2 — pinned by
CharacterPanelLiveDatTests.AttributeRowTemplate_...) instead of drawing
nothing. Independently decoded against the installed DAT: PFID_A8R8G8B8,
48x48, uniform (0,0,0,175) — a ~69%-opaque black tile the native-size
copy-or-tile blit repeats across the row. Wired at all three sites
(HandleRowClick, ApplySkillSelectionVisuals, AddRow). Selected rows keep
0x06000F93 (RowHighlightSprite) unchanged.

SHOULD-FIX 2: added Bind_AttributeRow_/Bind_VitalRow_/Bind_SkillRow_
geometry tests asserting the authored template pixels against BUILT rows
(not DAT pins) — width, height, icon/name/value column positions. The
skill-row case reproduces the real production scrollbar (X=281, per
CharacterPanelLiveDatTests.StatListBox_AuthorsFiveRowTemplatesInSharedLayout)
to prove the documented 281px clamp (scrollbar.Left - list.Left), one pixel
short of the attribute/vital rows' 282px ceiling.

SHOULD-FIX 3: AddRow's name-column Padding corrected from 1f to 0f — the
authored template carries no margin on 0x1000012A; Padding=1f re-created
the X=26 glyph-start bug this slice existed to fix.

SHOULD-FIX 4: reworded both UiPanel.BackgroundSprite doc comments — the
draw is a native-size copy-or-tile blit (UV-repeat), never a stretch.
Decoded 0x06000F93 as exactly 282x20 (matches the row natively, draws as a
plain copy) vs 0x06004CC2's 48x48 tile. Retail's UIRegion::SetImageByDID
(@0x0069F960) decompiles to a pure BlitMode selector switch — param_2==2 ->
Blit_3Alpha, ==3 -> Blit_4Alpha, else Blit_Normal — with no width/height
touched anywhere in the function, answering CT1's open "draw mode 3"
question: it's an alpha-blend selector, not a resize flag.

NOTEs:
  a. AddRow's nameEl now sets OneLine=true so the authored VJustify=Center
     takes the same single-line vertical-centering path the value column
     already uses.
  b. Tempered the "row width is 282" wording in the SkillContentWidth /
     RowContentWidth doc comments — that's a ceiling attribute/vital rows
     land on, not a fact true for skill rows (281, via SkillViewportWidth's
     scrollbar-gutter measurement).
  c. Reworded the section-header (RowPadX) comment — CT1 verified only the
     four header SPRITES; the caption label's own authored margins were
     never checked. Recorded as an open residual, not a cleared divergence.
  d. AttrRows/VitalRows are now internal (InternalsVisibleTo("AcDream.App.Tests")
     already covers AcDream.App.Tests); CharacterPanelLiveDatTests iterates
     them directly instead of a re-typed duplicate array, and now also
     asserts the vitals 2/4/6 current-enum aliasing claim the doc comment
     made but never enforced.
  e. Deleted the stale pre-CT5 0x06001397 narrative in
     CharacterPanelLiveDatTests; the pin's comment now describes the
     post-CT5 state (a regression guard, not an open bug).
  f. Unified ApplySkillSelectionVisuals' selected-branch SpriteResolve
     wrapper closure with HandleRowClick's direct assignment.

Build green; full hermetic solution suite green (Release,
Lane!=InstalledDat&...&Status!=KnownFailure filter); InstalledDat lane
green (ACDREAM_RUN_INSTALLED_DAT_TESTS=1, Lane=InstalledDat&Status!=KnownFailure).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-25 01:47:25 +02:00
..
AppraisalUiController.cs fix: retail text and golden-string tests must not follow the machine's locale 2026-08-19 19:56:09 +02:00
CharacterController.cs fix: retail text and golden-string tests must not follow the machine's locale 2026-08-19 19:56:09 +02:00
CharacterCreationAppearancePage.cs fix(chargen): Campaign CC gate round 1 re-test 3 — R4-1..R4-4 2026-08-16 19:05:23 +02:00
CharacterCreationHeritagePage.cs fix(chargen): Campaign CC gate round 1 closeout — Group 3: round review fixes (F4-F11, F14, F16) 2026-08-16 15:34:07 +02:00
CharacterCreationProfessionPage.cs fix(chargen): Campaign CC gate round 1 closeout — Group 3: round review fixes (F4-F11, F14, F16) 2026-08-16 15:34:07 +02:00
CharacterCreationSkillsPage.cs fix(chargen): Campaign CC gate round 1 re-test 3 — R4-1..R4-4 2026-08-16 19:05:23 +02:00
CharacterCreationSummaryPage.cs fix(chargen): Campaign CC gate round 1 closeout — Group 3: round review fixes (F4-F11, F14, F16) 2026-08-16 15:34:07 +02:00
CharacterCreationTownPage.cs fix(chargen): Campaign CC gate round 1 closeout — Group 3: round review fixes (F4-F11, F14, F16) 2026-08-16 15:34:07 +02:00
CharacterCreationUiController.cs fix(chargen): Campaign CC gate round 1 re-test 2 — R3-5/R3-6 color-key swatch/gradient textures 2026-08-16 17:20:31 +02:00
CharacterCreationUiMountCoordinator.cs feat(app): Campaign CC slice CC4 — chargen screen shell + Heritage/Profession/Skills/Town pages 2026-08-15 17:45:51 +02:00
CharacterIdentityText.cs fix(ui): Campaign CT4 fix round — luminance text, verbatim title, PK PWD bits 2026-08-25 00:54:33 +02:00
CharacterManagementUiController.cs fix(test): UI probe pointer commands convert canvas to window coordinates; char-select Enter logs its outcome 2026-08-17 10:52:13 +02:00
CharacterManagementUiMountCoordinator.cs Make character UI retries transactional 2026-08-14 21:14:08 +02:00
CharacterOptionsPageController.cs feat(ui): vitals — Side By Side Vitals swaps retail's two vitals windows 2026-08-17 10:40:49 +02:00
CharacterSheet.cs fix(ui): Campaign CT4 fix round — luminance text, verbatim title, PK PWD bits 2026-08-25 00:54:33 +02:00
CharacterSheetProvider.cs fix(ui): Campaign CT4 fix round — luminance text, verbatim title, PK PWD bits 2026-08-25 00:54:33 +02:00
CharacterStatController.cs fix(ui): Campaign CT5 fix round — Normal-state row media, geometry test, padding, doc corrections 2026-08-25 01:47:25 +02:00
CharacterTitleResolver.cs fix(CT): CT2 fix round — dedupe client-side title add, drop retail-inexact send guard 2026-08-24 22:27:07 +02:00
CharacterTitlesController.cs fix(CT): CT3 fix round — port Refresh's unconditional selection clear, drop unresolvable-id rows 2026-08-24 23:28:28 +02:00
ChargenColorSpotComposer.cs fix(chargen): Campaign CC gate round 1 re-test 2 — R3-5/R3-6 color-key swatch/gradient textures 2026-08-16 17:20:31 +02:00
ChatOptionsDatCaptions.cs fix #380: Chat tab opacity sliders were missing their retail row captions 2026-08-11 23:01:22 +02:00
ChatOptionsDatDefaults.cs feat(ui): Campaign OP slice OP5 — the Chat tab 2026-08-11 06:25:59 +02:00
ChatOptionsPageController.cs fix #380: Chat tab opacity sliders were missing their retail row captions 2026-08-11 23:01:22 +02:00
ChatTranscriptRenderer.cs feat(chat): CT-C2 Escape leaves the entry; CT-C3 the timestamp is grey 2026-08-21 08:28:45 +02:00
ChatWindowController.cs fix(ui): talk-button caption centers per the authored label child 2026-08-24 20:47:01 +02:00
CombatUiController.cs fix: powerbar mode captions - jump 'Height' + combat 'Power'/'Accuracy' 2026-08-14 08:14:14 +02:00
ComponentBookTemplateFactory.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
ConfigOptionsPageController.cs fix(ui): retail scrollbar parity — button seating, full-track thumb, hover/pressed states 2026-08-24 19:20:43 +02:00
CreatureAppraisalRows.cs fix: retail text and golden-string tests must not follow the machine's locale 2026-08-19 19:56:09 +02:00
DatRichText.cs fix(ui): systemic escape normalization at the string source 2026-08-17 13:26:25 +02:00
DatStringResolver.cs fix(ui): systemic escape normalization at the string source 2026-08-17 13:26:25 +02:00
DatWidgetFactory.cs fix(ui): chat window retail parity — focus rails, authored captions, menu flick, drag-stable text 2026-08-24 20:27:04 +02:00
EffectRowTemplateFactory.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
EffectsUiController.cs fix(ui): effects list stayed pinned at its authored height in a taller window 2026-08-20 21:00:16 +02:00
ElementReader.cs feat(chat): CT-A4 — speaker names render in retail's tag colour 2026-08-21 07:31:20 +02:00
ExternalContainerController.cs fix(ui): retail scrollbar parity — button seating, full-track thumb, hover/pressed states 2026-08-24 19:20:43 +02:00
FloatingChatWindowController.cs feat(chat): retail text style — two-plane glyph outlines, authored SpewBox/chat styles 2026-08-10 19:28:34 +02:00
HousePageController.cs fix(ui): night-round review — F2 HouseQuery fires at login, not tab-open 2026-08-17 04:28:46 +02:00
IndicatorBarController.cs feat: regen buffs, wand aura, spellbook assess, indicator press flash 2026-08-20 20:38:28 +02:00
IndicatorDetailText.cs fix(ui): systemic escape normalization at the string source 2026-08-17 13:26:25 +02:00
InventoryController.cs fix(ui): restore retail vitals and window interactions 2026-08-20 13:26:35 +02:00
IRetailDialogView.cs fix #394 #395 #396: OP8 re-gate round — caption font, retail key names, capture dialog 2026-08-14 13:45:55 +02:00
ItemAppraisalReport.cs fix(ui): systemic escape normalization at the string source 2026-08-17 13:26:25 +02:00
ItemAppraisalTextFormatter.cs fix: retail text and golden-string tests must not follow the machine's locale 2026-08-19 19:56:09 +02:00
ItemCooldownAssets.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
ItemCooldownUiController.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
ItemListCellTemplate.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
JournalContractsPageController.cs fix(journal): the location readout is a FIELD, refresh at the click, and Abandon works 2026-08-21 16:19:18 +02:00
JournalNotesPageController.cs fix(journal): the timer's unit labels hide with their boxes 2026-08-21 18:29:58 +02:00
JournalPageListController.cs feat(journal): QJ3/QJ4/QJ5 — both remaining tabs are live 2026-08-21 15:42:05 +02:00
JournalPanelController.cs feat(journal): QJ3/QJ4/QJ5 — both remaining tabs are live 2026-08-21 15:42:05 +02:00
JumpPowerbarController.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
KeyboardConfigController.cs fix #394 #395 #396: OP8 re-gate round — caption font, retail key names, capture dialog 2026-08-14 13:45:55 +02:00
LayoutImporter.cs feat(ui): authored state media animates, so the unseen-text indicator blinks 2026-08-21 11:14:53 +02:00
LinkStatusUiController.cs fix: retail text and golden-string tests must not follow the machine's locale 2026-08-19 19:56:09 +02:00
MapHousePanelController.cs fix(ui): night-round review — F2 HouseQuery fires at login, not tab-open 2026-08-17 04:28:46 +02:00
MapLocations.cs feat(ui): Map/House panel — slices 2+3, panel shell + Map tab 2026-08-17 02:04:19 +02:00
MapPageController.cs fix(ui): morning gate — map town markers: green rollover highlight + the authored map-note tooltip skin/font 2026-08-17 09:22:46 +02:00
MiniGameUiController.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
MouseTurningSettingsMacro.cs feat(ui): Campaign OP slice OP3 — Options panel shell, open paths, Gameplay tab 2026-08-11 02:14:40 +02:00
OptionPageModel.cs feat(render): implement Campaign AR and terrain fidelity 2026-08-22 13:13:29 +02:00
OptionsPanelController.cs fix #381: Options-panel footer needs an opaque backing field 2026-08-11 23:01:43 +02:00
PaperdollClickMap.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
PaperdollController.cs feat(ui): inventory/shortcut/paperdoll item-name tooltips — UIElement_UIItem::UpdateTooltip port 2026-08-16 23:02:10 +02:00
PaperdollSlotBackgrounds.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
RadarController.cs fix(ui): restore retail vitals and window interactions 2026-08-20 13:26:35 +02:00
RadarSnapshotProvider.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
RetailAppraisalNameResolver.cs feat(ui): Campaign CT slice CT5 — attribute/skill row geometry + selection media 2026-08-25 01:15:32 +02:00
RetailCombatLayout.cs fix(ui): match retail spell bar controls 2026-07-23 07:49:09 +02:00
RetailConfirmationDialogView.cs fix(runtime,ui): Campaign LA gate round 2 — world name reads durably; dialogs center on the canvas 2026-08-15 12:02:33 +02:00
RetailConfirmationTextInputDialogView.cs fix(runtime,ui): Campaign LA gate round 2 — world name reads durably; dialogs center on the canvas 2026-08-15 12:02:33 +02:00
RetailDialogData.cs fix(ui,runtime): Campaign LA gate-round-2 batch-review fixes F1,F3-F8; file #401 2026-08-15 12:28:06 +02:00
RetailDialogFactory.cs fix(chargen): Campaign CC gate round 1 Batch A — GF-15 input, GF-5 skills rows, GF-13 GM toggles 2026-08-16 10:54:41 +02:00
RetailFpsController.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
RetailKeyNames.cs fix #394 #395 #396: OP8 re-gate round — caption font, retail key names, capture dialog 2026-08-14 13:45:55 +02:00
RetailMessageDialogView.cs fix(runtime,ui): Campaign LA gate round 2 — world name reads durably; dialogs center on the canvas 2026-08-15 12:02:33 +02:00
RetailPanelUiController.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
RetailStringEscapes.cs fix(ui): systemic escape normalization at the string source 2026-08-17 13:26:25 +02:00
RetailTabBinding.cs fix(ui): share retail tab state binding 2026-07-15 17:21:16 +02:00
RetailTooltipPresenter.cs fix #430: tooltip wrap and draw honor the text child's authored margins 2026-08-24 18:44:28 +02:00
RetailWaitDialogView.cs fix(ui,runtime): Campaign LA gate-round-2 batch-review fixes F1,F3-F8; file #401 2026-08-15 12:28:06 +02:00
RetailWindowFrame.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
RowTemplateResolver.cs fix(ui): morning gate — map town markers: green rollover highlight + the authored map-note tooltip skin/font 2026-08-17 09:22:46 +02:00
SampleData.cs feat(render): Campaign V slice V11 commit 1 - delete ImGui, Studio, and the DevTools frontend 2026-07-28 23:56:04 +02:00
SecureTradeUiController.cs feat(ui): inventory/shortcut/paperdoll item-name tooltips — UIElement_UIItem::UpdateTooltip port 2026-08-16 23:02:10 +02:00
SelectedObjectController.cs fix #435 (part 2, closes it): attribute the unowned probes — delete 7, reclassify 8, restore 1 2026-08-24 12:32:42 +02:00
SocialAllegiancePageController.cs fix: social gate round 2, part 2 - confirmation-dialog sentences + the 2026-08-13 21:10:42 +02:00
SocialFellowshipPageController.cs fix: social gate round 2, part 1 - border-only move cursor, literal-\n 2026-08-13 20:36:24 +02:00
SocialFriendsPageController.cs fix: friends list live Online/Offline status - authored row state 2026-08-14 10:57:57 +02:00
SocialPanelController.cs fix: social panel completion batch (user gate 2026-08-13, "fix all") 2026-08-13 19:30:51 +02:00
SocialPanelRowText.cs fix(ui): fellowship checkbox count, row-text + ListBox Flush doc corrections, promote probe findings to assertions 2026-08-12 03:44:05 +02:00
SocialSquelchPageController.cs fix: social panel completion batch (user gate 2026-08-13, "fix all") 2026-08-13 19:30:51 +02:00
SpellbookRowStyle.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
SpellbookWindowController.cs fix(ui): effects list stayed pinned at its authored height in a taller window 2026-08-20 21:00:16 +02:00
SpellcastingUiController.cs fix(ui): night-round review — F3/F4/F7 cast-button tooltip strings 2026-08-17 04:39:17 +02:00
SpellExamineComponentTemplateFactory.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
ToolbarController.cs fix(ui): restore retail vitals and window interactions 2026-08-20 13:26:35 +02:00
ToolbarInputController.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
UiDatElement.cs fix #416 #415: the retail button state/media machine — roster hover highlight clears; probe wait verbs bind without an artifact dir 2026-08-17 16:25:36 +02:00
UiMediaSequence.cs feat(ui): authored state media animates, so the unseen-text indicator blinks 2026-08-21 11:14:53 +02:00
UiPropertyBag.cs feat(ui): authored state media animates, so the unseen-text indicator blinks 2026-08-21 11:14:53 +02:00
UiTemplateListSlot.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
UiTextLayoutCache.cs perf(ui): retain shaped report text 2026-07-25 05:11:12 +02:00
UiVitalsRoot.cs fix(ui): vitals — UiVitalsRoot.OnEvent delegates to the UiDatElement base 2026-08-17 10:48:25 +02:00
VendorUiController.cs fix(ui): retail scrollbar parity — button seating, full-track thumb, hover/pressed states 2026-08-24 19:20:43 +02:00
VitaeUiController.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
VitalsController.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
VitalsSideBySideController.cs feat(ui): vitals — Side By Side Vitals swaps retail's two vitals windows 2026-08-17 10:40:49 +02:00
VividTargetIndicatorController.cs Revert "Campaign V slice V4a" - it lost world multisampling 2026-07-27 18:29:28 +02:00
WindowChromeController.cs feat(ui): centralize retained window lifecycle 2026-07-10 21:31:18 +02:00