172c6f9aa3
Retail colors chat lines by the 34-value wire LogTextType (ACE's ChatMessageType), NOT by acdream's synthetic 9-value ChatKind. The old ChatWindowController.RetailChatColor(ChatKind) collapsed distinct retail colors onto one bucket per ChatKind — e.g. every Channel line rendered colorLightBlue (Magic's slot) when retail's actual palette spans five different colors across the Turbine rooms and legacy allegiance family. Ports ChatInterface::BuildChatColorLookupTable @0x004F31C0 verbatim (RetailChatColorTable, all 34 RGBA floats read from the PDB-paired binary's .data section) and threads a new ChatEntry.LogTextType field through every ingestion site to the correct retail wire value: HearSpeech/Tell pass the wire chatType through verbatim; Emote/SoulEmote hard-code 0x0C; the Tell self-echo hard-codes 0x04; legacy ChatChannel broadcasts derive their type from the channel bit via the new LegacyChannelChatType helper (ported from the decompiled Handle_Communication__ChannelBroadcast dispatch, hear vs. own-send); TurbineChat rooms map through TurbineChatDisplayNames.LogTextType; CombatChatTranslator's hit/miss/evade lines map to ACE's CombatSelf/ CombatEnemy per Player_Combat.cs; kill/death lines use retail's decompiled 0x00 Default (not a combat color). ChatWindowController's transcript now folds LogTextType through RetailChatColorTable with retail's exact "out-of-range keeps the previous line's color" carry rule; ChatPanel's combat highlighting sources the same table. Corrects HearSpeech.cs's doc-comment ChatType legend (4 of 6 entries were wrong). Adds register row AP-175 for the pre-existing (unchanged) Popup-renders-in-chat divergence and updates AP-39's stale per-ChatKind description. Narrows ISSUES #139 — its chat-colors half is done. Retail renders no chat timestamp prefix path exists in acdream today, so the "timestamp is always colorGrey 0x0C" rule has nothing to attach to; noted here per the research doc rather than left silent. Research: docs/research/2026-08-09-chat-retail-color-table.md Full Release suite: 11,833 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
37 lines
1.5 KiB
C#
37 lines
1.5 KiB
C#
using AcDream.Core.Net.Messages;
|
|
using AcDream.Runtime.Session;
|
|
using Xunit;
|
|
|
|
namespace AcDream.Runtime.Tests.Session;
|
|
|
|
/// <summary>
|
|
/// Campaign CH slice CH1: pins <see cref="TurbineChatDisplayNames.LogTextType"/>
|
|
/// against retail's <c>ChatRoomTracker::GetChatFormat @0x005CD7C0</c>, which
|
|
/// writes <c>ChatDisplayInfo::m_ltt</c> directly per Turbine room field —
|
|
/// General/Trade/LFG/Roleplay each get their OWN slot, every Society variant
|
|
/// collapses to one slot, and Allegiance/Olthoi share the Allegiance slot.
|
|
/// </summary>
|
|
public sealed class TurbineChatDisplayNamesTests
|
|
{
|
|
[Theory]
|
|
[InlineData(TurbineChat.ChatType.Allegiance, 0x12u)]
|
|
[InlineData(TurbineChat.ChatType.General, 0x1Bu)]
|
|
[InlineData(TurbineChat.ChatType.Trade, 0x1Cu)]
|
|
[InlineData(TurbineChat.ChatType.Lfg, 0x1Du)]
|
|
[InlineData(TurbineChat.ChatType.Roleplay, 0x1Eu)]
|
|
[InlineData(TurbineChat.ChatType.Society, 0x20u)]
|
|
[InlineData(TurbineChat.ChatType.SocietyCelHan, 0x20u)]
|
|
[InlineData(TurbineChat.ChatType.SocietyEldWeb, 0x20u)]
|
|
[InlineData(TurbineChat.ChatType.SocietyRadBlo, 0x20u)]
|
|
[InlineData(TurbineChat.ChatType.Olthoi, 0x12u)]
|
|
public void LogTextType_MatchesRetailChatFormat(TurbineChat.ChatType chatType, uint expected)
|
|
{
|
|
Assert.Equal(expected, TurbineChatDisplayNames.LogTextType((uint)chatType));
|
|
}
|
|
|
|
[Fact]
|
|
public void LogTextType_UnknownChatType_FallsBackToDefault()
|
|
{
|
|
Assert.Equal(0x00u, TurbineChatDisplayNames.LogTextType((uint)TurbineChat.ChatType.Undef));
|
|
}
|
|
}
|