Campaign OVERHAUL S3 chunk 1 (docs/research/2026-09-01-overhaul/s3-walk-ownership-map.md
§11): the transcript-kinds/fixtures/print-only-emitter half of the walk work,
built AFTER chunk 3 landed LC/SC (the per-land-cell interleave).
B1 — the emitter (print-only, never gates admission/depth/order):
- ACDREAM_DUMP_WALK_TRANSCRIPT=1 is read once into RuntimeOptions.DumpWalkTranscript
(rule 4) and handed to RenderingDiagnostics.DumpWalkTranscriptEnabled (rule 5,
a settable static, not a second env read) once at GameWindow construction — the
deep walk call sites have no reachable RuntimeOptions reference.
- WalkTranscriptDump (new) prints the OH line kinds — F/P/LS/LC/SC/BLD/DI/DC/EC/OC —
to Console at the exact points retail's cdb breakpoints sit
(tools/walk-oracle/oh/oh-capture-walk.cdb.template), gated internally so every
method bails out before any string work when the flag is off.
- Every call site lives in WalkFrameDriver.cs, at the point the driver already
processes that turn: Collect (F/P, after BeginFrame), Emit's DI/LS/DC/BLD cases,
OnLandCellTurn/OnLandscapeCellTurn (LC/SC, at LOD resolution via the new
WalkTranscriptDump.LodCellId helper, before the 8x8-bucket expansion), and the
EmitFloodTurns/EmitCellContentsTurn loops (EC/OC — both UNCONDITIONAL per flood
visit, matching the OH captures' always-equal EC/OC counts; retail's own
DrawEnvCell stamp dedupe sits past the breakpoint, inside the function).
- DC's "pv=" field encodes interior(0)/outdoor(1) as an 8-hex-digit 0/1 so it
satisfies the same pv=[0-9a-f]{8} regex real captures use; derived from
_currentDcStage at the DC event (CellStatic = interior pview, else outdoor).
- The frame-root pose (origin, quaternion) is a reasonable orthonormal basis built
from the walk's own CyPlane.Normal forward vector and WalkLandscape's own
ViewerWorldOriginX/Y block origin — self-consistent for the round-trip parser,
not a byte-exact reproduction of retail's Frame (B4's diff never compares P).
B2 — WalkOracleTrace learns EC/OC event kinds (LC/SC already existed from chunk 3).
New WalkOraclePartsTrace.cs holds two small read-only parsers for the parts log
(PD/DM) and the alpha-depth log (AM/FL/PM/PC) — records only, no validator, no
canonical JSONL, no new tool.
B3 — fixtures: the five OH walk captures join WalkOracleTraceTests.AllFixtures
(now (root, name) pairs — FW0's own root plus the OH capture directory) for
parse + complete-frame pins. The four kit poses join WalkTraceConformanceTests'
still-fixture coverage as NEW rows (the OH cathedral-arrival root is f4180108,
not FW0's f4180106): terrace-edge/cathedral-arrival extend the existing theory
(now (root, fixture) parameterized); holtburg-doorway-still and foundry-deep get
dedicated tests mirroring their FW0 siblings' own structure. Finding: the OH
foundry-deep capture's own retail transcript draws 12 real town buildings through
its exit chain (unlike the FW0 capture, which apparently reached none at that
pose) — the FW0 test's stub 1x1 landscape undershoots it (first divergence:
nothing after "LS" vs retail's real BLD content); fixed by building the full
landscape/building world via WalkLandscapeDatBuilder.Build, matching the shared
theory's own approach, not by skipping or weakening the row.
WalkTraceReplayContext.Signature(WalkOracleFrame) now filters to the DI/DC/BLD/LS
kinds (LC/SC/EC/OC never had a WalkEvent analogue in RetailFrameWalk's own
four-kind vocabulary) instead of mapping them to a "?" placeholder, so the still-
fixture comparison stays apples-to-apples on both sides.
B4 — WalkTranscriptSignatureDiff (test-side only, no runner/tool): diffs two
transcripts (raw lines or parsed frames) at the full DI/DC/BLD/LS/LC/SC/EC/OC
level, reporting the first divergent event and position per frame. Proven over a
synthetic self-vs-self-minus-one-event pair (SignatureDiff_ReportsTheExactRemovedEvent).
Tests: T1 (flag off) is split into a unit-level zero-allocation/zero-output check
on WalkTranscriptDump itself (the walk's pre-existing allocation, e.g.
RetailFrameWalk.EmitDrawCells's per-call array, is untouched by this chunk and not
independently zero-alloc) and an integration-level Collect() check; both assert via
WalkOracleTrace.Parse returning zero frames rather than raw string equality, which
is robust to unrelated Console.WriteLine noise from other test classes running in
parallel (a real, observed hazard — WalkFrameDriverTests joins
CameraDiagnosticsCollection for the same reason CornerFloodReplayTests/
Issue181WallPressEquilibriumTests already do, issue #251). T2 proves the
emitter/parser round trip on a synthetic interior frame. T3's InstalledDat rows all
pass. T4: LaunchOptionsDocumentationTests green with the ACDREAM_DUMP_WALK_TRANSCRIPT
row (both directions).
Gates: hermetic lane 6,814/0 (was 6,795 baseline + new tests), three consecutive
clean runs; InstalledDat lane 245/3 known-failures (the two pre-existing #383
layout tests + TowerAscent) unchanged from baseline.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
344 lines
16 KiB
C#
344 lines
16 KiB
C#
using System.Numerics;
|
|
using AcDream.App.Rendering;
|
|
using AcDream.App.Rendering.Gpu;
|
|
using AcDream.App.Rendering.Walk;
|
|
using AcDream.App.Tests.Rendering;
|
|
using AcDream.Core.Rendering;
|
|
|
|
namespace AcDream.App.Tests.Rendering.Walk;
|
|
|
|
/// <summary>
|
|
/// Campaign OVERHAUL S3 chunk 1 (§11.2): tests T1/T2 for the print-only walk
|
|
/// transcript emitter (<see cref="WalkTranscriptDump"/>, gated by
|
|
/// <see cref="RenderingDiagnostics.DumpWalkTranscriptEnabled"/>), plus the
|
|
/// §11.2 B4 offline signature-diff self-check. Reuses
|
|
/// <see cref="WalkFrameDriverTests"/>'s own private fixture types via the
|
|
/// shared <c>partial class</c> — the SAME minimal interior two-cell flood
|
|
/// (one exit view) that file's own
|
|
/// <c>RunFrame_InteriorFloodWithExitView_FreshDriverSkipsTheGatedClearThenDrawsSealsAndFloodCells</c>
|
|
/// test already exercises and proves correct; here only
|
|
/// <see cref="WalkFrameDriver.Collect"/> runs (no <c>Replay</c>/GPU
|
|
/// submission), since every transcript print fires synchronously during the
|
|
/// walk itself.
|
|
///
|
|
/// <para>
|
|
/// <see cref="RenderingDiagnostics.DumpWalkTranscriptEnabled"/> and
|
|
/// <see cref="Console.Out"/> are both process-wide mutable statics — joins
|
|
/// <see cref="CameraDiagnosticsCollection"/> for the SAME reason
|
|
/// <c>CornerFloodReplayTests</c>/<c>Issue181WallPressEquilibriumTests</c> do
|
|
/// (that collection's own doc comment, issue #251): interleaved
|
|
/// <c>Console.SetOut</c> redirection across parallel test classes can
|
|
/// restore a disposed <see cref="StringWriter"/> process-wide.
|
|
/// </para>
|
|
/// </summary>
|
|
[Collection(CameraDiagnosticsCollection.Name)]
|
|
public sealed partial class WalkFrameDriverTests
|
|
{
|
|
private static (WalkCell Cell1, WalkCell Cell2) BuildTranscriptFixtureCells(TestContext ctx)
|
|
{
|
|
var cell1 = new WalkCell
|
|
{
|
|
CellId = 0x100,
|
|
StabList = [0x101u],
|
|
Portals =
|
|
[
|
|
new WalkCellPortal
|
|
{
|
|
OtherCellId = 0x101, PolygonIndex = 0, PortalSide = 0, OtherPortalId = 0,
|
|
},
|
|
// The exit portal — raises ov to 1, so the flood draws the
|
|
// (empty, zero-block) landscape too, exercising LS.
|
|
new WalkCellPortal
|
|
{
|
|
OtherCellId = 0xFFFFFFFF, PolygonIndex = 1, PortalSide = 0, OtherPortalId = -1,
|
|
},
|
|
],
|
|
PortalPolygons = [Quad(-2f), Quad(-3f)],
|
|
};
|
|
var cell2 = new WalkCell
|
|
{
|
|
CellId = 0x101,
|
|
Portals = [new WalkCellPortal
|
|
{
|
|
OtherCellId = 0x100, PolygonIndex = 0, PortalSide = 1, OtherPortalId = 0,
|
|
}],
|
|
PortalPolygons = [Quad(-2f)],
|
|
};
|
|
ctx.Cells[cell1.CellId] = cell1;
|
|
ctx.Cells[cell2.CellId] = cell2;
|
|
return (cell1, cell2);
|
|
}
|
|
|
|
/// <summary>T1 (§11.3): the flag off — zero output, and the emitter's
|
|
/// own methods (the only code this chunk adds to the walk path)
|
|
/// allocate nothing. The walk itself is NOT independently zero-alloc
|
|
/// (e.g. <c>RetailFrameWalk.EmitDrawCells</c> allocates its cell-id
|
|
/// array on every call — pre-existing, unrelated to this chunk), so the
|
|
/// allocation bound below is scoped to <see cref="WalkTranscriptDump"/>
|
|
/// itself, matching B1's actual contract ("allocates nothing EXTRA").</summary>
|
|
[Fact]
|
|
public void TranscriptEmitter_FlagOff_EveryPrintMethodIsAZeroCostNoOp()
|
|
{
|
|
bool previous = RenderingDiagnostics.DumpWalkTranscriptEnabled;
|
|
RenderingDiagnostics.DumpWalkTranscriptEnabled = false;
|
|
TextWriter originalOut = Console.Out;
|
|
var capture = new StringWriter();
|
|
try
|
|
{
|
|
Console.SetOut(capture);
|
|
|
|
var cells = new List<uint> { 0x100u, 0x101u };
|
|
void Step()
|
|
{
|
|
WalkTranscriptDump.PrintFrameRoot(1, 0x100u, Vector3.Zero, Vector3.UnitY);
|
|
WalkTranscriptDump.PrintLandscape();
|
|
WalkTranscriptDump.PrintBuilding(0x100u);
|
|
WalkTranscriptDump.PrintDrawInside(0x100u);
|
|
WalkTranscriptDump.PrintDrawCells(outdoorPview: false, 1, cells);
|
|
WalkTranscriptDump.PrintLandCell(0xF4180001u);
|
|
WalkTranscriptDump.PrintSortCell(0xF4180001u);
|
|
WalkTranscriptDump.PrintEnvCellShell(0x101u);
|
|
WalkTranscriptDump.PrintObjectCellTurn(0x101u);
|
|
}
|
|
|
|
ZeroAllocationProbe.AssertAllocatesNothing(
|
|
"WalkTranscriptDump.Print* (flag off)", Step);
|
|
|
|
AssertNoTranscriptLines(capture);
|
|
}
|
|
finally
|
|
{
|
|
Console.SetOut(originalOut);
|
|
RenderingDiagnostics.DumpWalkTranscriptEnabled = previous;
|
|
}
|
|
}
|
|
|
|
/// <summary>T1's integration half: a full synthetic interior frame,
|
|
/// driven through the SAME <see cref="WalkFrameDriver.Collect"/> path
|
|
/// production uses, produces literally NO transcript output when the
|
|
/// flag is off.</summary>
|
|
[Fact]
|
|
public void Collect_TranscriptFlagOff_ProducesNoConsoleOutput()
|
|
{
|
|
bool previous = RenderingDiagnostics.DumpWalkTranscriptEnabled;
|
|
RenderingDiagnostics.DumpWalkTranscriptEnabled = false;
|
|
TextWriter originalOut = Console.Out;
|
|
var capture = new StringWriter();
|
|
try
|
|
{
|
|
Console.SetOut(capture);
|
|
|
|
using var fx = new DispatcherFixture();
|
|
var ctx = new TestContext();
|
|
(WalkCell cell1, _) = BuildTranscriptFixtureCells(ctx);
|
|
var landscape = new WalkLandscape { MidWidth = 1, Blocks = new WalkLandBlock?[1] };
|
|
var worldData = new FakeWorldData();
|
|
var leaf = new RecordingLeafRenderer(new List<string>());
|
|
using ClipFrame clipFrame = ClipFrame.NoClip();
|
|
var driver = new WalkFrameDriver(fx.Dispatcher, leaf, worldData, clipFrame: clipFrame);
|
|
var walk = new RetailFrameWalk();
|
|
|
|
driver.Collect(
|
|
walk, cell1.CellId, cell1, landscape, ctx, Matrix4x4.Identity, Vector3.Zero);
|
|
|
|
AssertNoTranscriptLines(capture);
|
|
}
|
|
finally
|
|
{
|
|
Console.SetOut(originalOut);
|
|
RenderingDiagnostics.DumpWalkTranscriptEnabled = previous;
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Asserts NONE of <see cref="WalkTranscriptDump"/>'s own line kinds
|
|
/// appear in <paramref name="capture"/> — robust to unrelated
|
|
/// <see cref="Console"/> noise from another test class running in
|
|
/// parallel (a real, observed hazard: xUnit runs distinct classes
|
|
/// concurrently by default, and <see cref="Console.Out"/> is a
|
|
/// process-wide static — see <c>CameraDiagnosticsCollection</c>'s own
|
|
/// doc comment, issue #251). A plain <c>Assert.Empty(capture.ToString())</c>
|
|
/// is NOT this robust: an unrelated class's unconditional
|
|
/// <c>Console.WriteLine</c> can land inside this test's redirect window
|
|
/// and fail it for a reason that has nothing to do with the transcript
|
|
/// flag. <see cref="WalkOracleTrace.Parse"/> only ever appends a frame
|
|
/// once it sees a well-formed <c>F <n></c> marker line — arbitrary
|
|
/// unrelated text can never satisfy that regex, so a truly EMPTY parsed
|
|
/// frame list is exactly as strong a proof that THIS code printed
|
|
/// nothing, without being sensitive to what else shares the process
|
|
/// console.
|
|
/// </summary>
|
|
private static void AssertNoTranscriptLines(StringWriter capture)
|
|
{
|
|
string[] lines = capture.ToString()
|
|
.Split('\n', StringSplitOptions.RemoveEmptyEntries)
|
|
.Select(l => l.TrimEnd('\r'))
|
|
.ToArray();
|
|
Assert.Empty(WalkOracleTrace.Parse(lines));
|
|
}
|
|
|
|
/// <summary>T2 (§11.3): flag on, one synthetic interior frame — the
|
|
/// printed lines parse with the extended <see cref="WalkOracleTrace"/>
|
|
/// into the same events the driver recorded (emitter/parser round
|
|
/// trip). Asserted structurally (kinds, cell ids, counts) rather than
|
|
/// against a hand-predicted exact ordering, so the test does not
|
|
/// silently pin an assumption about traversal order it never
|
|
/// independently verified.</summary>
|
|
[Fact]
|
|
public void Collect_TranscriptFlagOn_PrintedLinesRoundTripThroughTheParser()
|
|
{
|
|
bool previous = RenderingDiagnostics.DumpWalkTranscriptEnabled;
|
|
RenderingDiagnostics.DumpWalkTranscriptEnabled = true;
|
|
TextWriter originalOut = Console.Out;
|
|
var capture = new StringWriter();
|
|
try
|
|
{
|
|
Console.SetOut(capture);
|
|
|
|
using var fx = new DispatcherFixture();
|
|
var ctx = new TestContext();
|
|
(WalkCell cell1, WalkCell cell2) = BuildTranscriptFixtureCells(ctx);
|
|
var landscape = new WalkLandscape { MidWidth = 1, Blocks = new WalkLandBlock?[1] };
|
|
var worldData = new FakeWorldData();
|
|
var leaf = new RecordingLeafRenderer(new List<string>());
|
|
using ClipFrame clipFrame = ClipFrame.NoClip();
|
|
var driver = new WalkFrameDriver(fx.Dispatcher, leaf, worldData, clipFrame: clipFrame);
|
|
var walk = new RetailFrameWalk();
|
|
|
|
// Two Collect calls: WalkOracleTrace.Parse (like every real
|
|
// capture) only flushes a frame once the NEXT "F n" marker
|
|
// appears — it deliberately drops the final in-progress frame
|
|
// (the detach-frame rule). One frame alone would parse to zero
|
|
// complete frames.
|
|
driver.Collect(
|
|
walk, cell1.CellId, cell1, landscape, ctx, Matrix4x4.Identity, Vector3.Zero);
|
|
driver.Collect(
|
|
walk, cell1.CellId, cell1, landscape, ctx, Matrix4x4.Identity, Vector3.Zero);
|
|
|
|
Console.Out.Flush();
|
|
string[] lines = capture.ToString()
|
|
.Split('\n', StringSplitOptions.RemoveEmptyEntries)
|
|
.Select(l => l.TrimEnd('\r'))
|
|
.ToArray();
|
|
Assert.NotEmpty(lines);
|
|
|
|
IReadOnlyList<WalkOracleFrame> frames = WalkOracleTrace.Parse(lines);
|
|
WalkOracleFrame frame = Assert.Single(frames);
|
|
Assert.Equal(1, frame.Number);
|
|
|
|
Assert.NotNull(frame.Pose);
|
|
Assert.Equal(cell1.CellId, frame.Pose!.CellId);
|
|
|
|
Assert.Equal(cell1.CellId, frame.InteriorRootCell);
|
|
Assert.True(frame.HasLandscape);
|
|
|
|
WalkOracleEvent dc = Assert.Single(
|
|
frame.Events, e => e.Kind == WalkOracleEventKind.DrawCells);
|
|
Assert.Equal(1, dc.OutsideViewCount);
|
|
Assert.Equal(
|
|
new HashSet<uint> { cell1.CellId, cell2.CellId },
|
|
dc.Cells.ToHashSet());
|
|
|
|
// The interior root's own flood visits both cells for a shell
|
|
// AND an object-list turn — EC/OC pair, one line per cell, no
|
|
// dedupe (WalkTranscriptDump.PrintEnvCellShell's own doc
|
|
// comment: EC/OC counts are always exactly equal per pose).
|
|
List<uint> ec = frame.Events
|
|
.Where(e => e.Kind == WalkOracleEventKind.EnvCellShell)
|
|
.Select(e => e.CellId!.Value).ToList();
|
|
List<uint> oc = frame.Events
|
|
.Where(e => e.Kind == WalkOracleEventKind.ObjectCellTurn)
|
|
.Select(e => e.CellId!.Value).ToList();
|
|
Assert.Equal(new HashSet<uint> { cell1.CellId, cell2.CellId }, ec.ToHashSet());
|
|
Assert.Equal(new HashSet<uint> { cell1.CellId, cell2.CellId }, oc.ToHashSet());
|
|
Assert.Equal(2, ec.Count);
|
|
Assert.Equal(2, oc.Count);
|
|
|
|
// No landblocks were published (the stub 1x1 landscape), so no
|
|
// LC/SC/BLD turns exist this frame — the transcript format for
|
|
// those three kinds is proven separately, against real retail
|
|
// data, by WalkOracleTraceTests.AllFixtures and
|
|
// WalkLandCellOrderTests.
|
|
Assert.DoesNotContain(frame.Events, e => e.Kind
|
|
is WalkOracleEventKind.LandCell or WalkOracleEventKind.SortCell
|
|
or WalkOracleEventKind.Building);
|
|
}
|
|
finally
|
|
{
|
|
Console.SetOut(originalOut);
|
|
RenderingDiagnostics.DumpWalkTranscriptEnabled = previous;
|
|
}
|
|
}
|
|
|
|
/// <summary>§11.2 B4: the offline signature diff, self-checked over a
|
|
/// synthetic pair — the SAME captured T2 transcript versus itself with
|
|
/// its own LAST event removed. Reuses <c>Collect_TranscriptFlagOn_…</c>'s
|
|
/// own capture rather than duplicating the walk drive.</summary>
|
|
[Fact]
|
|
public void SignatureDiff_ReportsTheExactRemovedEvent()
|
|
{
|
|
bool previous = RenderingDiagnostics.DumpWalkTranscriptEnabled;
|
|
RenderingDiagnostics.DumpWalkTranscriptEnabled = true;
|
|
TextWriter originalOut = Console.Out;
|
|
var capture = new StringWriter();
|
|
try
|
|
{
|
|
Console.SetOut(capture);
|
|
|
|
using var fx = new DispatcherFixture();
|
|
var ctx = new TestContext();
|
|
(WalkCell cell1, _) = BuildTranscriptFixtureCells(ctx);
|
|
var landscape = new WalkLandscape { MidWidth = 1, Blocks = new WalkLandBlock?[1] };
|
|
var worldData = new FakeWorldData();
|
|
var leaf = new RecordingLeafRenderer(new List<string>());
|
|
using ClipFrame clipFrame = ClipFrame.NoClip();
|
|
var driver = new WalkFrameDriver(fx.Dispatcher, leaf, worldData, clipFrame: clipFrame);
|
|
var walk = new RetailFrameWalk();
|
|
|
|
// Two Collect calls — see the round-trip test's own comment on
|
|
// why one alone parses to zero complete frames.
|
|
driver.Collect(
|
|
walk, cell1.CellId, cell1, landscape, ctx, Matrix4x4.Identity, Vector3.Zero);
|
|
driver.Collect(
|
|
walk, cell1.CellId, cell1, landscape, ctx, Matrix4x4.Identity, Vector3.Zero);
|
|
|
|
Console.Out.Flush();
|
|
string[] lines = capture.ToString()
|
|
.Split('\n', StringSplitOptions.RemoveEmptyEntries)
|
|
.Select(l => l.TrimEnd('\r'))
|
|
.ToArray();
|
|
|
|
IReadOnlyList<WalkOracleFrame> expected = WalkOracleTrace.Parse(lines);
|
|
WalkOracleFrame expectedFrame = Assert.Single(expected);
|
|
Assert.NotEmpty(expectedFrame.Events);
|
|
|
|
// Self-vs-self (unmutated copy): no divergence at all.
|
|
IReadOnlyList<WalkOracleFrame> unchanged =
|
|
[expectedFrame with { Events = expectedFrame.Events.ToList() }];
|
|
Assert.Null(WalkTranscriptSignatureDiff.FirstDivergence(expected, unchanged));
|
|
|
|
// Self-vs-self-minus-one (the LAST event removed): the reported
|
|
// divergence is exact — same frame number, position exactly at
|
|
// the new (shorter) end, expected = the removed event's own
|
|
// signature string, actual = "<end of frame>".
|
|
int lastIndex = expectedFrame.Events.Count - 1;
|
|
List<WalkOracleEvent> truncated = expectedFrame.Events.Take(lastIndex).ToList();
|
|
IReadOnlyList<WalkOracleFrame> actual =
|
|
[expectedFrame with { Events = truncated }];
|
|
|
|
WalkTranscriptSignatureDiff.Divergence? divergence =
|
|
WalkTranscriptSignatureDiff.FirstDivergence(expected, actual);
|
|
|
|
Assert.NotNull(divergence);
|
|
Assert.Equal(expectedFrame.Number, divergence!.Value.FrameNumber);
|
|
Assert.Equal(lastIndex, divergence.Value.Position);
|
|
Assert.Equal("<end of frame>", divergence.Value.Actual);
|
|
Assert.NotEqual("<end of frame>", divergence.Value.Expected);
|
|
}
|
|
finally
|
|
{
|
|
Console.SetOut(originalOut);
|
|
RenderingDiagnostics.DumpWalkTranscriptEnabled = previous;
|
|
}
|
|
}
|
|
}
|