ec1bbb4f43
Ports retail's ParticleEmitterInfo / Particle::Init / Particle::Update
(0x005170d0..0x0051d400) and PhysicsScript runtime to a C# data-layer
plus a Silk.NET billboard renderer. Sky-PES path is debug-only behind
ACDREAM_ENABLE_SKY_PES because named-retail decomp confirms GameSky
copies SkyObject.pes_id but never reads it (CreateDeletePhysicsObjects
0x005073c0, MakeObject 0x00506ee0, UseTime 0x005075b0).
Post-review fixes folded into this commit:
H1: AttachLocal (is_parent_local=1) follows live parent each frame.
ParticleSystem.UpdateEmitterAnchor + ParticleHookSink.UpdateEntityAnchor
let the owning subsystem refresh AnchorPos every tick — matches
ParticleEmitter::UpdateParticles 0x0051d2d4 which re-reads the live
parent frame when is_parent_local != 0. Drops the renderer-side
cameraOffset hack that only worked when the parent was the camera.
H3: Strip the long stale comment in GfxObjMesh.cs that contradicted the
retail-faithful (1 - translucency) opacity formula. The code was
right; the comment was a leftover from an earlier hypothesis and
would have invited a wrong "fix".
M1: SkyRenderer tracks textures whose wrap mode it set to ClampToEdge
and restores them to Repeat at end-of-pass, so non-sky renderers
that share the GL handle can't silently inherit clamped wrap state.
M2: Post-scene Z-offset (-120m) only fires when the SkyObject is
weather-flagged AND bit 0x08 is clear, matching retail
GameSky::UpdatePosition 0x00506dd0. The old code applied it to
every post-scene object — a no-op today (every Dereth post-scene
entry happens to be weather-flagged) but a future post-scene-only
sun rim would have been pushed below the camera.
M4: ParticleSystem.EmitterDied event lets ParticleHookSink prune dead
handles from the per-entity tracking dictionaries, fixing a slow
leak where naturally-expired emitters' handles stayed in the
ConcurrentBag forever during long sessions.
M5: SkyPesEntityId moves the post-scene flag bit to 0x08000000 so it
can't ever overlap the object-index range. Synthetic IDs stay in
the reserved 0xFxxxxxxx space.
New tests (ParticleSystemTests + ParticleHookSinkTests):
- UpdateEmitterAnchor_AttachLocal_ParticlePositionFollowsLiveAnchor
- UpdateEmitterAnchor_AttachLocalCleared_ParticleFrozenAtSpawnOrigin
- EmitterDied_FiresOncePerHandle_AfterAllParticlesExpire
- Birthrate_PerSec_EmitsOnePerTickWhenIntervalElapsed (retail-faithful
single-emit-per-frame behavior)
- UpdateEntityAnchor_WithAttachLocal_MovesParticleToLiveAnchor
- EmitterDied_PrunesPerEntityHandleTracking
dotnet build green, dotnet test green: 695 / 393 / 243 = 1331 passed
(up from 1325).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
106 lines
4.5 KiB
C#
106 lines
4.5 KiB
C#
using AcDream.Core.Meshing;
|
|
using DatReaderWriter.Enums;
|
|
|
|
namespace AcDream.Core.Tests.Meshing;
|
|
|
|
/// <summary>
|
|
/// Verifies the retail surface-state mapping used by the GL render split.
|
|
/// Priority order is:
|
|
/// Translucent+ClipMap override, Additive, InvAlpha, AlphaBlend, ClipMap, Opaque.
|
|
/// </summary>
|
|
public class TranslucencyKindTests
|
|
{
|
|
[Fact]
|
|
public void Opaque_FromZeroFlags_ReturnsOpaque()
|
|
=> Assert.Equal(TranslucencyKind.Opaque, TranslucencyKindExtensions.FromSurfaceType((SurfaceType)0));
|
|
|
|
[Fact]
|
|
public void Opaque_FromBase1SolidFlag_ReturnsOpaque()
|
|
=> Assert.Equal(TranslucencyKind.Opaque, TranslucencyKindExtensions.FromSurfaceType(SurfaceType.Base1Solid));
|
|
|
|
[Fact]
|
|
public void Opaque_FromBase1ImageFlag_ReturnsOpaque()
|
|
=> Assert.Equal(TranslucencyKind.Opaque, TranslucencyKindExtensions.FromSurfaceType(SurfaceType.Base1Image));
|
|
|
|
[Fact]
|
|
public void ClipMap_FromBase1ClipMapFlag_ReturnsClipMap()
|
|
=> Assert.Equal(TranslucencyKind.ClipMap, TranslucencyKindExtensions.FromSurfaceType(SurfaceType.Base1ClipMap));
|
|
|
|
[Fact]
|
|
public void ClipMap_WithOtherOpaqueFlags_ReturnsClipMap()
|
|
=> Assert.Equal(TranslucencyKind.ClipMap,
|
|
TranslucencyKindExtensions.FromSurfaceType(SurfaceType.Base1ClipMap | SurfaceType.Gouraud));
|
|
|
|
[Fact]
|
|
public void AlphaBlend_FromAlphaFlag_ReturnsAlphaBlend()
|
|
=> Assert.Equal(TranslucencyKind.AlphaBlend, TranslucencyKindExtensions.FromSurfaceType(SurfaceType.Alpha));
|
|
|
|
[Fact]
|
|
public void AlphaBlend_FromTranslucentFlag_ReturnsAlphaBlend()
|
|
=> Assert.Equal(TranslucencyKind.AlphaBlend, TranslucencyKindExtensions.FromSurfaceType(SurfaceType.Translucent));
|
|
|
|
[Fact]
|
|
public void AlphaBlend_FromAlphaAndTranslucentFlags_ReturnsAlphaBlend()
|
|
=> Assert.Equal(TranslucencyKind.AlphaBlend,
|
|
TranslucencyKindExtensions.FromSurfaceType(SurfaceType.Alpha | SurfaceType.Translucent));
|
|
|
|
[Fact]
|
|
public void AlphaBlend_AlphaWithClipMap_AlphaWins()
|
|
=> Assert.Equal(TranslucencyKind.AlphaBlend,
|
|
TranslucencyKindExtensions.FromSurfaceType(SurfaceType.Alpha | SurfaceType.Base1ClipMap));
|
|
|
|
[Fact]
|
|
public void AlphaBlend_TranslucentClipMapAdditiveCloud_ReturnsAlphaBlend()
|
|
=> Assert.Equal(TranslucencyKind.AlphaBlend,
|
|
TranslucencyKindExtensions.FromSurfaceType(
|
|
SurfaceType.Base1ClipMap
|
|
| SurfaceType.Translucent
|
|
| SurfaceType.Alpha
|
|
| SurfaceType.Additive));
|
|
|
|
[Fact]
|
|
public void InvAlpha_FromInvAlphaFlag_ReturnsInvAlpha()
|
|
=> Assert.Equal(TranslucencyKind.InvAlpha, TranslucencyKindExtensions.FromSurfaceType(SurfaceType.InvAlpha));
|
|
|
|
[Fact]
|
|
public void InvAlpha_InvAlphaBeatsAlpha()
|
|
=> Assert.Equal(TranslucencyKind.InvAlpha,
|
|
TranslucencyKindExtensions.FromSurfaceType(SurfaceType.InvAlpha | SurfaceType.Alpha));
|
|
|
|
[Fact]
|
|
public void Additive_FromAdditiveFlag_ReturnsAdditive()
|
|
=> Assert.Equal(TranslucencyKind.Additive, TranslucencyKindExtensions.FromSurfaceType(SurfaceType.Additive));
|
|
|
|
[Fact]
|
|
public void Additive_AdditiveBeatsNonTranslucentBlendFlags()
|
|
=> Assert.Equal(TranslucencyKind.Additive,
|
|
TranslucencyKindExtensions.FromSurfaceType(
|
|
SurfaceType.Additive | SurfaceType.InvAlpha | SurfaceType.Alpha | SurfaceType.Base1ClipMap));
|
|
|
|
[Fact]
|
|
public void OpacityFromSurfaceTranslucency_NonTranslucentIgnoresRawValue()
|
|
{
|
|
Assert.Equal(1f, TranslucencyKindExtensions.OpacityFromSurfaceTranslucency(SurfaceType.Base1Image, 0f));
|
|
Assert.Equal(1f, TranslucencyKindExtensions.OpacityFromSurfaceTranslucency(SurfaceType.Base1Image, 0.75f));
|
|
}
|
|
|
|
[Fact]
|
|
public void OpacityFromSurfaceTranslucency_TranslucentInvertsAndClamps()
|
|
{
|
|
Assert.Equal(1f, TranslucencyKindExtensions.OpacityFromSurfaceTranslucency(SurfaceType.Translucent, -0.25f));
|
|
Assert.Equal(0.75f, TranslucencyKindExtensions.OpacityFromSurfaceTranslucency(SurfaceType.Translucent, 0.25f));
|
|
Assert.Equal(0f, TranslucencyKindExtensions.OpacityFromSurfaceTranslucency(SurfaceType.Translucent, 1.25f));
|
|
}
|
|
|
|
[Fact]
|
|
public void DisablesFixedFunctionFog_RawAdditiveEvenWhenBlendForcedToAlpha()
|
|
{
|
|
var cloud = SurfaceType.Base1ClipMap
|
|
| SurfaceType.Translucent
|
|
| SurfaceType.Alpha
|
|
| SurfaceType.Additive;
|
|
|
|
Assert.Equal(TranslucencyKind.AlphaBlend, TranslucencyKindExtensions.FromSurfaceType(cloud));
|
|
Assert.True(TranslucencyKindExtensions.DisablesFixedFunctionFog(cloud));
|
|
}
|
|
}
|