Three-tier rollout per the 2026-04-25 retail @help dump showing the full ACE command surface. Tier 1 + most of Tier 2 in one commit. TIER 1 - @ as / equivalent ACE accepts both / and @ as verb prefixes (per its own help text: "Note: You may substitute a forward slash (/) for the at symbol (@)."). ChatInputParser now normalises @ to / for the verb-match phase and re-enters parsing. Critical: for verbs we don't recognise (@acehelp, @tele, @die, @version, @loc-on-server, @nonsense, ...), the original @ is kept in the message text so ACE's CommandManager intercepts the message server-side. If we substituted / there too, ACE would treat it as plain Talk and broadcast it. Result: @a hi / @tell Bob hi / @help / @clear / @reply / @retell all route exactly like their / counterparts. @acehelp / @tele / @version / @die etc. pass through to the server intact. TIER 2 - client-only commands - /retell <msg> (also @retell): resend to the last person you tell'd. Mirrors retail @retell. ChatVM tracks LastOutgoingTellTarget on each OnSelfSent(Tell, ...) entry — SenderGuid==0 distinguishes outgoing echo from inbound whispers, same way LastIncomingTellSender already worked. ChatInputParser takes a new optional lastOutgoingTellTarget param. - /framerate (also @framerate): prints "Framerate: 144.2 FPS" into chat. Wired via a new ChatVM.FpsProvider Func<float> callback set by GameWindow at construction (closes over _lastFps). Falls back to "(provider unavailable)" if no callback is wired (tests / pre-live). - /loc (also @loc): prints "Location: (123.4, 567.8, 60.0)" into chat. Wired via ChatVM.PositionProvider Func<Vector3> closing over GetDebugPlayerPosition() in GameWindow. ACE has a server- side @loc too; client wins here (instantaneous + uses the local interpolated position). ChatPanel.TryHandleClientCommand grew @ aliases for /help /clear /framerate /loc and the new EqAny helper for case-insensitive multi-string matching. Help text rewritten to reference the / <-> @ equivalence and point at @acehelp / @acecommands for ACE's full command list. TIER 3 - automatic (no code) Most retail @-commands (@allegiance motd, @afk, @die, @lifestone, @corpse, @marketplace, @pkarena, @emote/@emotes, @fillcomps, @permit, @consent, @squelch, @unsquelch, @messagetypes, @age, @birth, @day, @endurance, @pklite, @version, @filter, @unfilter, @loadfile, @log, @marketplace, ...) are server-side ACE commands. Tier 1's passthrough takes care of them automatically — they arrive via Talk, ACE recognises the @ and intercepts, replies via SystemChat (which our 0xF7E0 wiring renders as [System] lines). DEFERRED - @saveui / @loadui / @lockui: ImGui layout save/load, ~1 hr standalone task. Filed for follow-up. - @title <text>: rename chat window. ImGui window-id complications. - Toggle-style @framerate (FPS overlay on/off): print-once is simpler and matches retail's most-common usage. 30 new tests: - ChatInputParserAtPrefixTests: 11 covering @-prefix recognition, unknown-@ passthrough, /retell and @retell. - ChatVMRetellAndProvidersTests: 8 covering LastOutgoingTellTarget tracking, FpsProvider/PositionProvider callbacks, no-provider fallback. - ChatPanelInputTests: +3 (/framerate, @loc, @acehelp passthrough). Solution total: 1063 green (243 Core.Net + 160 UI + 660 Core), 0 warnings. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
110 lines
3.2 KiB
C#
110 lines
3.2 KiB
C#
using System.Numerics;
|
|
using AcDream.Core.Chat;
|
|
using AcDream.UI.Abstractions.Panels.Chat;
|
|
|
|
namespace AcDream.UI.Abstractions.Tests.Panels.Chat;
|
|
|
|
/// <summary>
|
|
/// Phase J Tier 2: <see cref="ChatVM"/> tracks the last OUTGOING tell
|
|
/// target (for <c>/retell</c>) and exposes optional FpsProvider /
|
|
/// PositionProvider callbacks the panel uses to render
|
|
/// <c>/framerate</c> and <c>/loc</c> client-side commands without
|
|
/// reaching into render-loop state.
|
|
/// </summary>
|
|
public sealed class ChatVMRetellAndProvidersTests
|
|
{
|
|
[Fact]
|
|
public void LastOutgoingTellTarget_StartsNull()
|
|
{
|
|
var log = new ChatLog();
|
|
var vm = new ChatVM(log);
|
|
Assert.Null(vm.LastOutgoingTellTarget);
|
|
}
|
|
|
|
[Fact]
|
|
public void OnSelfSentTell_PopulatesLastOutgoingTellTarget()
|
|
{
|
|
var log = new ChatLog();
|
|
var vm = new ChatVM(log);
|
|
|
|
log.OnSelfSent(ChatKind.Tell, "hi there", targetOrChannel: "Caith");
|
|
|
|
Assert.Equal("Caith", vm.LastOutgoingTellTarget);
|
|
// Inbound-tell tracker must NOT pick up an outgoing echo —
|
|
// the SenderGuid==0 discriminator separates the two paths.
|
|
Assert.Null(vm.LastIncomingTellSender);
|
|
}
|
|
|
|
[Fact]
|
|
public void IncomingTell_DoesNotTouchOutgoingTarget()
|
|
{
|
|
var log = new ChatLog();
|
|
var vm = new ChatVM(log);
|
|
|
|
log.OnTellReceived("Bestie", "psst", senderGuid: 0x5000_0042);
|
|
|
|
Assert.Equal("Bestie", vm.LastIncomingTellSender);
|
|
Assert.Null(vm.LastOutgoingTellTarget);
|
|
}
|
|
|
|
[Fact]
|
|
public void OutgoingThenIncoming_TracksBothIndependently()
|
|
{
|
|
var log = new ChatLog();
|
|
var vm = new ChatVM(log);
|
|
|
|
log.OnSelfSent(ChatKind.Tell, "hi", targetOrChannel: "Caith");
|
|
log.OnTellReceived("Bestie", "psst", senderGuid: 0x5000_0042);
|
|
|
|
Assert.Equal("Caith", vm.LastOutgoingTellTarget);
|
|
Assert.Equal("Bestie", vm.LastIncomingTellSender);
|
|
}
|
|
|
|
[Fact]
|
|
public void ShowFps_WithProvider_AppendsFormattedLine()
|
|
{
|
|
var log = new ChatLog();
|
|
var vm = new ChatVM(log) { FpsProvider = () => 144.2f };
|
|
|
|
vm.ShowFps();
|
|
|
|
var entry = Assert.Single(log.Snapshot());
|
|
Assert.Equal(ChatKind.System, entry.Kind);
|
|
Assert.Equal("Framerate: 144.2 FPS", entry.Text);
|
|
}
|
|
|
|
[Fact]
|
|
public void ShowFps_NoProvider_StillProducesDiagnosticLine()
|
|
{
|
|
var log = new ChatLog();
|
|
var vm = new ChatVM(log);
|
|
|
|
vm.ShowFps();
|
|
|
|
var entry = Assert.Single(log.Snapshot());
|
|
Assert.Contains("provider unavailable", entry.Text);
|
|
}
|
|
|
|
[Fact]
|
|
public void ShowLocation_WithProvider_AppendsFormattedLine()
|
|
{
|
|
var log = new ChatLog();
|
|
var vm = new ChatVM(log) { PositionProvider = () => new Vector3(123.4f, 567.8f, 60f) };
|
|
|
|
vm.ShowLocation();
|
|
|
|
var entry = Assert.Single(log.Snapshot());
|
|
Assert.Equal("Location: (123.4, 567.8, 60.0)", entry.Text);
|
|
}
|
|
|
|
[Fact]
|
|
public void ShowLocation_NoProvider_StillProducesDiagnosticLine()
|
|
{
|
|
var log = new ChatLog();
|
|
var vm = new ChatVM(log);
|
|
|
|
vm.ShowLocation();
|
|
|
|
Assert.Contains("provider unavailable", log.Snapshot()[0].Text);
|
|
}
|
|
}
|