using AcDream.Core.CharGen; namespace AcDream.Core.Tests.CharGen; /// /// Hand-built-fixture tests for . /// Real installed-DAT coverage (every heritage/gender's default selection, /// verifying no missing PalSet/ClothingTable ids) lives in /// AcDream.Content.Tests.CharGen.ChargenAppearanceCatalogInstalledDatTests. /// public sealed class ChargenAppearanceFactoryTests { private const uint HeritageId = 1u; private const int GenderKey = 1; private const uint BodySetupId = 0x0200_0001u; private const uint AlternateBodySetupId = 0x0200_00FFu; private const uint BasePaletteId = 0x0400_0001u; private const uint SkinPalSetId = 0x0F00_0001u; private const uint HairColorPalSetId = 0x0F00_0002u; private const uint EyeColorPaletteId = 0x0400_0099u; // direct palette id, no PalSet indirection. private const uint HeadgearClothingTableId = 0x1900_0001u; private const uint TrousersClothingTableId = 0x1900_0002u; private const uint ShirtClothingTableId = 0x1900_0003u; private const uint FootwearClothingTableId = 0x1900_0004u; private static ChargenObjDesc MakeObjDesc(uint tag) => new( 0u, [], [new ChargenTextureChange((byte)tag, 0x0500_0000u + tag, 0x0500_1000u + tag)], [new ChargenAnimPartChange((byte)tag, 0x0100_0000u + tag)]); private static ChargenGenderOptions MakeGender(uint alternateHairSetup = 0u, bool baldHairStyle = false) => new( GenderKey: GenderKey, Name: "Male", Scale: 100u, SetupId: BodySetupId, SoundTableId: 0x0900_0001u, IconId: 0x0600_0001u, BasePaletteId: BasePaletteId, SkinPalSetId: SkinPalSetId, PhysicsTableId: 0x0D00_0001u, MotionTableId: 0x0900_0002u, CombatTableId: 0x0000_0001u, BaseObjDesc: MakeObjDesc(0), HairColors: [HairColorPalSetId], HairStyles: [ new ChargenHairStyle(0x0600_0002u, baldHairStyle, alternateHairSetup, MakeObjDesc(1)), ], EyeColors: [EyeColorPaletteId], EyeStrips: [ new ChargenEyeStrip(0x0600_0003u, 0x0600_0004u, MakeObjDesc(2), MakeObjDesc(20)), ], NoseStrips: [new ChargenFaceStrip(0x0600_0005u, MakeObjDesc(3))], MouthStrips: [new ChargenFaceStrip(0x0600_0006u, MakeObjDesc(4))], Headgears: [new ChargenGearOption("Cap", HeadgearClothingTableId, 0x3000_0001u)], Shirts: [new ChargenGearOption("Shirt", ShirtClothingTableId, 0x3000_0002u)], Pants: [new ChargenGearOption("Pants", TrousersClothingTableId, 0x3000_0003u)], Footwear: [new ChargenGearOption("Boots", FootwearClothingTableId, 0x3000_0004u)], ClothingColors: [7u]); private static ChargenOptions MakeOptions(ChargenGenderOptions gender) { var heritage = new ChargenHeritageOptions( HeritageId, "Test", 0x0600_0001u, BodySetupId, BodySetupId, 180u, 100u, [0], [], new Dictionary(), [], new Dictionary { [GenderKey] = gender }); return new ChargenOptions( [], new Dictionary { [HeritageId] = heritage }, new Dictionary()); } /// One dye choice per clothing table: palette-template id 7, /// one PalSet, one range (real units 80/16 → packed (10,2)). private static ChargenClothingTable MakeClothingTable(uint clothingTableId, uint palSetId, uint bodySetupId) { var partChanges = new[] { new ChargenAnimPartChange(5, 0x0100_5000u + clothingTableId) }; var textureChanges = new[] { new ChargenTextureChange(5, 0x0500_5000u, 0x0500_6000u) }; var baseEffects = new Dictionary { [bodySetupId] = new ChargenClothingBaseEffect(partChanges, textureChanges), }; var choice = new ChargenClothingSubPaletteChoice( palSetId, [new ChargenClothingSubPaletteRange(80u, 16u)]); var templates = new Dictionary { [7u] = new ChargenClothingPaletteTemplate([choice]), }; return new ChargenClothingTable(baseEffects, templates); } private sealed class FakePalSetSource : IChargenPalSetSource { private readonly Dictionary _sets = new(); public void Add(uint id, params uint[] paletteIds) => _sets[id] = new ChargenPalSet(paletteIds); public ChargenPalSet? TryGetPalSet(uint palSetId) => _sets.TryGetValue(palSetId, out var s) ? s : null; } private sealed class FakeClothingTableSource : IChargenClothingTableSource { private readonly Dictionary _tables = new(); public void Add(uint id, ChargenClothingTable table) => _tables[id] = table; public ChargenClothingTable? TryGetClothingTable(uint clothingTableId) => _tables.TryGetValue(clothingTableId, out var t) ? t : null; } private static (FakePalSetSource pal, FakeClothingTableSource clothing) MakeSources(uint bodySetupId = BodySetupId) { var pal = new FakePalSetSource(); pal.Add(SkinPalSetId, 0x0400_0010u, 0x0400_0011u, 0x0400_0012u); pal.Add(HairColorPalSetId, 0x0400_0020u, 0x0400_0021u); var clothingDyePalSetId = 0x0F00_0003u; pal.Add(clothingDyePalSetId, 0x0400_0030u, 0x0400_0031u); var clothing = new FakeClothingTableSource(); clothing.Add(HeadgearClothingTableId, MakeClothingTable(HeadgearClothingTableId, clothingDyePalSetId, bodySetupId)); clothing.Add(TrousersClothingTableId, MakeClothingTable(TrousersClothingTableId, clothingDyePalSetId, bodySetupId)); clothing.Add(ShirtClothingTableId, MakeClothingTable(ShirtClothingTableId, clothingDyePalSetId, bodySetupId)); clothing.Add(FootwearClothingTableId, MakeClothingTable(FootwearClothingTableId, clothingDyePalSetId, bodySetupId)); return (pal, clothing); } [Fact] public void TryCompose_ReturnsFalse_WhenHeritageIsUnknown() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); bool ok = ChargenAppearanceFactory.TryCompose( options, heritageId: 999u, GenderKey, ChargenAppearanceSelection.Default, pal, clothing, out _); Assert.False(ok); } [Fact] public void TryCompose_ReturnsFalse_WhenGenderIsUnknown() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); bool ok = ChargenAppearanceFactory.TryCompose( options, HeritageId, genderKey: 999, ChargenAppearanceSelection.Default, pal, clothing, out _); Assert.False(ok); } [Fact] public void TryCompose_DefaultSelection_ResolvesBodySetupAndUnconditionalSkinSubpalette() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); bool ok = ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, ChargenAppearanceSelection.Default, pal, clothing, out ChargenAppearanceResult result); Assert.True(ok); Assert.Equal(BodySetupId, result.SetupId); Assert.Equal(BasePaletteId, result.BasePaletteId); Assert.Empty(result.MissingPalSetIds); Assert.Empty(result.MissingClothingTableIds); // UnsetShade (-1.0) is out of [0,1], so GetPaletteIndex returns -1 and // the skin block is skipped for THIS test's default selection — the // "unconditional" behavior is that the block always RUNS (always // attempts the PalSet lookup), not that it always emits an entry. Assert.DoesNotContain(result.ObjDesc.SubPalettes, sp => sp.Offset == 0); // Base body's own ObjDesc still lands (tag 0's texture/anim change). Assert.Contains(result.ObjDesc.AnimPartChanges, c => c.PartIndex == 0); } [Fact] public void TryCompose_SkinShadeSelected_EmitsSkinSubpaletteAtPackedOffsetZeroCountTwentyFour() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); var selection = ChargenAppearanceSelection.Default with { SkinShade = 0.5 }; ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); ChargenSubPalette skin = Assert.Single(result.ObjDesc.SubPalettes, sp => sp.Offset == 0 && sp.NumColors == 24); Assert.Equal(0x0400_0011u, skin.SubPaletteId); // index 1 of 3 at shade 0.5. } [Fact] public void TryCompose_HairColorSelected_EmitsHairSubpaletteAtPackedOffsetTwentyFourCountEight() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); var selection = ChargenAppearanceSelection.Default with { HairColor = 0u, HairShade = 1.0 }; ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); ChargenSubPalette hair = Assert.Single(result.ObjDesc.SubPalettes, sp => sp.Offset == 24 && sp.NumColors == 8); Assert.Equal(0x0400_0021u, hair.SubPaletteId); // last of the two at shade 1.0. } [Fact] public void TryCompose_EyeColorSelected_UsesRawPaletteIdDirectlyNoShadeIndirection() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); var selection = ChargenAppearanceSelection.Default with { EyeColor = 0u }; ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); ChargenSubPalette eye = Assert.Single(result.ObjDesc.SubPalettes, sp => sp.Offset == 32 && sp.NumColors == 8); Assert.Equal(EyeColorPaletteId, eye.SubPaletteId); } [Fact] public void TryCompose_HairStyleSelected_AppendsHairObjDescAfterBase() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); var selection = ChargenAppearanceSelection.Default with { HairStyle = 0u }; ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); Assert.Equal(0u, (uint)result.ObjDesc.AnimPartChanges[0].PartIndex); // base first. Assert.Contains(result.ObjDesc.AnimPartChanges, c => c.PartIndex == 1); // hair style second. } [Fact] public void TryCompose_HairStyleWithAlternateSetup_OverridesBodySetupId() { ChargenOptions options = MakeOptions(MakeGender(alternateHairSetup: AlternateBodySetupId)); var (pal, clothing) = MakeSources(bodySetupId: AlternateBodySetupId); var selection = ChargenAppearanceSelection.Default with { HairStyle = 0u }; ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); Assert.Equal(AlternateBodySetupId, result.SetupId); } [Fact] public void TryCompose_BothSetupSourcesZero_FallsBackToHumanSetupId() { ChargenGenderOptions gender = MakeGender() with { SetupId = 0u }; ChargenOptions options = MakeOptions(gender); var (pal, clothing) = MakeSources(bodySetupId: 0u); ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, ChargenAppearanceSelection.Default, pal, clothing, out ChargenAppearanceResult result); Assert.Equal(ChargenAppearanceFactory.HumanSetupId, result.SetupId); } /// /// CC6a review fix round F1: retail's "unset" sentinel for a Setup id is /// INVALID_DID (0xFFFFFFFF — CharGenState::GetSetupID @ /// 0x005C5B22), not 0. A hair style whose AlternateSetup field /// stores 0xFFFFFFFF must NOT be adopted as the body Setup id — before /// this fix the factory would hand 0xFFFFFFFF straight to a caller's /// Get<Setup>, which nulls, and the whole preview build /// would fail silently. /// [Fact] public void TryCompose_HairStyleAlternateSetupIsInvalidDid_IsTreatedAsUnsetNotAdopted() { ChargenOptions options = MakeOptions(MakeGender(alternateHairSetup: 0xFFFFFFFFu)); var (pal, clothing) = MakeSources(); var selection = ChargenAppearanceSelection.Default with { HairStyle = 0u }; ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); Assert.Equal(BodySetupId, result.SetupId); // gender.SetupId, NOT the INVALID_DID sentinel. } /// /// Companion to : /// the resolved Setup id can ALSO be stuck at INVALID_DID (rather than 0) /// when the gender's own SetupId dat field happens to be /// 0xFFFFFFFF — the fallback to /// must catch that case too. /// [Fact] public void TryCompose_GenderSetupIdIsInvalidDid_FallsBackToHumanSetupId() { ChargenGenderOptions gender = MakeGender() with { SetupId = 0xFFFFFFFFu }; ChargenOptions options = MakeOptions(gender); var (pal, clothing) = MakeSources(bodySetupId: 0xFFFFFFFFu); ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, ChargenAppearanceSelection.Default, pal, clothing, out ChargenAppearanceResult result); Assert.Equal(ChargenAppearanceFactory.HumanSetupId, result.SetupId); } /// /// CC6b MUST-COVER item 4 — alternateSetupIdOverride (retail's /// m_alternateSetupID) must WIN outright over the hairstyle's own /// AlternateSetup when both are supplied, matching /// gmCG3DView::Update's replace-not-combine precedence /// (~0x004EEA46-0x004EEA53). /// [Fact] public void TryCompose_AlternateSetupIdOverride_WinsOverHairStyleAlternateSetup() { const uint hairStyleSetup = 0x0200_00AAu; const uint pageLevelOverride = 0x0200_00BBu; ChargenOptions options = MakeOptions(MakeGender(alternateHairSetup: hairStyleSetup)); var (pal, clothing) = MakeSources(bodySetupId: pageLevelOverride); var selection = ChargenAppearanceSelection.Default with { HairStyle = 0u }; ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result, alternateSetupIdOverride: pageLevelOverride); Assert.Equal(pageLevelOverride, result.SetupId); } /// /// Companion: with NO hair style selected at all (so there is nothing for /// the page-level override to out-rank), the override still replaces the /// plain gender.SetupId. /// [Fact] public void TryCompose_AlternateSetupIdOverride_WinsOverPlainGenderSetupId() { const uint pageLevelOverride = 0x0200_00CCu; ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(bodySetupId: pageLevelOverride); ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, ChargenAppearanceSelection.Default, pal, clothing, out ChargenAppearanceResult result, alternateSetupIdOverride: pageLevelOverride); Assert.Equal(pageLevelOverride, result.SetupId); } /// /// The default (no override supplied) call shape is unaffected — proves /// the new trailing parameter is additive, not a behavior change for /// every existing caller. /// [Fact] public void TryCompose_NoAlternateSetupIdOverrideSupplied_ResolvesAsBefore() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, ChargenAppearanceSelection.Default, pal, clothing, out ChargenAppearanceResult result); Assert.Equal(BodySetupId, result.SetupId); } /// /// An override equal to retail's INVALID_DID sentinel means "no /// override" (the field's own default), not "adopt 0xFFFFFFFF as the /// Setup id" — same sentinel discipline as the hairstyle source (F1). /// [Fact] public void TryCompose_AlternateSetupIdOverrideIsInvalidDid_IsTreatedAsNoOverride() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, ChargenAppearanceSelection.Default, pal, clothing, out ChargenAppearanceResult result, alternateSetupIdOverride: 0xFFFFFFFFu); Assert.Equal(BodySetupId, result.SetupId); } [Fact] public void TryCompose_EyeStripSelected_UsesNonBaldObjDesc_WhenHairStyleIsNotBald() { ChargenOptions options = MakeOptions(MakeGender(baldHairStyle: false)); var (pal, clothing) = MakeSources(); var selection = ChargenAppearanceSelection.Default with { HairStyle = 0u, EyesStrip = 0u }; ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); // tag 2 = non-bald eye ObjDesc, tag 20 = bald eye ObjDesc. Assert.Contains(result.ObjDesc.AnimPartChanges, c => c.PartId == 0x0100_0002u); Assert.DoesNotContain(result.ObjDesc.AnimPartChanges, c => c.PartId == 0x0100_0014u); } [Fact] public void TryCompose_EyeStripSelected_UsesBaldObjDesc_WhenHairStyleIsBald() { ChargenOptions options = MakeOptions(MakeGender(baldHairStyle: true)); var (pal, clothing) = MakeSources(); var selection = ChargenAppearanceSelection.Default with { HairStyle = 0u, EyesStrip = 0u }; ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); Assert.Contains(result.ObjDesc.AnimPartChanges, c => c.PartId == 0x0100_0014u); // tag 20, bald. Assert.DoesNotContain(result.ObjDesc.AnimPartChanges, c => c.PartId == 0x0100_0002u); // tag 2, non-bald. } [Fact] public void TryCompose_NoseAndMouthStripsSelected_AppendBothObjDescs() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); var selection = ChargenAppearanceSelection.Default with { NoseStrip = 0u, MouthStrip = 0u }; ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); Assert.Contains(result.ObjDesc.AnimPartChanges, c => c.PartIndex == 3); // nose tag. Assert.Contains(result.ObjDesc.AnimPartChanges, c => c.PartIndex == 4); // mouth tag. } [Fact] public void TryCompose_AllFourClothingSlotsSelected_AppearInRetailOrderHeadgearTrousersShirtFootwear() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); var selection = ChargenAppearanceSelection.Default with { HeadgearStyle = 0u, TrousersStyle = 0u, ShirtStyle = 0u, FootwearStyle = 0u, }; ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); // Only the base body's own tag (PartIndex 0) and the four clothing // slots' PartIndex-5 overrides are present (no hair style/strips // selected) — asserting the full ordered sequence pins retail's // Headgear → Trousers → Shirt → Footwear append order directly. uint[] expectedPartIds = [ 0x0100_0000u, // base body tag. 0x0100_5000u + HeadgearClothingTableId, 0x0100_5000u + TrousersClothingTableId, 0x0100_5000u + ShirtClothingTableId, 0x0100_5000u + FootwearClothingTableId, ]; Assert.Equal(expectedPartIds, result.ObjDesc.AnimPartChanges.Select(c => c.PartId).ToArray()); } [Fact] public void TryCompose_ClothingSlotWithColor_EmitsPartTextureAndDyeSubpalette() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); var selection = ChargenAppearanceSelection.Default with { HeadgearStyle = 0u, HeadgearColor = 0u, // gender.ClothingColors[0] = 7u == the fixture's palette-template key. HeadgearShade = 0.0, }; ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); Assert.Contains(result.ObjDesc.AnimPartChanges, c => c.PartId == 0x0100_5000u + HeadgearClothingTableId); Assert.Contains(result.ObjDesc.TextureChanges, c => c.PartIndex == 5 && c.NewTextureId == 0x0500_6000u); // Real range (80, 16) packed by /8 => (10, 2). Assert.Contains(result.ObjDesc.SubPalettes, sp => sp.Offset == 10 && sp.NumColors == 2); } [Fact] public void TryCompose_ClothingSlotWithoutColor_SkipsDyeSubpaletteButKeepsPartTextureChanges() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); var selection = ChargenAppearanceSelection.Default with { HeadgearStyle = 0u }; ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); Assert.Contains(result.ObjDesc.AnimPartChanges, c => c.PartId == 0x0100_5000u + HeadgearClothingTableId); Assert.DoesNotContain(result.ObjDesc.SubPalettes, sp => sp.Offset == 10 && sp.NumColors == 2); } /// /// CC6a review fix round F8: retail's inner subpalette loop /// (ClothingTable::BuildObjDesc ~0x005A7B24-0x005A7BD3) returns 0 /// IMMEDIATELY when a PalSet read fails for one choice (~0x005A7B32), /// aborting every REMAINING choice in that garment's palette template — /// not merely skipping the failed one and continuing. A two-choice /// template with the FIRST choice's PalSet missing must therefore emit /// NEITHER choice's subpalette, even though the second choice's own /// PalSet is present and would resolve fine on its own. /// [Fact] public void TryCompose_PalSetMissingMidLoop_AbortsRemainingChoicesInThatGarment() { const uint missingPalSetId = 0x0F00_00AAu; const uint presentPalSetId = 0x0F00_00BBu; var firstChoice = new ChargenClothingSubPaletteChoice( missingPalSetId, [new ChargenClothingSubPaletteRange(80u, 16u)]); var secondChoice = new ChargenClothingSubPaletteChoice( presentPalSetId, [new ChargenClothingSubPaletteRange(160u, 8u)]); var baseEffects = new Dictionary { [BodySetupId] = ChargenClothingBaseEffect.Empty, }; var templates = new Dictionary { [7u] = new ChargenClothingPaletteTemplate([firstChoice, secondChoice]), }; var table = new ChargenClothingTable(baseEffects, templates); ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); clothing.Add(HeadgearClothingTableId, table); // override the shared fixture's single-choice table. pal.Add(presentPalSetId, 0x0400_0055u); // deliberately NOT adding missingPalSetId. var selection = ChargenAppearanceSelection.Default with { HeadgearStyle = 0u, HeadgearColor = 0u, HeadgearShade = 0.0, }; bool ok = ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); Assert.True(ok); Assert.Contains(missingPalSetId, result.MissingPalSetIds); // Real range (160, 8) would pack to (20, 1) if the second choice were // (incorrectly) still applied after the first choice's miss. Assert.DoesNotContain(result.ObjDesc.SubPalettes, sp => sp.Offset == 20 && sp.NumColors == 1); // Nothing from EITHER choice's own range landed. Assert.DoesNotContain(result.ObjDesc.SubPalettes, sp => sp.Offset == 10 && sp.NumColors == 2); } /// /// CC6a review fix round F10: a real dat NumColors of exactly /// 2048 (256*8) is retail's own "whole palette" value spelled out in /// real units — it packs to the byte 0 sentinel /// ('s documented /// "Length=0 means entire palette") EXPLICITLY, not via an unchecked /// narrowing coincidence. /// [Fact] public void TryCompose_ClothingRangeNumColorsIsWholePaletteSentinel_PacksToZeroExplicitly() { var choice = new ChargenClothingSubPaletteChoice( 0x0F00_0003u, [new ChargenClothingSubPaletteRange(0u, 2048u)]); var baseEffects = new Dictionary { [BodySetupId] = ChargenClothingBaseEffect.Empty, }; var table = new ChargenClothingTable( baseEffects, new Dictionary { [7u] = new([choice]) }); ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); clothing.Add(HeadgearClothingTableId, table); var selection = ChargenAppearanceSelection.Default with { HeadgearStyle = 0u, HeadgearColor = 0u, HeadgearShade = 0.0, }; ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); Assert.Contains(result.ObjDesc.SubPalettes, sp => sp.Offset == 0 && sp.NumColors == 0); } /// /// CC6a review fix round F10: a shape the packed *8 byte convention /// cannot represent losslessly (not a multiple of 8, and not the 2048 /// whole-palette sentinel) must THROW rather than silently truncate via /// an unchecked (byte) cast. /// [Fact] public void TryCompose_ClothingRangeDoesNotFitThePackedByteConvention_Throws() { var choice = new ChargenClothingSubPaletteChoice( 0x0F00_0003u, [new ChargenClothingSubPaletteRange(0u, 2041u)]); // not a multiple of 8, not 2048. var baseEffects = new Dictionary { [BodySetupId] = ChargenClothingBaseEffect.Empty, }; var table = new ChargenClothingTable( baseEffects, new Dictionary { [7u] = new([choice]) }); ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); clothing.Add(HeadgearClothingTableId, table); var selection = ChargenAppearanceSelection.Default with { HeadgearStyle = 0u, HeadgearColor = 0u, HeadgearShade = 0.0, }; Assert.Throws(() => ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out _)); } [Fact] public void TryCompose_UnknownClothingTableId_IsRecordedAsMissingAndSkipped() { ChargenGenderOptions gender = MakeGender(); gender = gender with { Headgears = [new ChargenGearOption("Missing", 0x1900_00FFu, 0x3000_0099u)], }; ChargenOptions options = MakeOptions(gender); var (pal, clothing) = MakeSources(); var selection = ChargenAppearanceSelection.Default with { HeadgearStyle = 0u }; bool ok = ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); Assert.True(ok); Assert.Contains(0x1900_00FFu, result.MissingClothingTableIds); Assert.DoesNotContain(result.ObjDesc.AnimPartChanges, c => c.PartIndex == 5); } [Fact] public void TryCompose_UnknownHairColorPalSetId_IsRecordedAsMissingAndSkipped() { ChargenGenderOptions gender = MakeGender() with { HairColors = [0x0F00_00FFu] }; ChargenOptions options = MakeOptions(gender); var (pal, clothing) = MakeSources(); var selection = ChargenAppearanceSelection.Default with { HairColor = 0u, HairShade = 0.5 }; bool ok = ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); Assert.True(ok); Assert.Contains(0x0F00_00FFu, result.MissingPalSetIds); Assert.DoesNotContain(result.ObjDesc.SubPalettes, sp => sp.Offset == 24); } [Fact] public void TryCompose_BodySetupAbsentFromClothingBaseEffects_IsRecordedButDoesNotThrow() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(bodySetupId: 0x0200_DEADu); // different from the resolved body setup. var selection = ChargenAppearanceSelection.Default with { HeadgearStyle = 0u }; bool ok = ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); Assert.True(ok); Assert.Contains(HeadgearClothingTableId, result.ClothingTablesMissingBaseEffectForSetup); Assert.DoesNotContain(result.ObjDesc.AnimPartChanges, c => c.PartIndex == 5); } [Fact] public void TryCompose_OutOfRangeStyleIndex_IsTreatedAsUnselected() { ChargenOptions options = MakeOptions(MakeGender()); var (pal, clothing) = MakeSources(); var selection = ChargenAppearanceSelection.Default with { HairStyle = 999u, EyesStrip = 999u }; bool ok = ChargenAppearanceFactory.TryCompose( options, HeritageId, GenderKey, selection, pal, clothing, out ChargenAppearanceResult result); Assert.True(ok); Assert.DoesNotContain(result.ObjDesc.AnimPartChanges, c => c.PartIndex == 1); Assert.DoesNotContain(result.ObjDesc.AnimPartChanges, c => c.PartIndex == 2); } }