feat(net): #18 holtburger inbound chat parity - EmoteText, SoulEmote, ServerMessage, PlayerKilled, WeenieError + Windows-1252 codec
Five sub-changes:
1. Windows-1252 codec switch (global). Every Encoding.ASCII call site
in src/AcDream.Core.Net/Messages/ -> Encoding.GetEncoding(1252).
Touched HearSpeech, ChatRequests, GameEvents, AppraiseInfoParser,
CharacterList, CreateObject, PlayerDescriptionParser, SocialActions.
New Encodings.cs module-init registers CodePagesEncodingProvider
(System.Text.Encoding.CodePages ships with .NET 10 SDK but isn't
auto-registered). Matches retail + holtburger; accented names
no longer round-trip-broken.
2. New parsers (opcodes confirmed against holtburger opcodes.rs):
- EmoteText (0x01E0) { u32 senderGuid, string16 senderName, string16 text }
- SoulEmote (0x01E2) same wire layout as EmoteText
- ServerMessage (0xF7E0) { string16 message, u32 chatType }
- PlayerKilled (0x019E) { string16 deathMessage, u32 victimGuid, u32 killerGuid }
Shared StringReader.cs has the CP1252 String16L primitive.
3. WorldSession dispatch. ProcessDatagram adds branches for the four
new top-level opcodes + fires session-level events (EmoteHeard,
SoulEmoteHeard, ServerMessageReceived, PlayerKilledReceived).
0x0295 SetTurbineChatChannels stubbed with TODO for parallel I.6.
4. GameEventWiring routes WeenieError + WeenieErrorWithString
(parsers existed but were unrouted) -> chat.OnWeenieError.
5. ChatLog adapters: Emote / SoulEmote ChatKind values, OnEmote,
OnSoulEmote, OnPlayerKilled, OnWeenieError. OnLocalSpeech now
substitutes empty sender -> "You" per holtburger client/messages.rs.
ChatVM.FormatEntry handles new kinds (asterisk + sender + text).
22 new tests covering parser round-trips + reject-bad-opcode +
ChatLog adapter coverage + Win-1252 round-trip with non-ASCII chars.
Solution total: 881 green (210->225 in Core.Net.Tests, 606->613 in Core.Tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
b131514d51
commit
ff5ed9ec0b
25 changed files with 899 additions and 10 deletions
|
|
@ -109,6 +109,38 @@ public sealed class WorldSession : IDisposable
|
|||
/// </summary>
|
||||
public event Action<HearSpeech.Parsed>? SpeechHeard;
|
||||
|
||||
/// <summary>
|
||||
/// Phase I.5: fires when an <c>EmoteText (0x01E0)</c> top-level
|
||||
/// GameMessage is received — server-driven third-person emote
|
||||
/// announcement (e.g. "The Olthoi growls at you."). Standalone
|
||||
/// GameMessage, NOT wrapped in 0xF7B0. Subscribers typically feed
|
||||
/// <c>ChatLog.OnEmote</c>.
|
||||
/// </summary>
|
||||
public event Action<EmoteText.Parsed>? EmoteHeard;
|
||||
|
||||
/// <summary>
|
||||
/// Phase I.5: fires when a <c>SoulEmote (0x01E2)</c> top-level
|
||||
/// GameMessage is received — complex emote with optional animation
|
||||
/// pairing. Wire layout matches EmoteText.
|
||||
/// </summary>
|
||||
public event Action<SoulEmote.Parsed>? SoulEmoteHeard;
|
||||
|
||||
/// <summary>
|
||||
/// Phase I.5: fires when a <c>ServerMessage (0xF7E0)</c> top-level
|
||||
/// GameMessage is received — general server-broadcast text used
|
||||
/// for announcements, combat logs, and routine error messages.
|
||||
/// Subscribers typically feed <c>ChatLog.OnSystemMessage</c>.
|
||||
/// </summary>
|
||||
public event Action<ServerMessage.Parsed>? ServerMessageReceived;
|
||||
|
||||
/// <summary>
|
||||
/// Phase I.5: fires when a <c>PlayerKilled (0x019E)</c> top-level
|
||||
/// GameMessage is received — server announcement that a player
|
||||
/// was killed in combat. Subscribers typically feed
|
||||
/// <c>ChatLog.OnPlayerKilled</c>.
|
||||
/// </summary>
|
||||
public event Action<PlayerKilled.Parsed>? PlayerKilledReceived;
|
||||
|
||||
/// <summary>
|
||||
/// Issue #5: fires when a <c>PrivateUpdateVital (0x02E7)</c> arrives
|
||||
/// — full per-vital snapshot (ranks / start / xp / current).
|
||||
|
|
@ -615,6 +647,47 @@ public sealed class WorldSession : IDisposable
|
|||
if (parsed is not null)
|
||||
SpeechHeard?.Invoke(parsed.Value);
|
||||
}
|
||||
else if (op == EmoteText.Opcode)
|
||||
{
|
||||
// Phase I.5: server-driven third-person emote
|
||||
// ("The Olthoi growls at you."). Standalone GameMessage,
|
||||
// not wrapped in 0xF7B0. Holtburger opcodes.rs:155.
|
||||
var parsed = EmoteText.TryParse(body);
|
||||
if (parsed is not null)
|
||||
EmoteHeard?.Invoke(parsed.Value);
|
||||
}
|
||||
else if (op == SoulEmote.Opcode)
|
||||
{
|
||||
// Phase I.5: complex emote (chat + paired animation).
|
||||
// Wire layout identical to EmoteText. Holtburger
|
||||
// opcodes.rs:158.
|
||||
var parsed = SoulEmote.TryParse(body);
|
||||
if (parsed is not null)
|
||||
SoulEmoteHeard?.Invoke(parsed.Value);
|
||||
}
|
||||
else if (op == ServerMessage.Opcode)
|
||||
{
|
||||
// Phase I.5: server announcement / system message.
|
||||
// Holtburger opcodes.rs:167.
|
||||
var parsed = ServerMessage.TryParse(body);
|
||||
if (parsed is not null)
|
||||
ServerMessageReceived?.Invoke(parsed.Value);
|
||||
}
|
||||
else if (op == PlayerKilled.Opcode)
|
||||
{
|
||||
// Phase I.5: death announcement. Holtburger opcodes.rs:150.
|
||||
var parsed = PlayerKilled.TryParse(body);
|
||||
if (parsed is not null)
|
||||
PlayerKilledReceived?.Invoke(parsed.Value);
|
||||
}
|
||||
else if (op == 0x0295u)
|
||||
{
|
||||
// Phase I.5 stub: 0x0295 SetTurbineChatChannels lands the
|
||||
// global chat channel list (Trade, LFG, etc). I.6 will
|
||||
// land the parser here. For now we silently absorb the
|
||||
// packet so it doesn't show up in ACDREAM_DUMP_OPCODES.
|
||||
// TODO(I.6): parse + route to ChatLog.OnSetTurbineChatChannels.
|
||||
}
|
||||
else if (op == PrivateUpdateVital.FullOpcode)
|
||||
{
|
||||
// Issue #5: full per-vital snapshot from the server. Wire
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue