erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

docs: OP6 re-review CLOSED — slice code-complete, gate ready; doc residuals

Browse source 
The re-reviewer byte-decoded ALL six caption sites independently (no
transposition; a third evidence line from the fixture's authored
left/right label geometry), re-verified the audio chain through the one
place an inversion could still hide (the checkbox pass-throughs), and
hand-traced the 97-key conformance table (exactly 97, none invented or
dropped). Residuals applied here: SF-1 the AudioSettings doc comment's
wrong function attribution (the SetDefaultValue literals live in
gmConfigUI::InitOptions @0x0049E435/E457/E479, not InitUIPreferences);
SF-2 the gate script no longer asserts an unread DAT caption — it gates
on behaviour and asks the tester to report the authored English
verbatim; lane A's stale '24 option rows' corrected to 27 (the 39-item
pin is the authoritative tally). AudioSettings.cs change is
comment-only (no executable-code delta; suite state carries from
67b0815c, re-verified at the next code commit).

Campaign state: OP1-OP7 ALL CODE-COMPLETE; OP3/OP4/OP5/OP6 gates ready;
OP8 (Configure Keyboard) is the sole remaining implementation slice.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-11 08:21:07 +02:00
parent 9714e491aa
commit ff5776415b
5 changed files with 493 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

13
docs/research/2026-08-11-campaign-op-test-script.md
View file

@ -567,13 +567,16 @@ should show no caption.
4. **CORRECTED at the OP6 rework round (2026-08-11, review M2) — the
checkbox's stored value is ENABLED-sense, not "Disabled" as the
rejected slice's own gate script previously described.** With the
"Disable Sound Effects" checkbox CHECKED (its default state — see step
first Sound-trio checkbox CHECKED (its default state — see step
6), sound effects are AUDIBLE. **Uncheck it** — sound effects go SILENT
immediately, regardless of where the slider is set. Check it again —
sound effects resume at the slider's current level. (The checkbox's own
retail LABEL reads as if checked should mean muted; byte evidence says
the opposite — see `AudioSettings`' class doc for the full citation.
This gate is about the OBSERVED behaviour, not the label's English.)
sound effects resume at the slider's current level. **Also report the
checkbox's DAT-resolved caption VERBATIM** (OP6 re-review SF-2: the
authored `ID_Sound_DisableSound` string was never read during research,
so this script does not know retail's exact English — if the caption
reads as a "Disable ..." phrasing while CHECKED means audible, that
label-vs-behavior tension is retail's own, byte-verified; report the
text so the script can record it, and gate on the BEHAVIOUR).
5. **Repeat step 4 for the "Ambient Sound" trio** (the second row) using
an ambient loop (wind, water, torches) as your audible test — same live
drag + mute-on-uncheck behaviour.