erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

docs: OP6 re-review CLOSED — slice code-complete, gate ready; doc residuals

Browse source 
The re-reviewer byte-decoded ALL six caption sites independently (no
transposition; a third evidence line from the fixture's authored
left/right label geometry), re-verified the audio chain through the one
place an inversion could still hide (the checkbox pass-throughs), and
hand-traced the 97-key conformance table (exactly 97, none invented or
dropped). Residuals applied here: SF-1 the AudioSettings doc comment's
wrong function attribution (the SetDefaultValue literals live in
gmConfigUI::InitOptions @0x0049E435/E457/E479, not InitUIPreferences);
SF-2 the gate script no longer asserts an unread DAT caption — it gates
on behaviour and asks the tester to report the authored English
verbatim; lane A's stale '24 option rows' corrected to 27 (the 39-item
pin is the authoritative tally). AudioSettings.cs change is
comment-only (no executable-code delta; suite state carries from
67b0815c, re-verified at the next code commit).

Campaign state: OP1-OP7 ALL CODE-COMPLETE; OP3/OP4/OP5/OP6 gates ready;
OP8 (Configure Keyboard) is the sole remaining implementation slice.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-11 08:21:07 +02:00
parent 9714e491aa
commit ff5776415b
5 changed files with 493 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/research/2026-08-10-options-panel-structure.md
View file

@ -484,7 +484,7 @@ Chat tab's `SetUserData` argument *is* the retail window id.
## 4. The **Config** tab — complete row map (`gmConfigUI::InitOptions @0x0049E400`)
Six sections, **6 headers / 5 interior separators + 1 trailing / 24 option rows**. Bindings
Six sections, **6 headers / 5 interior separators + 1 trailing / 27 option rows** (corrected 2026-08-11 at the OP6 re-review — the original 24 was a miscount; the decomp has 27 `Add*Option` calls and the OP6 slice's 39-item count pin (6+6+27) is the authoritative tally). Bindings
are `PStringBase<char>` preference-key globals whose names are `Section_Key`; they map
one-to-one onto `UserPreferences.ini` sections (verified against the user's live retail
`UserPreferences.ini`). All headers byte-verified from `mov eax,[global]; push eax` operands.