erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

fix: complete retail parity stability pass
All checks were successful
CI / linux-portable (push) Successful in 3m41s
Details
CI / windows-gate (push) Successful in 6m49s
Details
CI / release (push) Successful in 3m22s
Details

Browse source
This commit is contained in:
Erik 2026-08-28 20:01:39 +02:00
parent d3df4cb20a
commit f7aa8e0eb7
131 changed files with 7765 additions and 1190 deletions
Download patch file Download diff file Expand all files Collapse all files

29
tests/AcDream.Core.Tests/Chat/ChatLogTests.cs
View file

@ -125,7 +125,9 @@ public sealed class ChatLogTests
{
var log = new ChatLog();
log.OnPlayerKilled("Caith was killed by a Drudge.",
victimGuid: 0x12345678u, killerGuid: 0x90ABCDEFu);
victimGuid: 0x12345678u,
killerGuid: 0x90ABCDEFu,
localPlayerGuid: 0x11111111u);
var e = log.Snapshot()[0];
Assert.Equal(ChatKind.System, e.Kind);
Assert.Equal("Caith was killed by a Drudge.", e.Text);
@ -133,6 +135,25 @@ public sealed class ChatLogTests
Assert.Equal(0x90ABCDEFu, e.ChannelId); // killer guid stashed here
}
[Theory]
[InlineData(0x12345678u)]
[InlineData(0x90ABCDEFu)]
public void OnPlayerKilled_SuppressesVictimAndKiller(uint localPlayerGuid)
{
var log = new ChatLog();
int appended = 0;
log.EntryAppended += _ => appended++;
log.OnPlayerKilled(
"Caith was killed by a Drudge.",
victimGuid: 0x12345678u,
killerGuid: 0x90ABCDEFu,
localPlayerGuid);
Assert.Empty(log.Snapshot());
Assert.Equal(0, appended);
}
// OnWeenieError-specific tests (plain code, interpolation, silent
// client-control statuses) were removed here — REJECT-review rework
// (SHOULD-FIX 3, docs/research/2026-08-09-ch2-review-findings.md)
@ -230,7 +251,11 @@ public sealed class ChatLogTests
public void OnPlayerKilled_LogTextType_IsDefault()
{
var log = new ChatLog();
log.OnPlayerKilled("Caith was killed by a Drudge.", 0x1u, 0x2u);
log.OnPlayerKilled(
"Caith was killed by a Drudge.",
0x1u,
0x2u,
localPlayerGuid: 0x3u);
Assert.Equal(0x00u, log.Snapshot()[0].LogTextType);
}