fix(chat): consolidated-review fixes — retail /help Detail extraction, seam wiring test
SHOULD-FIX 1: RetailClientCommandCatalog's ~45 catalog leaf verbs were showing acdream-authored Summary text for /help <verb> instead of retail's own Detail_HelpType(2) text. Byte-swept every Help* handler against the PDB-paired acclient.exe (verified MATCH), confirmed each Detail/Summary branch by reading the actual decompiled if/else shape (address order and string length both proved unreliable alone), and fixed a sweep_weenie_strings.py 800-char truncation bug that silently dropped several longer Detail branches. Resolved every ambiguous CmdHashData-registered verb (hor/hr/hom/hoa/alh/ah/friends_add/ friends_remove/squelch/unsquelch) by reading for Binary Ninja's nullptr-4th-arg decompiler artifact instead of trusting it. Coverage: 42 of 47 distinct catalog Definitions verbatim-extracted, 4 confirmed-null (index/clist/on/off register with a genuinely null help pointer — DoHelp falls to UnknownCommand for these, now reproduced), 1 honest UNVERIFIED (messagetypes builds its text from a runtime enum table, not a static string). ChatCommandRouter now prefers retail Detail text over the catalog summary; RetailCommandHelpTable's class doc no longer overclaims its own scope. SHOULD-FIX 2: extracted the a5a7eb4f-class OnInterfaceText wiring into a testable CreateChatViewModel method and added ComposedChatViewModelWiresOnInterfaceTextToSpewBox, which the prior FakeFactory-based test suite could never exercise. SHOULD-FIX 3: retires register row AP-113. DoLifestone/DoMarketplace print their own 0x1A refusal text (byte-recovered, UTF-16LE) instead of falling through to the generic 0x26 fallback; ChatCommandRouter's comment corrected to state the fallback's real scope. SHOULD-FIX 4: corrected the divergence register's stale AP section header sentence about AP-190's opacity default (refuted bycc582899). NITs: (a) HeadlessStaticStateAudit routes through the injected HeadlessDiagnosticWriter instead of Console.WriteLine; (b) a bounded 300-pump liveness diagnostic on the IsQuiescent conductor gate (no retry, no behavior change); (c) fixed the #365 hydration test's doc comment contradiction against diagnosis §8; (d) the 0x26 fallback dispatches on WeenieErrorMessages' own Type instead of hardcoding ClientLocal. Full Release suite: 12,553 passed / 4 skipped / 0 failed (baseline03404b71: 12,542/4/0; net +11 tests, zero regressions). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
parent
03404b7121
commit
f7a6f46ba0
15 changed files with 947 additions and 85 deletions
|
|
@ -13,6 +13,7 @@ using AcDream.Core.Items;
|
|||
using AcDream.Core.Spells;
|
||||
using AcDream.Runtime;
|
||||
using AcDream.Runtime.Gameplay;
|
||||
using AcDream.UI.Abstractions.Panels.Chat;
|
||||
|
||||
namespace AcDream.App.Tests.Composition;
|
||||
|
||||
|
|
@ -149,6 +150,43 @@ public sealed class InteractionRetainedUiCompositionTests
|
|||
], fixture.Factory.Releases);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Consolidated-review round (2026-08-10), SHOULD-FIX 2: the a5a7eb4f
|
||||
/// defect class — a composed <see cref="ChatVM.OnInterfaceText"/> hook
|
||||
/// wired but never transferred to production — had no test, because
|
||||
/// <see cref="FakeFactory.CreateRetainedUi"/> above substitutes a
|
||||
/// <see cref="Stub{T}"/> <see cref="ChatVM"/> for the composition-order
|
||||
/// tests and never exercises the REAL wiring in
|
||||
/// <see cref="RetailInteractionRetainedUiCompositionFactory.CreateChatViewModel"/>.
|
||||
/// This test calls that production method directly (it only touches
|
||||
/// <see cref="InteractionRetainedUiDependencies.Communication"/>, no
|
||||
/// GPU/dat/UiHost dependencies, so the existing null-heavy
|
||||
/// <see cref="Fixture"/> dependencies are sufficient without a full
|
||||
/// <see cref="Fixture.Compose"/>) and proves the hook both EXISTS and
|
||||
/// actually reaches <see cref="RuntimeCommunicationState.SpewBox"/>,
|
||||
/// not merely that it was assigned.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void ComposedChatViewModelWiresOnInterfaceTextToSpewBox()
|
||||
{
|
||||
using var fixture = new Fixture(retailUi: true);
|
||||
|
||||
ChatVM chat = RetailInteractionRetainedUiCompositionFactory
|
||||
.CreateChatViewModel(fixture.Dependencies);
|
||||
|
||||
Assert.NotNull(chat.OnInterfaceText);
|
||||
|
||||
const string probeText = "consolidated-review SHOULD-FIX 2 probe";
|
||||
chat.ShowInterfaceText(probeText);
|
||||
// ShowInterfaceText only enqueues; SpewBoxState decouples enqueue
|
||||
// from visibility (see its own class remarks) -- Tick drains it.
|
||||
fixture.Dependencies.Runtime.CommunicationOwner.SpewBox.Tick(0);
|
||||
|
||||
Assert.Contains(
|
||||
fixture.Dependencies.Runtime.CommunicationOwner.SpewBox.Snapshot(),
|
||||
entry => entry.Text == probeText);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void GameWindowUsesPhaseAndContainsNoRetainedUiConstructionBody()
|
||||
{
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue