erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(core): UCG Stage 1 — final-review polish (VisibleCells null-guard, Neighbor doc)

Browse source 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Erik 2026-06-02 09:44:14 +02:00
parent 8e703bef22
commit f2663b7e4b
2 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/AcDream.Core/World/Cells/CellGraph.cs
View file

@ -49,5 +49,10 @@ public sealed class CellGraph
return LandCell.Synthesize(id, t.Terrain, t.Origin, idx / 8, idx % 8); return LandCell.Synthesize(id, t.Terrain, t.Origin, idx / 8, idx % 8);
} }
/// <summary>
/// Resolve the cell on the far side of a portal — retail CCellPortal::GetOtherCell =
/// GetVisible(other_cell_id). <paramref name="cell"/> documents the traversal source and is
/// reserved for the OtherCellPtr neighbor cache (Stage 3); the lookup keys only on the portal.
/// </summary>
public ObjCell? Neighbor(ObjCell cell, in CellPortal portal) => GetVisible(portal.OtherCellId); public ObjCell? Neighbor(ObjCell cell, in CellPortal portal) => GetVisible(portal.OtherCellId);
} }

5
src/AcDream.Core/World/Cells/EnvCell.cs
View file

@ -66,8 +66,9 @@ public sealed class EnvCell : ObjCell
} }
uint lbPrefix = id & 0xFFFF0000u; uint lbPrefix = id & 0xFFFF0000u;
var stab = new List<uint>(datCell.VisibleCells.Count); var stab = new List<uint>();
foreach (var low in datCell.VisibleCells) stab.Add(lbPrefix | low); if (datCell.VisibleCells is not null) // match BuildLoadedCell:5701 null guard
foreach (var low in datCell.VisibleCells) stab.Add(lbPrefix | low);
bool seenOutside = datCell.Flags.HasFlag(EnvCellFlags.SeenOutside); bool seenOutside = datCell.Flags.HasFlag(EnvCellFlags.SeenOutside);
return new EnvCell(id, worldTransform, inverse, min, max, portals, stab, return new EnvCell(id, worldTransform, inverse, min, max, portals, stab,