From efb0756190fd211bed73899462219d08cca09fe0 Mon Sep 17 00:00:00 2001 From: Erik Date: Fri, 4 Sep 2026 16:55:38 +0200 Subject: [PATCH] docs(overhaul): record S5 c1 mandatory stop --- ...-09-01-campaign-overhaul-world-solidity.md | 4 +- .../s5-consumers-material-closeout-packet.md | 45 ++++++++++++++++++- 2 files changed, 46 insertions(+), 3 deletions(-) diff --git a/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md b/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md index 50f88c32..07756b9f 100644 --- a/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md +++ b/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md @@ -680,8 +680,8 @@ Update immediately when a slice changes state. Chat is not the ledger. | S4-c2 attempts 1–5 | **ATTEMPT 1/5 CONSUMED; ATTEMPT 2/5 PASSED AND LANDED 2026-09-04** — reviewed implementation `daaeab0ba`; campaign stack `89f1e2676` → `9ccb61a8e` → `0aa166aa0` → `252886e84`; packet §17 | G3/G4 UNPASSED | Sequential retail/evidence then production/gate-honesty PASS. Fresh: Release 0W/0E; shader 32/32; affected 37/37; real allocation 2/2 at 0 B; production 239/239. Official no-retry hermetic 16,734/1: sole unchanged global `Console.Out` capture race, exact theory 2/2 isolated. InstalledDat 255/10 documented/1. Validation routes `selfgate-20260904-115818-s4c2-landed-route` and `selfgate-20260904-120025-s4c2-landed-g3b` PASS provisional. First soak failed on known #461/#462; retry and S4-c1 control both 9/9 graceful; stationary averages CPU p95 −0.01 ms, GPU p95 +0.16 ms, alloc p50 +1.2 KiB, update p95 −0.12 ms. Three attempts remain unused. | | S4-c3a | **LANDED 2026-09-04 after the owner-authorized §21 evidence exception.** Reviewed scratch stack `44e2bc227b` → `b6bf6c131` → `eea5793d2` → `14397b14c` → `359061b82` → `255194e90` → `9cfddf301`; campaign cherry-picks `a86ec73ec` → `8e0c6fb14` → `01674bcc7` → `8bd75ba31` → `b6b015604` → `316193043` → `67c76026e`. The earlier stop remains in history at `06b986622`. | G3/G4 UNPASSED | Final retail lens PASS; production behavior/lifecycle/allocation/scope clean. The narrow independent gate-honesty re-review PASS reproduced the exact first failure (AP-table-boundary `Assert.True`, `rowIndex=-1`, before `Assert.Single`), restored AP-241 byte-identically, and passed the pin 1/1. Fresh campaign: Release 0W/0E; focused class lane 96/96; no-surface 1/1; AP pin 1/1; real allocation 2/2 at 0 B; shader 32/32; `git diff --check` clean. No client launched. NEXT: write c3b's deletion-only contract from the landed code; G3 stays locked until c3b lands. | | S4-c3b | **LANDED 2026-09-04** — implementation `26e97ba41`, provenance contract `5110bf676`, packet-only correction `3f2f00c9f`; packet §22–§25. Dead classic-group `LocalSortCenters`/`CachedBatch.LocalSortCenter` storage and the alpha camera-parameter/digest chain are deleted. Live per-cell/particle CYpt keys, opaque `SortDistance`, building/private/portal distances, two FIFO lists, all state/barriers, and AP/AD rows remain. | **G3 LEAD SELF-GATE PROVISIONAL PASS; owner acceptance/owner-only rows pending. G4 UNPASSED.** | Retail/deletion lens PASS. Production lens found no code defect and one artifact-provenance omission; packet-only fix round 1 passed its narrow re-review. Fresh campaign: Release 0W/0E; App 132/132; Core 29/29; allocation 2/2 at 0 B; shader 32/32. G3: route 1 13/13, route 2 4/4, route 3 retry 3/3, all exit 0/graceful. The first route-3 attempt stopped before Nanto on registered #462. Exact PNG paths: packet §25. | -| S5-c1 | **CONTRACTED 2026-09-04; implementation pending.** Packet `s5-consumers-material-closeout-packet.md` §§1–6. Exact landscape land-cell publication is separated from EnvCells; particle update ports `CLandCell::IsInView` vs constant-true `CEnvCell::IsInView`; AP-117's null-root frustum/AABB reconstruction and the dead point-light feedback seam are deleted; AP-85/AD-21 are corrected in the same implementation commit. | G4 UNPASSED | Lead verified the named pseudo-C and paired executable/PDB (GUID `{9E847E2F-777C-4BD9-886C-22256BB87F32}`, age 1): `ShouldDrawParticles @0x0050FE60`, `UpdateParticles @0x0051D180`, `CLandCell::IsInView @0x00532CB0`, and the CEnvCell vtable's ICF body `0x005269F0`. Directional shadows, building degrade, AP-232, probes, and closeout are later bounded chunks. | -| S5 | IN FLIGHT — c1 contracted; c2–c5 and closeout remain | G4 | Packet §7 is the bounded decomposition; never merge main before G4. | +| S5-c1 | **STOPPED 2026-09-04 after fix round 2; scratch stack not landed.** Packet §9. Implementation `9aadc917a`; comment-only fix rounds `74a2e4c48` and `a28384d80`. Retail lens PASS; production lens found no code/test defect but FAILed on two documentation/evidence items: null-root really completes an empty `hasCompletedView=true` transaction while architecture/AD-21 say no answer, and the dirty-base official artifacts are not bound to the reviewed implementation source. | **MANDATORY THIRD-ROUND STOP; G4 UNPASSED.** | Reproduced scratch evidence: Release 0W/0E; Core 111/111; App 146/146; allocation 1/1 at 0 B; corrected hermetic 16,760/16,760; InstalledDat 385/10 documented/1; three 30-entry manifests verify. No client/self-gate and no campaign cherry-pick. Explicit owner direction is required for any documentation/evidence-only exception; history remains intact. | +| S5 | STOPPED at c1 after the two allowed fix rounds; c2–c5 and closeout remain undispatched | G4 UNPASSED | Packet §9 is authoritative. Never merge main before G4. | --- diff --git a/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md b/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md index 8b93cc53..43aa408e 100644 --- a/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md +++ b/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md @@ -1,6 +1,6 @@ # Campaign OVERHAUL v2 — S5 consumers, material, and closeout packet -**Status:** S5-c1 CONTRACTED 2026-09-04; implementation not yet landed. +**Status:** S5-c1 STOPPED 2026-09-04 after fix round 2; not landed. **Branch:** `claude/campaign-w-retail-frame-walk`. **Gate:** G4 remains unpassed. Nothing merges to `main` before G4. @@ -274,3 +274,46 @@ row and do not change the three AP-241/AP-242/AP-243 assertions. Run the exact failed test first, then a fresh official hermetic lane under a new artifact name and the required InstalledDat lane. Preserve the original failed artifact and record both identities in the implementer return. + +## 9. S5-c1 mandatory stop after fix round 2 — 2026-09-04 + +The reviewed scratch stack is intentionally **not landed**: + +- gate-correction contract `2bb565b0b`; +- implementation `9aadc917a`; +- retail fix-round-1 contract/implementation `afaebcad6` / `74a2e4c48`; +- retail fix-round-2 contract/implementation `ed8200664` / `a28384d80`. + +The retail lens ultimately passed. It verified the paired executable/PDB bytes, +the exact land-cell versus EnvCell virtual behavior, previous-completed-frame +timing, x87/AP-116 edges, typed landscape handoff, and unchanged particle +draw/queue/tick behavior. The production lens found no production-code or test +defect and reproduced Release 0 warnings / 0 errors, Core VFX 111/111, App +focused 146/146, allocation 1/1 at 0 B, AP-116 3/3, all six non-vacuous +mutations, all source guards, and all three 30-entry artifact manifests with +zero mismatch. Official artifacts remain in the scratch worktree: + +- `artifacts/s5-c1-hermetic-20260904`: 16,759 passed / 1 stale-row failure; +- `artifacts/s5-c1-hermetic-corrected-20260904`: 16,760/16,760; +- `artifacts/s5-c1-installed-20260904`: 385 passed / 10 documented failed / + 1 documented skipped, with no new identity. + +The final production lens nevertheless failed on two correction-worthy +documentation/evidence findings after both allowed fix rounds: + +1. `acdream-architecture.md` and AD-21 say a null-root frame publishes no + cell-visibility answer. Production actually completes + `hasCompletedView=true` with an empty landscape set; only login/portal carry + false. Scratch packet §11.1 states this correctly, so the implementation's + claim that architecture/register prose is truthful is false. +2. The packet reports the official lanes but does not reconcile their recorded + `WorktreeDirty=true` bases (`00f134f9e` for the first lane and `2bb565b0b` + for the corrected/InstalledDat lanes) to implementation commit `9aadc917a`, + nor state that later commits are prose/comments only. The manifests prove + their 30 recorded evidence files, not the dirty source content. + +Correcting either finding would be fix round 3. The campaign rule therefore +requires this stop: do not cherry-pick the scratch stack, do not run a graphical +gate on it, and do not dispatch S5-c2. Resumption requires explicit owner +direction on whether to authorize an evidence/documentation-only exception; +history must remain intact either way. G3 stays provisional and G4 unpassed.