From ef819eedf5b7405239c6a1f791829640d0ffd0c6 Mon Sep 17 00:00:00 2001 From: Erik Date: Fri, 4 Sep 2026 18:17:56 +0200 Subject: [PATCH] docs(overhaul): record S5 c2 clean evidence Replace the stale pending-evidence result with the exact clean-commit hermetic, broader InstalledDat, and canonical comparison identities, filters, counts, and verified manifests. Preserve the broader artifact as valid noncanonical evidence and record both zero-difference nonpassing comparisons against accepted S5-c1. Record retail review PASS and production review FAIL solely on the corrected evidence prose, with code, architecture, GPU-flight, lifecycle, allocation, and scope otherwise passing. Mark the documentation-only fix round implemented pending narrow re-review without advancing S5-c2 to landed. Co-Authored-By: Claude Sonnet 4.5 --- ...-09-01-campaign-overhaul-world-solidity.md | 4 +- .../s5-consumers-material-closeout-packet.md | 42 +++++++++++++++---- 2 files changed, 36 insertions(+), 10 deletions(-) diff --git a/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md b/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md index 7578f8ca..460f02d1 100644 --- a/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md +++ b/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md @@ -681,8 +681,8 @@ Update immediately when a slice changes state. Chat is not the ledger. | S4-c3a | **LANDED 2026-09-04 after the owner-authorized §21 evidence exception.** Reviewed scratch stack `44e2bc227b` → `b6bf6c131` → `eea5793d2` → `14397b14c` → `359061b82` → `255194e90` → `9cfddf301`; campaign cherry-picks `a86ec73ec` → `8e0c6fb14` → `01674bcc7` → `8bd75ba31` → `b6b015604` → `316193043` → `67c76026e`. The earlier stop remains in history at `06b986622`. | G3/G4 UNPASSED | Final retail lens PASS; production behavior/lifecycle/allocation/scope clean. The narrow independent gate-honesty re-review PASS reproduced the exact first failure (AP-table-boundary `Assert.True`, `rowIndex=-1`, before `Assert.Single`), restored AP-241 byte-identically, and passed the pin 1/1. Fresh campaign: Release 0W/0E; focused class lane 96/96; no-surface 1/1; AP pin 1/1; real allocation 2/2 at 0 B; shader 32/32; `git diff --check` clean. No client launched. NEXT: write c3b's deletion-only contract from the landed code; G3 stays locked until c3b lands. | | S4-c3b | **LANDED 2026-09-04** — implementation `26e97ba41`, provenance contract `5110bf676`, packet-only correction `3f2f00c9f`; packet §22–§25. Dead classic-group `LocalSortCenters`/`CachedBatch.LocalSortCenter` storage and the alpha camera-parameter/digest chain are deleted. Live per-cell/particle CYpt keys, opaque `SortDistance`, building/private/portal distances, two FIFO lists, all state/barriers, and AP/AD rows remain. | **G3 LEAD SELF-GATE PROVISIONAL PASS; owner acceptance/owner-only rows pending. G4 UNPASSED.** | Retail/deletion lens PASS. Production lens found no code defect and one artifact-provenance omission; packet-only fix round 1 passed its narrow re-review. Fresh campaign: Release 0W/0E; App 132/132; Core 29/29; allocation 2/2 at 0 B; shader 32/32. G3: route 1 13/13, route 2 4/4, route 3 retry 3/3, all exit 0/graceful. The first route-3 attempt stopped before Nanto on registered #462. Exact PNG paths: packet §25. | | S5-c1 | **LANDED 2026-09-04 after the owner-authorized documentation/evidence exception.** Mandatory stop `efb075619` remains in history; final campaign tip `1718832e2`, reviewed scratch tip `b2d56f9e3`. | G4 UNPASSED | Narrow exception re-review PASS. Clean evidence: hermetic 16,760/16,760; inclusive InstalledDat 385 pass / the same documented 10 fail / 1 skip; both exact `d6592d3ac`, `WorktreeDirty=false`, manifests fully verified. Fresh campaign Release 0W/0E, Core 111/111, visibility 38/38, allocation/AP-116 4/4. Lead graphical portal-haze gate PROVISIONAL PASS, exit 0/graceful, 10 PNGs under `logs/selfgate-20260904-171137-s5c1-particle-visibility`; owner inspection pending. | -| S5-c2 | **IMPLEMENTED 2026-09-04; sequential reviews pending.** The opt-in IA-24 path borrows the exact prior-completed landscape set/flag, selects world casters through S2 CELLARRAY or building `EffectCellId`, selects authored terrain slots, and projects arbitrary active instance runs without rebuilding retained topology. Pack-off remains unchanged. | G4 UNPASSED | Packet §14 implementation result: Release 0W/0E; focused production lane 137/137; warmed caster/prepared/terrain selection pins 0 B; all seven required sabotages failed at the named first assertions and were restored. Clean exact-commit official evidence is the remaining implementer return before review. | -| S5 | IN FLIGHT — c1 landed/provisionally self-gated; c2 implementation candidate awaiting clean evidence + dual review; c3–c5 and closeout remain | G4 | Packet §§7 and 12–14 are binding; never merge main before G4. | +| S5-c2 | **IMPLEMENTED 2026-09-04; documentation-only fix round 1 implemented, narrow re-review pending.** The opt-in IA-24 path borrows the exact prior-completed landscape set/flag, selects world casters through S2 CELLARRAY or building `EffectCellId`, selects authored terrain slots, and projects arbitrary active instance runs without rebuilding retained topology. Pack-off remains unchanged. | G4 UNPASSED | Retail/deviation review PASS. Production review found code/architecture/GPU-flight otherwise passing and returned FAIL only on stale evidence/status prose. Exact clean commit `603d4bbb05e`: hermetic 16,768/16,768; preserved broader InstalledDat 468 pass / 10 fail / 1 skip; canonical comparison 385 pass / the same 10 fail / 1 skip; all three manifests fully verified and both nonpassing-identity comparisons against accepted S5-c1 returned no differences. Packet §15 fix is implemented pending narrow re-review; not landed, review-closed, self-gated, or user-accepted. | +| S5 | IN FLIGHT — c1 landed/provisionally self-gated; c2 implemented with clean evidence and documentation-only fix round 1 pending narrow re-review; c3–c5 and closeout remain | G4 | Packet §§7 and 12–15 are binding; never merge main before G4. | --- diff --git a/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md b/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md index 2ba806e4..4d8073b7 100644 --- a/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md +++ b/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md @@ -733,7 +733,7 @@ motion, transform/GPU flight safety, 0-B steady state, lifecycle/deferral, allowed scope, counts, and at least three mutation claims. A failed lens gets one bounded fix contract; a third fix round stops and is written up. -### 14.7 S5-c2 implementation result — clean evidence pending +### 14.7 S5-c2 implementation result — clean evidence complete; fix round 1 implemented The bounded implementation is complete for review. The selected atmospheric pack now borrows the existing visibility controller's exact prior-completed @@ -798,13 +798,39 @@ and restored exactly. Their actual first failures were: `AlternatingCasterSelection_EmitsExactContiguousInstanceRuns`, first active-command-count `Assert.Equal` expected 3, actual 1. -The one bounded implementation commit is made before the official lanes. -Official hermetic and inclusive InstalledDat evidence will run only from that -exact clean commit, with `WorktreeDirty=false`, under -`artifacts/s5-c2-hermetic-20260904` and -`artifacts/s5-c2-installed-20260904`. Those post-commit artifacts supersede no -earlier run and will be reported directly; this result does not invent their -counts. +The bounded implementation is commit +`603d4bbb05ebc3e840b5d6e66a20a4c9d3cecc8a`. All three official summaries +name that exact commit and record `WorktreeDirty=false`; their existing +SHA-256 manifests verify without a missing or mismatched file: + +- `artifacts/s5-c2-hermetic-20260904` — 16,768 passed, 0 failed, + 0 skipped; manifest 32/32 present and matching. +- `artifacts/s5-c2-installed-20260904` — the first, deliberately preserved + broader run used the literal `Lane=InstalledDat` filter and produced + 468 passed, 10 failed, 1 skipped; manifest 30/30 present and matching. It + is valid additional evidence, but it is not renamed or presented as the + canonical comparison. +- `artifacts/s5-c2-installed-canonical-20260904` — the distinct canonical + comparison used the same accepted S5-c1 project filter, + `Lane=InstalledDat&Purpose!=Diagnostic`, and produced 385 passed, + 10 failed, 1 skipped; manifest 30/30 present and matching. + +Both S5-c2 InstalledDat artifacts contain the same 11 nonpassing TRX +identities as the accepted S5-c1 canonical artifact. The broad-versus-S5-c1 +and canonical-versus-S5-c1 `Compare-Object` comparisons each returned zero +differences. Their different passing totals remain explicit because the two +intentional filters are not interchangeable. + +Sequential retail/deviation review returned **PASS** without a production +correction. Sequential architecture/GPU/gate-honesty review found the code, +architecture, GPU-flight safety, lifecycle, allocation, and implementation +scope otherwise passing, but returned **FAIL** because this result and the +campaign plan still described clean evidence as pending and named only the +broader InstalledDat run. Fix round 1 changes only those two evidence/status +documents and is implemented pending narrow re-review. The stationary +three-buffer per-frame publication is real, explicitly permitted by §14.4, +and bounded by Vulkan's two-flight retirement fence; it is a performance note, +not a correction and not the #350 mechanism. ## 15. S5-c2 production-review fix round 1 — evidence provenance only