test: remove vacuous diagnostic assertions

This commit is contained in:
Erik 2026-08-18 12:48:07 +02:00
parent 5fa9933636
commit ea17bc8624
5 changed files with 151 additions and 28 deletions

View file

@ -71,10 +71,11 @@ public class CellarLipWedgeTests
/// <summary>
/// Diagnostic: drive the player off the threshold toward the cottage and
/// dump the trajectory + indoor-BSP/step probes. Always passes; the
/// captured stdout shows exactly what the engine does each tick.
/// dump the trajectory + indoor-BSP/step probes. The captured artifact
/// shows exactly what the engine does each tick; this is not a verdict test.
/// </summary>
[Fact]
[Trait("Purpose", "Diagnostic")]
public void Diagnostic_DriveOffThreshold_DumpTrajectory()
{
PhysicsDiagnostics.ProbeResolveEnabled = true;
@ -96,7 +97,6 @@ public class CellarLipWedgeTests
$"tick={p.Tick} pos=({p.Position.X:F4},{p.Position.Y:F4},{p.Position.Z:F4}) " +
$"cell=0x{p.CellId:X8} onGround={p.IsOnGround} cpValid={p.CpValid}")) +
"\n\nPROBES:\n" + probeLines);
Assert.True(true);
}
finally
{
@ -284,9 +284,11 @@ public class CellarLipWedgeTests
/// <summary>
/// Diagnostic: replay every captured wedge record and report advance% — to
/// confirm the lip-cell engine reproduces the live stuck (0% advance) before
/// asserting a fix. Always passes; results in the message + %TEMP% file.
/// asserting a fix. Results are written to a %TEMP% artifact; this is not
/// a verdict test.
/// </summary>
[Fact]
[Trait("Purpose", "Diagnostic")]
public void Diagnostic_ReplayLiveWedgeRecords_Advance()
{
var recs = LoadWedgeRecords();
@ -302,7 +304,6 @@ public class CellarLipWedgeTests
$"res=({res.X:F2},{res.Y:F2},{res.Z:F2})");
}
File.WriteAllText(Path.Combine(Path.GetTempPath(), "lip-wedge-replay.log"), string.Join("\n", lines));
Assert.True(true, string.Join("\n", lines.Take(10)));
}
/// <summary>
@ -310,6 +311,7 @@ public class CellarLipWedgeTests
/// probes on, capturing why the step-up fails. Output to %TEMP%/lip-wedge-stepup.log.
/// </summary>
[Fact]
[Trait("Purpose", "Diagnostic")]
public void Diagnostic_ReplayFloorCpRecord_StepUpProbes()
{
var rec = LoadWedgeRecords().First(r => r.BodyBefore is not null
@ -328,7 +330,6 @@ public class CellarLipWedgeTests
$"record cur=({rec.Input.CurrentPos.X:F4},{rec.Input.CurrentPos.Y:F4},{rec.Input.CurrentPos.Z:F4}) " +
$"tgt=({rec.Input.TargetPos.X:F4},{rec.Input.TargetPos.Y:F4},{rec.Input.TargetPos.Z:F4}) " +
$"req={req:F3} adv={adv:F3} res=({res.X:F4},{res.Y:F4},{res.Z:F4})\n\n" + sw.ToString());
Assert.True(true);
}
finally
{

View file

@ -292,6 +292,7 @@ public class CellarUpTrajectoryReplayTests : IDisposable
/// what the harness is actually doing.
/// </summary>
[Fact]
[Trait("Purpose", "Diagnostic")]
public void Harness_DiagnosticDump_FirstTenTicks()
{
PhysicsDiagnostics.ProbeResolveEnabled = true;
@ -308,11 +309,7 @@ public class CellarUpTrajectoryReplayTests : IDisposable
string.Join("\n ", trajectory.Select(p =>
$"tick={p.Tick} pos=({p.Position.X:F4},{p.Position.Y:F4},{p.Position.Z:F4}) " +
$"cell=0x{p.CellId:X8} onGround={p.IsOnGround} cpValid={p.CpValid}"));
// Always pass — this is a diagnostic test; the probe
// output appears in the test runner's captured stdout
// and the trajectory in the assertion message on failure.
Assert.True(true, msg);
Console.WriteLine(msg);
}
finally
{
@ -330,6 +327,7 @@ public class CellarUpTrajectoryReplayTests : IDisposable
/// the cellar floor.
/// </summary>
[Fact]
[Trait("Purpose", "Diagnostic")]
public void Harness_DiagnosticDump_NoBodySeed()
{
PhysicsDiagnostics.ProbeResolveEnabled = true;
@ -368,8 +366,7 @@ public class CellarUpTrajectoryReplayTests : IDisposable
string.Join("\n ", trajectory.Select(p =>
$"tick={p.Tick} pos=({p.Position.X:F4},{p.Position.Y:F4},{p.Position.Z:F4}) " +
$"onGround={p.IsOnGround}"));
Assert.True(true, msg);
Console.WriteLine(msg);
}
finally
{

View file

@ -203,6 +203,7 @@ public class DoorCollisionApparatusTests
/// without yielding a green/red verdict.
/// </summary>
[Fact]
[Trait("Purpose", "Diagnostic")]
public void Apparatus_DiagnosticDump_FrontApproach()
{
if (!TryBuildScenario(out var ctx)) Assert.Fail("Lane=InstalledDat requires an installed retail DAT directory; see docs/release-gate.md.");
@ -236,7 +237,6 @@ public class DoorCollisionApparatusTests
isOnGround = result.IsOnGround;
}
Assert.True(true, "Diagnostic test — always passes; check stdout.");
}
finally
{