fix(ui): Campaign CT4 fix round — luminance text, verbatim title, PK PWD bits

Opus dual-lens review of ed652ed8 found 2 blockers + 5 should-fix. All applied.

BLOCKERS:
- Bind the luminance pair (0x100005C5/0x100005C6): caption "Luminance:"
  (UTF-16, PE-byte-decoded from the gmStatManagementUI vftable-adjacent
  data at @0x007c3dd4) and value "<available> / <maximum>" (narrow
  "%s / %s" @0x007c3dcc) — both literals independently re-derived from the
  raw acclient.exe bytes and confirmed byte-exact against the review's
  claim. Numbers format through a new shared FormatXp helper
  (.ToString("N0", InvariantCulture) — retail's ExperienceSystem::XPToString
  equivalent), also now used by Total XP / XP-to-next-level (previously an
  un-invariant bare "N0"). Hide path switched from Visible=false to
  retail's own UIElement_Text::ClearAllText mechanism
  (@0x004f0e31/@0x004f0e3c — empty LinesProvider, leave layout); each
  LinesProvider re-reads data() on every draw, so no separate refresh call
  is needed.
- CharacterIdentityText.StripLeadingArticle deleted: retail AppendText's
  the resolved title VERBATIM (@0x004f0990); 26 real ACE CharacterTitle
  entries begin with "The" and were being mangled. The dead
  CharacterSheet.Race fallback is deleted alongside it — retail's
  InqGenderHeritageDisplay creature-type argument is a hardcoded literal 0
  (@0x004f08db), no producer exists.

SHOULD-FIX:
- PK line re-sourced: classifies off the live ClientObject.PublicWeenieBitfield
  PWD bits (0x20 IsPK / 0x02000000 IsPKLite — ACCWeenieObject::IsPK/IsPKLite
  @0x0058c8b0/@0x0058c8a0) instead of a bitwise test against raw
  PropertyInt 134, which carries ACE's own PlayerKillerStatus enum bit
  layout, not the PWD layout. PropertyInt 134 already drives the correct
  bits via the existing PlayerKillerStatusBitfield.Apply; this is a
  re-source, not new wiring. Deleted the 0x4|0x8 combined-flag test case,
  which asserted a non-retail answer.
- Register AP-109 row: restores CT3's Titles-page narrowing paragraph
  (CT4's edit had compressed it to a bare pointer phrase), corrects the
  rank-prefix source to PropertyInt 0x1E (AllegianceRank) read live off
  the qualities bundle — not RuntimeAllegianceState, which is a different
  UI's (SocialAllegiancePageController) own documented substitute —
  corrects the title-table size from an estimated 22 functions/~200
  strings to the actual 17 functions/~170 strings (AllegianceSystem::GetTitle's
  dispatch switch read directly), and downgrades the evidence claim.
  Filed AP-235 for the gender/heritage hardcoded-table-vs-live-EnumMapper
  mechanism divergence, pointing at the ALREADY-EXISTING
  RetailDataIdResolver.Resolve helper as CT5's unification seam.
- CharacterPanelLiveDatTests.HeaderElements_AuthorExpectedFontsAndColors
  extended with the luminance pair's own occurrence-count + font/color
  pins, matching every other header id's pattern.

Also landed: an InstalledDat pin
(GenderHeritageDisplayNameTables_MatchTheRetailEnumMapperChain) proving
CharacterIdentityText.GenderDisplayName/HeritageGroupDisplayName match the
live retail EnumMapper chain (master map category 1 ->
ClientEnumToID[0x10000001]/[0x10000002] -> EnumMapper DIDs
0x2200000A/0x2200000B) byte-exact, including the two entries the review
flagged as unverified guesses (10 "Penumbraen", 12 "Olthoi" — both
correct). CharacterSheetProvider.BuildSheet's level read switched from a
GetInt+ContainsKey double lookup to one TryGetValue. Plan ledger's
test-provenance sentence corrected (Bind_HeaderElements_... predates CT4,
extended to cover PkStatusId).

Tests: CharacterStatControllerTests (verbatim title incl. "The Noob",
luminance content/gate, luminance text binding, extended
Bind_HeaderElements_... covering PkStatusId), CharacterSheetProviderTests
(PK status driven through ClientObjectTable.UpdateIntProperty instead of
a raw property write), CharacterPanelLiveDatTests (luminance pin, gender/
heritage EnumMapper pin). Full hermetic solution suite green under Release
(0 failures, 15 projects); InstalledDat pins green (197/197, excluding one
confirmed pre-existing unrelated failure — TowerAscentReplayTests, verified
to fail identically with these changes stashed out).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

docs/plans/2026-08-24-character-panel-parity-campaign.md

@@ -265,7 +265,9 @@ row-template resolver already takes (`RetailUiRuntime.MountCharacter`),
 and set the list box's authored 24px row height so wheel/line scroll
 lands row-aligned.
 
-**CT4 — Header identity block. CODE-COMPLETE 2026-08-24.** Retail composition: name; "<Gender>
+**CT4 — Header identity block. REVIEW-CLOSED 2026-08-25: landed `ed652ed8`,
+Opus dual-lens review (2 blockers + 5 should-fix, all applied), fix round
+applied 2026-08-25.** Retail composition: name; "<Gender>
 <Heritage> <DisplayTitle>"; PK status line — authored fonts/colors
 (pure white per probe), live refresh on display-title change and PK
 status, identical on Attributes AND Skills pages. Level color from the
@@ -275,7 +277,10 @@ authored element. Retires the rest of AP-109's UI half.
 already covers both Attributes/Skills page copies — `CharacterStatController`
 binds the SAME physically-visible container (contentPage = the Attributes
 page chain) for both tabs; the Skills-page duplicate header subtree is never
-shown (a test now pins this: `Bind_HeaderElements_UseVisibleAttributesPageWhenIdsAreDuplicated`).
+shown (pinned by `Bind_HeaderElements_UseVisibleAttributesPageWhenIdsAreDuplicated`,
+a test that PREDATES CT4 — corrected at the CT4 fix round below, since the
+original wording here implied CT4 wrote it fresh; the pre-existing test did
+not cover `PkStatusId` until the fix round extended it).
 All four header identity elements (Name/Heritage/PkStatus/Level) switched
 from hand-picked `Body`/`Gold` runtime colors to the widget's own authored
 `DefaultColor` (`LabelAuthoredColor`), matching CT1's live-DAT pin exactly —
@@ -319,6 +324,60 @@ key-by-status resolution including a combined-flag case, no-resolver ⇒ null,
 Level null-vs-present, title resolution + live refresh on both title
 events + unsubscribe-on-dispose, luminance Int64 read-through).
 
+**CT4 fix round (Opus dual-lens review, 2026-08-25).** 2 BLOCKERS: (1) the
+luminance caption/value strings were RECOVERED by PE-byte-decoding the raw
+retail binary (caption UTF-16 `"Luminance:"` at `@0x007c3dd4`, value narrow
+`"%s / %s"` at `@0x007c3dcc`, both immediately following
+`gmStatManagementUI::UpdatePKStatus`'s own vftable slots — the CT4 landing's
+"could not be recovered" claim is FALSIFIED), so the pair now binds real
+text (each number formatted through a new shared `FormatXp` helper —
+`.ToString("N0", InvariantCulture)`, also now used by Total XP / XP-to-next-
+level, replacing their un-invariant `.ToString("N0")`), and the hide path
+switched from `Visible = false` to retail's own `UIElement_Text::ClearAllText`
+mechanism (`@0x004f0e31`/`@0x004f0e3c` — empty the LinesProvider, leave
+layout); (2) `CharacterIdentityText.StripLeadingArticle` is deleted — retail
+`AppendText`s the resolved title VERBATIM (`@0x004f0990`), and 26 real ACE
+`CharacterTitle` entries begin with "The", so every one of them was being
+mangled; the dead `CharacterSheet.Race` fallback (no retail producer — the
+`InqGenderHeritageDisplay` creature-type argument is a hardcoded literal `0`
+at `@0x004f08db`) is deleted alongside it. 5 SHOULD-FIX: (3) the PK line now
+classifies off the live `ClientObject.PublicWeenieBitfield` PWD bits
+(`0x20`/`0x02000000`, `ACCWeenieObject::IsPK`/`IsPKLite`
+`@0x0058c8b0`/`@0x0058c8a0`) instead of a bitwise test against raw
+PropertyInt 134 — PropertyInt 134 carries ACE's own `PlayerKillerStatus`
+enum bit layout, not the PWD layout, so the deleted `0x4 | 0x8` combined-flag
+test case asserted a non-retail answer (PropertyInt 134 already drives the
+correct PWD bits via `PlayerKillerStatusBitfield.Apply`, so this is a
+re-source, not new wiring); (4) the register's AP-109 row restores CT3's
+Titles-page narrowing paragraph (CT4's edit had compressed it to a bare
+pointer phrase), corrects the rank-prefix item's source to PropertyInt
+`0x1E` (`AllegianceRank`) read live off the qualities bundle — NOT
+`RuntimeAllegianceState`, which is a DIFFERENT UI's (`SocialAllegiancePageController`)
+own documented substitute — corrects the title-table size from the
+originally-estimated 22 functions/~200 strings to the ACTUAL 17
+functions/~170 strings (`AllegianceSystem::GetTitle`'s dispatch switch read
+directly: Gearknight/Tumerok author only a male function reused both ways,
+Lugian only a female one, and Olthoi/OlthoiAcid have none), and downgrades
+the row's evidence claim to "synthetic-layout binding tests plus a small
+number of InstalledDat string/DID pins" rather than implying a
+connected/live gate; (5) `CharacterPanelLiveDatTests.HeaderElements_AuthorExpectedFontsAndColors`
+gains the luminance pair's own occurrence-count + font/color pins, matching
+the pattern every other header id already uses. Also landed this round: an
+InstalledDat pin (`GenderHeritageDisplayNameTables_MatchTheRetailEnumMapperChain`)
+proving `CharacterIdentityText.GenderDisplayName`/`HeritageGroupDisplayName`
+match the live retail `EnumMapper` chain (master map category 1 →
+`ClientEnumToID[0x10000001]`/`[0x10000002]` → EnumMapper DIDs
+`0x2200000A`/`0x2200000B`) byte-exact, including the two entries (10
+"Penumbraen", 12 "Olthoi") the review had flagged as unverified guesses —
+both are correct; the mechanism divergence (hardcoded table vs. live DAT
+read) is filed as AP-235, pointing CT5 at the ALREADY-EXISTING generic
+`RetailDataIdResolver.Resolve` helper (not a new "GetDIDByEnum helper" to
+write) as the unification seam; `RetailAppraisalNameResolver.ResolveHeritage`'s
+independent re-implementation of the same three overrides is noted there
+too, for CT5. `CharacterSheetProvider.BuildSheet`'s level read switched from
+a `GetInt` + `Ints.ContainsKey` double dictionary lookup to one
+`TryGetValue`.
+
 **CT5 — Row alignment + value gutter.** Reconcile our hand-built
 attribute/skill rows with the authored row templates from CT1: icon
 placement, name/value columns, the authored right margin that reserves