erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

CC2 review fix round: latch scope narrowed, AD-100, creationFailed reason key

Browse source 
F1 (MEDIUM): the correlation-latch docs claimed replies are never
misattributed; in truth an overlapping send OVERWRITES the latch and the
first reply routes to the newest request's event. Narrowed all three doc
sites to the exact contract (single outstanding request; overlap refusal
is CC3's Runtime verification gate, retail's DoFinish UNDEF-state rule)
and pinned the overwrite behavior with
OverlappingSend_OverwritesTheLatch_ReplyRoutesToNewestRequest.

F2 (LOW): filed register AD-100 for the drop-unless-armed deviation —
retail's Handle_CharGenVerificationResponse@0x0055E8B0 has no armed gate
and processes whatever arrives against its persistent verification state.

F3 (LOW): doc note in CharacterCreate.cs — ACE double-sends NameInUse
(IsCharacterNameAvailable runs twice; the first callback's return exits
only the lambda), so the second reply hitting the drop path during a
connected gate is EXPECTED, not a defect.

F4 (LOW): creationFailed's enum-member key renamed name -> reason and the
ATTEMPTED character name added as name, before any consumer shipped —
one status vocabulary must not give the same key two meanings
(characterCreated.name is a character name). Contract, writer, tailer,
and shape-pinning tests updated in lockstep.

F5 (LOW): the thread-id probe-note pointer now cites
ProbeNetLogOutbound's doc comment, where the note actually lives.

Fidelity fold (reviewer's positive note): the latch is retail's OWN
discriminator one layer down — 0x0055E8B0 case 1 branches on
GetVerificationState()==PENDING (create) vs not (restore) — now cited in
both the latch doc and CharGenVerificationResponse.cs.

Core.Net 994, Runtime 1667, Launcher.Core 324, all green Release.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-15 13:10:24 +02:00
parent 5eaad2c88c
commit e77ebf100f
12 changed files with 143 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/AcDream.Runtime/Session/SessionStatusWriter.cs
View file

@ -232,12 +232,17 @@ public sealed class SessionStatusWriter
/// <summary>
/// Campaign CC CC2: a non-Ok <c>0xF643</c> response to an outbound
/// CharacterCreate. <paramref name="code"/> is the raw wire
/// <c>CharGenVerificationResponse.Code</c> value; <paramref name="name"/>
/// <c>CharGenVerificationResponse.Code</c> value; <paramref name="reason"/>
/// is that code's enum member name (e.g. <c>"NameInUse"</c>) so a
/// launcher can render a readable reason without hard-coding the
/// server's numeric-to-dialog mapping itself.
/// server's numeric-to-dialog mapping itself; <paramref name="name"/>
/// is the ATTEMPTED character name — the thing a launcher most wants to
/// show ("the name Bob is taken"). The key was <c>name</c> for the enum
/// member until the CC2 review (F4): <c>characterCreated.name</c> is a
/// character name, and one status vocabulary must not give the same key
/// two meanings. Renamed before any consumer shipped.
/// </summary>
public void CreationFailed(string sessionId, uint code, string name) =>
public void CreationFailed(string sessionId, uint code, string reason, string name) =>
Write(new
{
v = VocabularyVersion,
@ -245,6 +250,7 @@ public sealed class SessionStatusWriter
t = Now(),
sessionId,
code,
reason,
name,
});