CC2 review fix round: latch scope narrowed, AD-100, creationFailed reason key

F1 (MEDIUM): the correlation-latch docs claimed replies are never
misattributed; in truth an overlapping send OVERWRITES the latch and the
first reply routes to the newest request's event. Narrowed all three doc
sites to the exact contract (single outstanding request; overlap refusal
is CC3's Runtime verification gate, retail's DoFinish UNDEF-state rule)
and pinned the overwrite behavior with
OverlappingSend_OverwritesTheLatch_ReplyRoutesToNewestRequest.

F2 (LOW): filed register AD-100 for the drop-unless-armed deviation —
retail's Handle_CharGenVerificationResponse@0x0055E8B0 has no armed gate
and processes whatever arrives against its persistent verification state.

F3 (LOW): doc note in CharacterCreate.cs — ACE double-sends NameInUse
(IsCharacterNameAvailable runs twice; the first callback's return exits
only the lambda), so the second reply hitting the drop path during a
connected gate is EXPECTED, not a defect.

F4 (LOW): creationFailed's enum-member key renamed name -> reason and the
ATTEMPTED character name added as name, before any consumer shipped —
one status vocabulary must not give the same key two meanings
(characterCreated.name is a character name). Contract, writer, tailer,
and shape-pinning tests updated in lockstep.

F5 (LOW): the thread-id probe-note pointer now cites
ProbeNetLogOutbound's doc comment, where the note actually lives.

Fidelity fold (reviewer's positive note): the latch is retail's OWN
discriminator one layer down — 0x0055E8B0 case 1 branches on
GetVerificationState()==PENDING (create) vs not (restore) — now cited in
both the latch doc and CharGenVerificationResponse.cs.

Core.Net 994, Runtime 1667, Launcher.Core 324, all green Release.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-15 13:10:24 +02:00
parent 5eaad2c88c
commit e77ebf100f
12 changed files with 143 additions and 32 deletions

View file

@ -64,13 +64,19 @@ public sealed record CharacterCreatedStatusEvent : StatusEvent
/// <summary>
/// Campaign CC CC2: a non-Ok reply to an outbound CharacterCreate.
/// <see cref="Code"/> is the raw wire
/// <c>CharGenVerificationResponse.Code</c> value; <see cref="Name"/> is that
/// code's enum member name (e.g. <c>"NameInUse"</c>).
/// <c>CharGenVerificationResponse.Code</c> value; <see cref="Reason"/> is
/// that code's enum member name (e.g. <c>"NameInUse"</c>);
/// <see cref="Name"/> is the ATTEMPTED character name. The enum member
/// rode the <c>name</c> key until the CC2 review (F4) — same key,
/// different meaning than <c>characterCreated.name</c> — renamed before
/// any consumer shipped.
/// </summary>
public sealed record CreationFailedStatusEvent : StatusEvent
{
public required uint Code { get; init; }
public required string Reason { get; init; }
public required string Name { get; init; }
}

View file

@ -272,6 +272,7 @@ public static class StatusEventParser
T = t,
SessionId = sessionId,
Code = RequireUInt32(root, "code"),
Reason = RequireString(root, "reason"),
Name = RequireString(root, "name"),
};