erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

docs(vm1): closeout - AP-232 for the translucent detail blend weight; sampler test pins the production constant

Browse source 
Opus narrow re-review of ae651312: APPROVE. Closes its three residuals:
- AP-232 filed: retail's single-pass stage-1 OUTPUT alpha
  (MODULATE(TEXTURE, CURRENT) @0x0059c549) is the blend weight for a
  translucent subset; acdream's two-draw model is exact for opaque
  subsets (fog identity pinned) and a bounded weight difference on
  translucent ones. Distinct from AP-34 (queue order). Owed since
  05970306.
- TerrainAtlas.DetailSamplerDescription names the production sampler
  (WRAP/LINEAR x3 per ACRender::SetDetailSurfaceInternal @0x006b6280);
  the test now asserts that constant's properties instead of a
  test-local copy.
- Plan VM1 section: fragment now described as fogged; VM1 marked CLOSED
  with the Holtburg measurement (+2.17/+0.57/+0.16 vs predicted
  +2.2/+0.66/+0.16) and the detail-on cost (+0.3-0.5 ms CPU at Arwic).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-22 22:50:06 +02:00
parent ae6513126e
commit dcdd102824
5 changed files with 24 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/AcDream.App.Tests/Rendering/TerrainAtlasDetailTextureTests.cs
View file

@ -65,7 +65,10 @@ public sealed class TerrainAtlasDetailTextureTests
},
};
IGpuSampler sampler = device.CreateSampler(GpuSamplerDescription.WorldRepeat);
// The sampler is created from the PRODUCTION constant so that changing
// TerrainAtlas's choice (e.g. to a clamp sampler) fails the property
// assertions below rather than being forwarded unnoticed.
IGpuSampler sampler = device.CreateSampler(TerrainAtlas.DetailSamplerDescription);
MethodInfo method = typeof(TerrainAtlas).GetMethod(
"TryCreateDetailTexture",
@ -92,7 +95,7 @@ public sealed class TerrainAtlasDetailTextureTests
// point-filtered UI sampler.
GpuRecordedTextureRegistration registration = Assert.Single(
device.Calls.OfType<GpuRecordedTextureRegistration>());
Assert.Equal(GpuSamplerDescription.WorldRepeat, registration.Sampler);
Assert.Equal(TerrainAtlas.DetailSamplerDescription, registration.Sampler);
Assert.Equal(GpuFilter.Linear, registration.Sampler.MinFilter);
Assert.Equal(GpuFilter.Linear, registration.Sampler.MagFilter);
Assert.Equal(GpuMipFilter.Linear, registration.Sampler.MipFilter);