fix(chat): / and @ are equivalent command prefixes (retail parity)
Retail treats / and @ interchangeably for commands, but two client-side
layers broke the / spelling for server commands:
- ChatCommandRouter refused ANY unknown /verb with a local "Unknown
command" guess — so /tele, /ci, /acehelp never reached ACE even
though ACE supports them. The guard is gone; the server is now the
single authority on what's a valid command (ACE replies "Unknown
command: x" itself).
- ChatInputParser passed unknown /verbs through as literal speech.
ACE's GameActionTalk only intercepts the @ form on the wire (the /
acceptance in CommandManager is the server CONSOLE path), so the
parser now rewrites unknown /xyz -> @xyz.
Both command pass-throughs (@ and rewritten /) now also force the Say
channel: GameActionTalk (0x0015) is the only wire action ACE parses
commands on — previously a command typed with a chat channel active
would broadcast as channel speech.
Phase J Tier 4 ("/-text must never broadcast as speech") still holds:
letter-verbed input goes out as an @command (never speech), and
command-shaped-but-verbless input ("/", "//shrug") is refused locally
by a narrow router guard.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
parent
59ea3252cd
commit
d3cab1ab10
5 changed files with 141 additions and 51 deletions
|
|
@ -16,11 +16,12 @@ namespace AcDream.UI.Abstractions.Panels.Chat;
|
|||
/// <item><c>/say</c> with no message → <c>null</c></item>
|
||||
/// <item><c>/t</c> with no target / no message → <c>null</c></item>
|
||||
/// <item><c>/r</c> with no <c>lastTellSender</c> → <c>null</c></item>
|
||||
/// <item>unknown <c>/xyz</c> verb → fall through to default channel
|
||||
/// carrying the literal text (matches holtburger
|
||||
/// <c>handle_slash_command</c> default arm at line ~744 — they
|
||||
/// send <c>ClientCommand::Talk(command)</c> with the original
|
||||
/// slash-prefixed string)</item>
|
||||
/// <item>unknown <c>/xyz</c> verb → rewritten to <c>@xyz</c> and passed
|
||||
/// through on the default channel. Retail treats / and @ as
|
||||
/// equivalent command prefixes; ACE's <c>GameActionTalk</c> only
|
||||
/// intercepts the <c>@</c> form on the wire. Deliberate divergence
|
||||
/// from holtburger's literal fall-through (which would SAY the
|
||||
/// command text out loud).</item>
|
||||
/// <item>multi-word <c>/t</c> target: first whitespace token is target,
|
||||
/// rest is message (matches Rust <c>split_once</c> semantics)</item>
|
||||
/// </list>
|
||||
|
|
@ -122,8 +123,12 @@ public static class ChatInputParser
|
|||
return Parse(substituted, defaultChannel, lastTellSender, lastOutgoingTellTarget);
|
||||
}
|
||||
// Unknown @-verb — keep the original @ so ACE recognizes
|
||||
// it server-side when the message arrives via Talk.
|
||||
return new ParsedInput(defaultChannel, null, trimmed);
|
||||
// it server-side. Always emit as Say: ACE's GameActionTalk
|
||||
// (the 0x0015 Talk action) is the ONLY wire path that parses
|
||||
// @commands — on a chat channel the text would broadcast as
|
||||
// ordinary channel speech. Retail likewise resolves commands
|
||||
// before channel routing.
|
||||
return new ParsedInput(ChatChannelKind.Say, null, trimmed);
|
||||
}
|
||||
|
||||
// /say <msg>
|
||||
|
|
@ -165,11 +170,18 @@ public static class ChatInputParser
|
|||
return null;
|
||||
}
|
||||
|
||||
// Unknown slash command: holtburger falls back to Talk(literal).
|
||||
// We mirror that — emit on the default channel with the
|
||||
// slash-prefixed text intact so the server treats it as speech.
|
||||
// No special-case for known-but-unimplemented verbs; the user's
|
||||
// text round-trips so their intent isn't silently dropped.
|
||||
// Unknown slash verb: retail treats / and @ as equivalent command
|
||||
// prefixes, but ACE's GameActionTalk only intercepts the @ form on
|
||||
// the wire (a /-prefixed Talk is plain speech server-side). Rewrite
|
||||
// to @ and emit as Say — same reasoning as the unknown-@ branch at
|
||||
// the top: only the Talk action parses commands. (Deliberate
|
||||
// divergence from holtburger's literal fall-through, which would
|
||||
// SAY "/ci 629" out loud.)
|
||||
if (trimmed.Length > 1 && trimmed[0] == '/' && char.IsLetter(trimmed[1]))
|
||||
return new ParsedInput(ChatChannelKind.Say, null, "@" + trimmed.Substring(1));
|
||||
|
||||
// Plain speech (no recognized verb): emit on the default channel
|
||||
// so the user's text round-trips instead of being silently dropped.
|
||||
return new ParsedInput(defaultChannel, null, trimmed);
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue