fix(chargen): Campaign CC CC6b-MOUNT review fix round — F1-F13

Fixes every finding from the dual-lens review of 34c6fceab0 (architectural
PASS-with-items, retail-fidelity FAIL). Re-derived every decomp citation
against docs/research/named-retail/acclient_2013_pseudo_c.txt directly
rather than trusting the reviewer's transcription.

Wrap/normalize semantics (F1): CycleIndex's decrement-from-Unset landed on
0; the decomp's shared decrement tail (label_47f065/label_47f6d9, the same
switch the headgear ring was ported from) computes new=cur-1=-2 on the raw
signed int32, which wraps to count-1 — matching headgear's own ring shape.
Also ports the spin body-click normalize-and-write-back retail's cases
0xa5-0xae all share (NormalizeChoiceOnSelect), which acdream had dropped
entirely. Flips the one test that pinned the wrong expectation and adds
select-zone coverage no prior test isolated.

Heritage gate (F3): Update's Gearknight/Olthoi/OlthoiAcid branches reset
SetChoice(FACE)/SetSelection(HAIR) unconditionally, not only when Clothes
was showing — a conditional gate stranded Nose/Mouth as the current part
under a Face-tab session.

Doc corrections propagated everywhere they repeated (F4, F5, F6, plus the
plan doc's own CC6b-MOUNT ledger row for F1/F3): the gmBarberUI heading
citation conflated PostInit with InitializePage; Random's Appearance
disable was mislabeled a placeholder when it's really AP-212's unported
RandomizeAppearance/RandomizeClothing gap; the master-page doc still called
the Appearance page content-inert after this campaign made it real.

Visual substitutions widened (F2): AP-215 named only two of the Appearance
page's swatch/spin substitutions. Ports the two cheap ones directly —
current-part highlight via SetSelection's SetState(1)/SetState(6), routed
through the existing UiButtonStateMachine.Normal/Highlight ids and
IUiDatStateful.TrySetRetailState seam (installed-DAT-confirmed
ToggleBehavior=true on all nine spins); the shade scrollbar's SetVisible(0)
for Eyes vs acdream's Enabled=false. Files the other five (DoColorSpots,
the inert GradCircle, spin-caption/heritage-caption loss, the Skin-spin
MoveTo reposition, the Gearknight-boundary randomize calls) as new register
rows AP-216..AP-220 and corrects the plan doc's false claim that AP-215
already named the GradCircle.

Unlocked DAT read (F7, BLOCKER): ChargenPreviewController.Rebuild called
ChargenAppearanceFactory.TryCompose outside _datLock while the very next
line correctly locked TryBuildAnimated — CC6a's own F4 class of bug,
reintroduced at this catalog's first production call site. Wrapped in the
same lock; documented the invariant on ChargenAppearanceCatalog itself.

One-shot preview mount (F8): LivePresentationComposition reads
ChargenPreviewViewportWidget once, but its underlying mount
(CharacterCreationUiMountCoordinator) is explicitly retryable while this
GPU-resource composition pass is not — unlike PaperdollViewportWidget,
which IS eager/non-retryable, so the "mirrors Paperdoll" doc claim was
false. Retrofitting cross-frame retry here would mean restructuring this
composition's one-shot contract for every private viewport (paperdoll,
creature appraisal) and FrameRootComposition's fixed frame-group array —
out of this round's blast radius. Corrected the doc and made the failure
loud (a diagnostic log) instead of silent.

Dispose leak (F9): ChargenPreviewController.Dispose left the preview
WorldEntity referenced by the leased renderer until the renderer's own,
later disposal. Releases it on its own teardown now.

Test-quality items (F10, F11, F13): pinned the spin arrow widths
(47px, both arrows) the 174 zone boundary is derived from, plus a
controller test for the previously-uncovered select zone. Measured the
shade scrollbar's authored orientation instead of assuming it — it is
VERTICAL (33x85) — which is a real production bug: UiScrollbar only routed
scalar-mode mouse events when Horizontal was true, so the shade control
never fired in production. Added OnVerticalScalarEvent/DrawVerticalScalar
mirroring the existing horizontal scalar path. Converted
ChargenPreviewControllerTests from silent-pass [Fact] to the shared
InstalledDatFactAttribute skip-reporting pattern.

Adjudication (F12): AD-101's retirement leaves TryBeginFinish's four local
refusals (NoName/AttributeCreditsUnspent/AlreadyPending/RosterFull) with no
heritage/gender gate — currently latent since Finish stays hard-disabled
this round. Amended the campaign plan's CC5 slice scope to require BOTH a
heritage/gender refusal AND a real RandomizeCharacter port before the
connected user gate opens Finish; noted the interaction on AP-214's own
register row. No CC5 implementation in this commit.

Gates: dotnet build -c Release green across the full solution. App suite
(Release, ACDREAM_PROBE_LIVE_MOUNT=1) 5223/3 skips, Runtime suite
1713/0 — both clean across repeated runs. A full-solution run surfaced
three pre-existing, previously-documented flakes unrelated to this change
(Streaming.LandblockBuildFactoryTests/LandblockPresentationPipelineTests
#402, Core.Net.Tests.NakEmissionTests loss soak) — each confirmed passing
in isolation, consistent with their known full-suite-parallelism-timing
history; none touch any file this commit changes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

src/AcDream.App/Composition/LivePresentationComposition.cs

@@ -997,6 +997,31 @@ internal sealed class LivePresentationCompositionPhase
         // Same "both arms exist, needs a dispatcher + the retained-UI
         // viewport widget" shape as paperdoll/creature-appraisal above —
         // this is the THIRD private creature viewport, not a new pattern.
+        //
+        // Fix round F8 disposition: unlike paperdoll's PaperdollViewportWidget
+        // (an eager, non-retryable auto-property — see that property's own
+        // corrected doc comment), ChargenPreviewViewportWidget is
+        // computed-through a coordinator (CharacterCreationUiMountCoordinator)
+        // that IS explicitly retryable/idempotent across frames. This
+        // composition pass itself runs EXACTLY ONCE, synchronously, inside
+        // GameWindow.OnLoad — if the coordinator's mount hasn't succeeded
+        // yet at this exact instant, this block is skipped and NEVER
+        // retried; the coordinator's own later per-frame retries (driven
+        // from RetailUiRuntime.Tick) can still complete the CONTROLLER mount
+        // afterward, but this GPU-side renderer/viewport binding will not
+        // pick that up. DECIDED at the review: this composition pass is a
+        // one-shot GPU-resource wiring step (matching paperdoll's and
+        // creature-appraisal's own one-shot binding in this exact method,
+        // and PublishLivePresentation's own "set exactly once" invariant a
+        // few hundred lines below) — retrofitting cross-frame retry here
+        // would mean restructuring this whole composition's one-shot
+        // contract (and the fixed PrivateEntityViewportFrameGroup array
+        // FrameRootComposition builds from its result) for every private
+        // viewport, not just this one; that is out of this fix round's
+        // blast radius. What changes here instead: a loud diagnostic
+        // instead of a silent skip, so an operator can SEE the preview
+        // failed to bind this session rather than the symptom (dead
+        // zoom/rotate buttons) reading as unexplained.
         CompositionAcquisitionScope.CompositionAcquisitionLease<
             ChargenPreviewRenderer>? chargenPreviewLease = null;
         ChargenPreviewController? chargenPreviewController = null;
@@ -1053,6 +1078,18 @@ internal sealed class LivePresentationCompositionPhase
                     }
                 });
         }
+        else if (dispatcherLease.Resource is not null)
+        {
+            // Fix round F8: dispatcher is available but the mount coordinator
+            // hadn't resolved ChargenPreviewViewportWidget by this one-shot
+            // pass — loud instead of silent, since the coordinator's own
+            // later per-frame retries cannot recover this GPU-side binding
+            // (see this block's own disposition comment above).
+            Console.WriteLine(
+                "[UI] chargen preview viewport unavailable at composition "
+                + "time — the Appearance page's zoom/rotate controls and "
+                + "3D preview will not function this session.");
+        }
         Fault(LivePresentationCompositionPoint.PrivateCreatureViewportsCreated);
 
         var envCellFrustum = new WbFrustum();