erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

docs(vtank): slice 7 fix round C item F4 — cite issue #491 on the buff-wiring gap

Browse source 
BuffSettings.ExtraBuffSpellNames/BlacklistedBuffFamilyNames and their two
Buffs-tab tooltips already documented that BuffPlan.Build does not
consume these sets yet, but didn't name the tracked issue. Both field
doc comments and both tooltip strings now cite #491 (filed on the
campaign branch: "shown and persisted, not consumed by BuffPlan.Build
until slice 4"), so anyone hitting the gap has a concrete issue to read
instead of just a prose warning.

Text/comment-only change; no test behavior to pin. Full solution build
green, MossTank suite 678/678, App markup/plugin filter 203/203.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-09-07 15:42:09 +02:00
parent 0724761adb
commit d20ad47c51
2 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/AcDream.Plugins.MossTank/BuffPlan.cs
View file

@ -93,9 +93,9 @@ public sealed class BuffSettings
/// SelfBuffChoiceView-style picker) but does NOT wire this set into
/// <see cref="BuffPlan.Build"/>'s cast selection — resolving an
/// exemplar name to a real castable line/tier is genuine casting-
/// algorithm behavior, out of this UI-parity slice's scope (tracked as
/// a real, accepted gap in the slice 7 plan ledger, owned by a future
/// Campaign VT behavior slice).
/// algorithm behavior, out of this UI-parity slice's scope. Tracked as
/// issue #491 ("shown and persisted, not consumed by BuffPlan.Build
/// until slice 4"), owned by a future Campaign VT behavior slice.
/// </summary>
public ISet<string> ExtraBuffSpellNames { get; } =
new HashSet<string>(StringComparer.Ordinal);
@ -104,7 +104,7 @@ public sealed class BuffSettings
/// VTank's AntiExtraBuffSpells table (defaultsettings.usd:1-6) — named
/// buff families to never cast even if the school-driven rules above
/// would otherwise want them. Same storage-only scope note as
/// <see cref="ExtraBuffSpellNames"/>.
/// <see cref="ExtraBuffSpellNames"/> — issue #491.
/// </summary>
public ISet<string> BlacklistedBuffFamilyNames { get; } =
new HashSet<string>(StringComparer.Ordinal);

12
src/AcDream.Plugins.MossTank/mosstank.xml
View file

@ -510,20 +510,20 @@
<group x="8" y="42" w="848" h="194" visible="{BuffsVisible}">
<!-- Fix round B item 14 (owner honesty rule): BuffPlan.Build does not
read this set at all yet — a real, tracked wiring gap (see
BuffSettings.ExtraBuffSpellNames' own doc comment), not a display
bug. The tooltip says so instead of implying these names already
affect what gets cast. -->
BuffSettings.ExtraBuffSpellNames' own doc comment; issue #491),
not a display bug. The tooltip says so instead of implying these
names already affect what gets cast. -->
<label x="4" y="0" w="320" h="16" text="Extra Buff Spells" color="#FFE8DEC3"
tooltip="Named spell exemplars — stored and shown here, not yet used when choosing what to cast." />
tooltip="Named spell exemplars — stored and shown here, not yet used when choosing what to cast (#491)." />
<list x="4" y="18" w="320" h="116" rowheight="17"
items="{ExtraBuffRows}" selected="{SelectedExtraBuffIndex}"
onchange="{DeleteExtraBuffAt}" tooltip="Click a row to remove it." />
<button x="4" y="138" w="120" h="18" text="Add..." onclick="{ShowExtraBuffPicker}" />
<!-- Fix round B item 14: same honesty note as Extra Buff Spells — not
yet read by BuffPlan.Build. -->
yet read by BuffPlan.Build (issue #491). -->
<label x="524" y="0" w="320" h="16" text="Blacklisted Buff Families" color="#FFE8DEC3"
tooltip="Named buff families — stored and shown here, not yet used when choosing what to cast." />
tooltip="Named buff families — stored and shown here, not yet used when choosing what to cast (#491)." />
<list x="524" y="18" w="320" h="116" rowheight="17"
items="{BlacklistedBuffFamilyRows}" selected="{SelectedBlacklistedBuffIndex}"
onchange="{DeleteBlacklistedBuffFamilyAt}" tooltip="Click a row to remove it." />