feat(render): Campaign V slice V4a - port TextRenderer/BitmapFont/DebugLineRenderer/TextureCache onto IGpuDevice
TextRenderer, BitmapFont, DebugLineRenderer, and TextureCache's UI-texture
upload path (GetOrUploadRenderSurface/UploadRgba8) now issue every draw and
resource creation through the pinned IGpuDevice/IGpuFrame/IGpuPassEncoder
RHI contract instead of raw GL. This is the RHI's first real production
consumer - V0-V3 only established the contract, GL backend skeleton, and a
shader-dialect migration with no live GL exercise. TextRenderer owns one
IGpuPipeline (ui_text shader, straight-alpha blend, depth disabled) and
allocates a per-bucket ring each Flush; BitmapFont's atlas texture is
created and uploaded via device.CreateTexture/.Upload; DebugLineRenderer
mirrors the same one-pipeline-per-Flush shape for its line-list draws.
World-path TextureCache methods (GetOrUpload, the raw-GL layer-array
upload) are untouched - still legacy GL, still out of scope.
Frame lifecycle: GpuDeviceFrameLifetime (RenderFrameOrchestrator.cs) wraps
IGpuDevice.BeginFrame()/IGpuFrame.End() inside the existing
IRenderFrameLifetime bracket HostInputCameraCompositionPhase already opens
per callback, additively - no frame-graph restructuring. Ported renderers
reach the frame via ICurrentGpuFrameSource, a plain interface (not a
delegate field) so WorldSceneDiagnosticsController keeps passing its
existing "no stored window/delegate" architectural-conformance test.
Two real bugs surfaced by actually exercising the RHI against a live GL
context (nothing here was previously reachable before this slice):
- GlGpuDevice.BeginFrame() now resets the render-state cache every frame.
The cache assumes it is the sole writer of GL program/blend/depth/cull
state, which was true while it had zero real consumers, but every
still-legacy renderer (WbDrawDispatcher, terrain, particles, EnvCells)
mutates that same GL state directly and never informs the cache. Once a
legacy renderer ran between two RHI binds, the cache's belief about the
current GL program went stale, so a later BindPipeline(text shader)
skipped re-issuing glUseProgram and the following push-constant upload
threw GL_INVALID_OPERATION against whatever program was actually bound.
Reset() at the frame boundary is the same defensive move BeginPass
already makes after a forced clear (see its comment); it costs one
redundant state application on the frame's first bind.
- GL_MULTISAMPLE has no representation in the pinned contract. Added a
GL-backend-internal Multisample field to GlRenderStateSnapshot/Changes,
computed from GpuPipelineDescription.SampleCount at BindPipeline time -
mirrors how Vulkan bakes MSAA into the pipeline instead of a separate
toggle.
Collateral, scoped to keep the port real rather than a stub:
- GpuTextureSlot (Unassigned = uint.MaxValue, NOT 0) now flows through
every consumer of TextureCache.GetOrUploadRenderSurface/UploadRgba8 and
TextRenderer.DrawSprite - the entire retained UI layer, since a pervasive
Func<uint,(uint,int,int)> sprite-resolve delegate threads through nearly
every UI element/controller. Every prior `== 0` / `!= 0` "no texture"
check became `.IsAssigned` / `!.IsAssigned`; slot 0 is a real assigned
slot (the device's default white texture), so the old sentinel would
have produced live visual regressions if left in place.
- GpuTextureSlot/IGpuDevice/IGpuFrame are internal, so ~270 previously
public AcDream.App types that touched them (directly or transitively)
are now internal too - safe, since AcDream.App is an exe with no
external project references; only the two test projects consume it, via
InternalsVisibleTo. A handful of unrelated types the sweep caught
(ElementInfo/ImportedLayout's property-bag hierarchy, several enums used
as public [Theory] parameters, CursorFeedbackSnapshot's DragAcceptState)
were reverted back to public where making them internal would have
either cascaded into unrelated files or broken xUnit's public-member
discovery.
- ExternalViewportTextureBridge (new) registers the still-raw-GL FBO
color textures PrivateEntityViewportRenderer/PaperdollViewportRenderer
produce (V4g's scope) into the device's texture table for
UiViewport.TextureHandle, via a temporary
GlGpuDevice.RegisterExternalColorTexture escape hatch (internal, not
part of IGpuDevice) deleted when V4g ports those viewports.
- TextRenderGlStateScope.cs and its test deleted: the pipeline description
now bakes what it used to restore by hand.
- ResourceCleanupGroupTests/GlTextureOwnershipTests: the two source-text
conformance tests keyed to TextRenderer's old multi-resource
construction shape (Shader + per-flight FrameBufferSet array + white
texture + tracked VAO/VBO, all via ResourceCleanupGroup) no longer apply
- that shape is gone, replaced by one IGpuPipeline created through
IGpuDevice. The construction-order test is deleted; the checked-commit
texture-creation check now targets GlGpuTexture (which already used
the same GlResourceCommand.CreateName primitive before this slice).
Gates:
- dotnet build -c Release: 0 warnings, 0 errors (AcDream.App has
TreatWarningsAsErrors).
- dotnet test tests/AcDream.App.Tests -c Release: 3,840 passed / 3
skipped (was 3,843/3 entering this slice - net 3 fewer tests:
TextRendererFailureSafetyTests.cs deleted (2, tested the now-deleted
TextRenderGlStateScope) plus the one retired ResourceCleanupGroupTests
method). Full solution: 8,908 passed / 5 skipped across all nine test
projects.
- Offline pixel gate (tools/run-offline-pixel-gate.ps1, parent ec414d60
vs this commit): differing fraction 0.318% (1,791/563,200 compared
pixels), above the 0.001 threshold. Investigated pixel-by-pixel rather
than waved through: a diff heatmap plus 4x crops at the differing
clusters show zero differences anywhere in the retained UI, terrain,
scenery, or static meshes - every differing pixel sits on continuously-
animated ambient content (flying-insect sprites over the swamp, foliage
sparkle/dew glints) whose exact phase depends on elapsed wall-clock
time, the same category the gate's own sky-masking rationale already
documents and the campaign doc's coverage table explicitly excludes
("Not covered - particles"). Confirming evidence: two same-commit
captures at HEAD compare clean against each other (0.0025%), and two
same-commit captures at the parent compare clean against each other
(0.0044%) - only base-vs-head is consistently elevated, which is what
frame-pacing drift from genuinely new per-frame RHI work (BeginFrame,
ring resets, the render-state reset above) would produce against a
fixed wall-clock capture deadline, not a rendering defect. Recommend a
quick user visual check of this capture pair alongside the automated
result, matching how V2c's particle work was already handled in this
campaign (flagged for user visual confirmation rather than blocked on
an automated gate that cannot cover animated content).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik
parent
ec414d60cd
commit
ceec3bc440
334 changed files with 3660 additions and 3840 deletions
|
|
@ -1,4 +1,4 @@
|
|||
using System;
|
||||
using System;
|
||||
using System.Numerics;
|
||||
using AcDream.Core.Rendering;
|
||||
|
||||
|
|
@ -10,7 +10,7 @@ namespace AcDream.App.Rendering;
|
|||
/// <c>docs/research/named-retail/acclient_2013_pseudo_c.txt:95505</c>):
|
||||
/// a STATEFUL sought position that converges from the current swept
|
||||
/// viewer toward the desired boom pose (<c>CameraManager::UpdateCamera</c>
|
||||
/// 0x00456660 → <c>viewer_sought_position</c>, the #180 fix), 5-frame
|
||||
/// 0x00456660 → <c>viewer_sought_position</c>, the #180 fix), 5-frame
|
||||
/// velocity-averaged slope-aligned heading frame, mouse-input low-pass
|
||||
/// filter. Pseudocode:
|
||||
/// <c>docs/research/2026-07-06-camera-sought-position-pseudocode.md</c>.
|
||||
|
|
@ -27,7 +27,7 @@ namespace AcDream.App.Rendering;
|
|||
/// Spec: <c>docs/superpowers/specs/2026-05-18-retail-chase-camera-design.md</c>.
|
||||
/// </para>
|
||||
/// </summary>
|
||||
public sealed class RetailChaseCamera : ICamera
|
||||
internal sealed class RetailChaseCamera : ICamera
|
||||
{
|
||||
// ICamera surface.
|
||||
public Vector3 Position { get; private set; }
|
||||
|
|
@ -35,19 +35,19 @@ public sealed class RetailChaseCamera : ICamera
|
|||
/// <summary>
|
||||
/// The cell the collided viewer-sphere ended in (retail <c>viewer_cell =
|
||||
/// sphere_path.curr_cell</c>). Roots the render mode + indoor visibility + the portal
|
||||
/// side-test in <see cref="GameWindow"/> (Phase W single-viewpoint V1) — the ONE viewpoint.
|
||||
/// side-test in <see cref="GameWindow"/> (Phase W single-viewpoint V1) — the ONE viewpoint.
|
||||
/// Equals the passed player cell when camera collision is off / the probe is null.
|
||||
/// </summary>
|
||||
public uint ViewerCellId { get; private set; }
|
||||
public float Aspect { get; set; } = 16f / 9f;
|
||||
public float FovY { get; set; } = MathF.PI / 3f;
|
||||
public Matrix4x4 View { get; private set; } = Matrix4x4.Identity;
|
||||
// Near plane = retail Render::znear = 0.1 m (decomp :342130/:342173/:1101867 —
|
||||
// Render::SetFOVRad sets 0.1 flat; the legacy set_vdst variant is max(0.1, vdst·0.25)).
|
||||
// Near plane = retail Render::znear = 0.1 m (decomp :342130/:342173/:1101867 —
|
||||
// Render::SetFOVRad sets 0.1 flat; the legacy set_vdst variant is max(0.1, vdst·0.25)).
|
||||
// MUST be smaller than the 0.3 m camera-collision sphere (PhysicsCameraCollisionProbe.
|
||||
// ViewerSphereRadius): with a 1.0 m near, a wall the collided eye sits 0.3 m from
|
||||
// falls INSIDE the near plane and is clipped away — pressing the camera into a corner
|
||||
// let you see straight through the wall (§4 corner residual). History: 0.1 landed
|
||||
// falls INSIDE the near plane and is clipped away — pressing the camera into a corner
|
||||
// let you see straight through the wall (§4 corner residual). History: 0.1 landed
|
||||
// (137b4f2), was reverted (8bd3492) after correlating with missing indoor textures,
|
||||
// and re-landed once #110 resolved: the textures were the pre-existing #105
|
||||
// staged-texture-flush drop (WbMeshAdapter.Tick), and 0.1 merely raised its trigger
|
||||
|
|
@ -55,12 +55,12 @@ public sealed class RetailChaseCamera : ICamera
|
|||
public Matrix4x4 Projection =>
|
||||
Matrix4x4.CreatePerspectiveFieldOfView(FovY, Aspect, 0.1f, 5000f);
|
||||
|
||||
// ── Public tunables (per-instance) ──────────────────────────────
|
||||
// ── Public tunables (per-instance) ──────────────────────────────
|
||||
|
||||
/// <summary>Length of the viewer_offset vector. Retail default ≈ 2.61.</summary>
|
||||
/// <summary>Length of the viewer_offset vector. Retail default ≈ 2.61.</summary>
|
||||
public float Distance { get; set; } = 2.61f;
|
||||
|
||||
/// <summary>Angle of the camera above the heading-frame XY plane. Retail default ≈ 0.291 rad (16.7°).</summary>
|
||||
/// <summary>Angle of the camera above the heading-frame XY plane. Retail default ≈ 0.291 rad (16.7°).</summary>
|
||||
public float Pitch { get; set; } = 0.291f;
|
||||
|
||||
/// <summary>
|
||||
|
|
@ -92,27 +92,27 @@ public sealed class RetailChaseCamera : ICamera
|
|||
public const float PitchMax = 1.4f;
|
||||
|
||||
// Retail CameraManager::UpdateCamera convergence-snap thresholds (decomp
|
||||
// acclient_2013_pseudo_c.txt, 0x00456fcd–0x00457035). SnapEpsilon = 2 ×
|
||||
// 0.000199999995 m ≈ 0.0004 m — the per-frame translation step below which retail
|
||||
// acclient_2013_pseudo_c.txt, 0x00456fcd–0x00457035). SnapEpsilon = 2 ×
|
||||
// 0.000199999995 m ≈ 0.0004 m — the per-frame translation step below which retail
|
||||
// freezes the boom at an exact fixed point (0x00456fe1). RotCloseEpsilon =
|
||||
// 0.000199999995 — the Frame::close_rotation tolerance (0x00456fdd). Without the
|
||||
// 0.000199999995 — the Frame::close_rotation tolerance (0x00456fdd). Without the
|
||||
// snap, Vector3.Lerp asymptotes forever and the boom drifts at rest, walking the eye
|
||||
// across a portal plane and flipping the viewer cell → the indoor flicker.
|
||||
// across a portal plane and flipping the viewer cell → the indoor flicker.
|
||||
private const float SnapEpsilon = 0.000199999995f * 2f;
|
||||
private const float RotCloseEpsilon = 0.000199999995f;
|
||||
|
||||
// ── Stateful camera state (retail SmartBox's two Positions) ─────
|
||||
// ── Stateful camera state (retail SmartBox's two Positions) ─────
|
||||
//
|
||||
// _soughtEye = retail viewer_sought_position — the persisted sweep
|
||||
// _soughtEye = retail viewer_sought_position — the persisted sweep
|
||||
// TARGET, re-derived each frame from the current swept
|
||||
// viewer (NOT from itself).
|
||||
// _publishedEye = retail viewer — the swept, published eye; the base
|
||||
// _publishedEye = retail viewer — the swept, published eye; the base
|
||||
// of next frame's interpolation (SmartBox::
|
||||
// PlayerPhysicsUpdatedCallback passes &this->viewer
|
||||
// into UpdateCamera, 0x00452d75).
|
||||
// _dampedForward = the sought's look direction. Sweeps translate but
|
||||
// never rotate, so the viewer's rotation is always the
|
||||
// previous sought rotation — one field serves both.
|
||||
// previous sought rotation — one field serves both.
|
||||
|
||||
private readonly Vector3[] _velocityRing = new Vector3[5];
|
||||
private int _velocityCount;
|
||||
|
|
@ -121,12 +121,12 @@ public sealed class RetailChaseCamera : ICamera
|
|||
private Vector3 _dampedForward = new(1f, 0f, 0f);
|
||||
private bool _initialised;
|
||||
|
||||
// Mouse-filter state — shared by FilterMouseDelta entrypoint.
|
||||
// Mouse-filter state — shared by FilterMouseDelta entrypoint.
|
||||
private float _lastMouseDeltaX;
|
||||
private float _lastMouseDeltaY;
|
||||
private float _lastFilterTimeSec;
|
||||
|
||||
// ── Per-frame entry point ────────────────────────────────────────
|
||||
// ── Per-frame entry point ────────────────────────────────────────
|
||||
|
||||
/// <summary>
|
||||
/// Advance the camera one frame. Caller passes the player's current
|
||||
|
|
@ -177,7 +177,7 @@ public sealed class RetailChaseCamera : ICamera
|
|||
// 5. Stateful sought position (#180). Retail CameraManager::UpdateCamera
|
||||
// (0x00456660) interpolates FROM THE CURRENT SWEPT VIEWER toward the
|
||||
// desired pose and assigns the result to viewer_sought_position
|
||||
// (SmartBox::PlayerPhysicsUpdatedCallback 0x00452d60) — the sweep
|
||||
// (SmartBox::PlayerPhysicsUpdatedCallback 0x00452d60) — the sweep
|
||||
// target converges onto whatever the collision produced last frame
|
||||
// and re-extends gradually. The full-length ideal boom is never swept
|
||||
// directly. Pseudocode:
|
||||
|
|
@ -193,15 +193,15 @@ public sealed class RetailChaseCamera : ICamera
|
|||
{
|
||||
float tAlpha = ComputeDampingAlpha(CameraDiagnostics.TranslationStiffness, dt);
|
||||
float rAlpha = ComputeDampingAlpha(CameraDiagnostics.RotationStiffness, dt);
|
||||
// interpolate_origin(viewer.frame → desired, t) — the lerp base is the
|
||||
// interpolate_origin(viewer.frame → desired, t) — the lerp base is the
|
||||
// VIEWER (0x00456fae), not the previous sought. The forward base is the
|
||||
// viewer's rotation ≡ the previous sought forward (sweeps never rotate).
|
||||
// viewer's rotation ≡ the previous sought forward (sweeps never rotate).
|
||||
Vector3 candidateEye = Vector3.Lerp(_publishedEye, targetEye, tAlpha);
|
||||
Vector3 candidateForward = Vector3.Normalize(Vector3.Lerp(_dampedForward, targetForward, rAlpha));
|
||||
|
||||
// Retail UpdateCamera dead-band (0x00456fcd–0x00457035): once the step
|
||||
// Retail UpdateCamera dead-band (0x00456fcd–0x00457035): once the step
|
||||
// off the viewer is sub-epsilon in translation AND rotation, the sought
|
||||
// parks EXACTLY ON the viewer — an exact fixed point instead of an
|
||||
// parks EXACTLY ON the viewer — an exact fixed point instead of an
|
||||
// asymptote. Kills the at-rest drift AND the residual micro-jitter when
|
||||
// pressed against a wall. See ApplyConvergenceSnap + SnapEpsilon.
|
||||
(_soughtEye, _dampedForward, _) =
|
||||
|
|
@ -209,13 +209,13 @@ public sealed class RetailChaseCamera : ICamera
|
|||
}
|
||||
|
||||
// 5b. Spring-arm collision (A8.F / #180). Retail SmartBox::update_viewer
|
||||
// (0x00453ce0) sweeps the viewer_sphere pivot → viewer_sought_position
|
||||
// (0x00453ce0) sweeps the viewer_sphere pivot → viewer_sought_position
|
||||
// and publishes the swept result as the viewer (set_viewer(curr_pos, 0)
|
||||
// — the sought is NOT reset on success). Pressed against a wall, the
|
||||
// — the sought is NOT reset on success). Pressed against a wall, the
|
||||
// sweep ray extends only one interpolation step past the contact, so a
|
||||
// knife-edge r±ε graze can move the eye by at most that step (sub-mm at
|
||||
// knife-edge r±ε graze can move the eye by at most that step (sub-mm at
|
||||
// high fps) instead of re-solving the full-length boom with its 0.27 m
|
||||
// bistable contact pair — the #180 strobe fix.
|
||||
// bistable contact pair — the #180 strobe fix.
|
||||
Vector3 publishedEye = _soughtEye;
|
||||
// The viewer cell defaults to the player cell (collision off / null probe); the sweep
|
||||
// overwrites it with the swept cell (retail viewer_cell). Always set so GameWindow has a
|
||||
|
|
@ -227,13 +227,13 @@ public sealed class RetailChaseCamera : ICamera
|
|||
publishedEye = swept.Eye;
|
||||
ViewerCellId = swept.ViewerCellId;
|
||||
// Total-failure fallback = retail set_viewer(player_pos, reset_sought=1)
|
||||
// (update_viewer :92886 and the cell==0 bail :92775 — both surface here as
|
||||
// (update_viewer :92886 and the cell==0 bail :92775 — both surface here as
|
||||
// ViewerCellId == 0): the sought resets to the returned position and
|
||||
// re-extends from there.
|
||||
if (swept.ViewerCellId == 0)
|
||||
_soughtEye = swept.Eye;
|
||||
}
|
||||
// Retail viewer — the base of next frame's interpolation (step 5).
|
||||
// Retail viewer — the base of next frame's interpolation (step 5).
|
||||
_publishedEye = publishedEye;
|
||||
|
||||
// 6. Publish renderer surface (from the collided eye; rotation stays the
|
||||
|
|
@ -241,7 +241,7 @@ public sealed class RetailChaseCamera : ICamera
|
|||
Position = publishedEye;
|
||||
View = Matrix4x4.CreateLookAt(publishedEye, publishedEye + _dampedForward, new Vector3(0f, 0f, 1f));
|
||||
|
||||
// 7. Auto-fade translucency — uses the published (collided) eye so the
|
||||
// 7. Auto-fade translucency — uses the published (collided) eye so the
|
||||
// player fades once the eye is pulled in close.
|
||||
float d = Vector3.Distance(publishedEye, pivotWorld);
|
||||
PlayerTranslucency = ComputeTranslucency(d);
|
||||
|
|
@ -295,12 +295,12 @@ public sealed class RetailChaseCamera : ICamera
|
|||
/// </summary>
|
||||
public (float outX, float outY) FilterMouseDelta(float rawX, float rawY, float weight, float nowSec)
|
||||
{
|
||||
// X first — advances the shared timestamp.
|
||||
// X first — advances the shared timestamp.
|
||||
float x = FilterMouseAxis(rawX, weight, nowSec,
|
||||
ref _lastMouseDeltaX, ref _lastFilterTimeSec, CameraDiagnostics.MouseLowPassWindowSec);
|
||||
// Y uses a throwaway timestamp so the within-window check still uses the original delta
|
||||
// (X already advanced _lastFilterTimeSec to nowSec; if Y reused it, the within-window
|
||||
// check would be 0 < windowSec which is always true — which is what we want here, since
|
||||
// check would be 0 < windowSec which is always true — which is what we want here, since
|
||||
// both axes are sampled simultaneously and should both blend.).
|
||||
float yTimeShadow = _lastFilterTimeSec - 1f; // force within-window path for the Y axis
|
||||
float y = FilterMouseAxis(rawY, weight, nowSec,
|
||||
|
|
@ -308,7 +308,7 @@ public sealed class RetailChaseCamera : ICamera
|
|||
return (x, y);
|
||||
}
|
||||
|
||||
// Math primitives — pure, internal-static for unit-testability.
|
||||
// Math primitives — pure, internal-static for unit-testability.
|
||||
|
||||
/// <summary>
|
||||
/// Pick the heading vector that drives the camera basis. Mirrors
|
||||
|
|
@ -316,8 +316,8 @@ public sealed class RetailChaseCamera : ICamera
|
|||
/// path (decomp <c>acclient_2013_pseudo_c.txt:95644-95795</c>):
|
||||
/// <list type="number">
|
||||
/// <item><description>Base heading is the player's facing
|
||||
/// direction in world space — <c>(cos yaw, sin yaw, 0)</c>
|
||||
/// — not the velocity vector. Velocity only gates whether
|
||||
/// direction in world space — <c>(cos yaw, sin yaw, 0)</c>
|
||||
/// — not the velocity vector. Velocity only gates whether
|
||||
/// slope-alignment fires.</description></item>
|
||||
/// <item><description>If <paramref name="alignToSlope"/> is off
|
||||
/// OR the player's horizontal velocity is below epsilon (i.e.
|
||||
|
|
@ -337,7 +337,7 @@ public sealed class RetailChaseCamera : ICamera
|
|||
/// </summary>
|
||||
/// <param name="avgVelocity">5-frame averaged player velocity in world space.</param>
|
||||
/// <param name="yaw">Player facing yaw + any orbit offset, radians.</param>
|
||||
/// <param name="isOnGround">Player's <c>transient_state & 1</c> — does <paramref name="contactPlaneNormal"/> describe a valid contact plane?</param>
|
||||
/// <param name="isOnGround">Player's <c>transient_state & 1</c> — does <paramref name="contactPlaneNormal"/> describe a valid contact plane?</param>
|
||||
/// <param name="contactPlaneNormal">Player's current contact plane normal in world space; ignored when <paramref name="isOnGround"/> is false.</param>
|
||||
/// <param name="alignToSlope">User-tunable; when false skips the projection and returns the flat facing direction.</param>
|
||||
internal static Vector3 ComputeHeading(
|
||||
|
|
@ -356,15 +356,15 @@ public sealed class RetailChaseCamera : ICamera
|
|||
// |vx| > 0.0002 AND |vy| > 0.0002 (decomp :95704, :95713). The
|
||||
// horizontal-magnitude-squared form is a cleaner equivalent.
|
||||
// Without this, the airborne path would still project against
|
||||
// world up (no-op) which is fine — but the standing-jump case
|
||||
// world up (no-op) which is fine — but the standing-jump case
|
||||
// wants the historical `direction` fallback that retail uses.
|
||||
float hMagSq = avgVelocity.X * avgVelocity.X + avgVelocity.Y * avgVelocity.Y;
|
||||
if (hMagSq < 1e-4f) return baseHeading;
|
||||
|
||||
// Pick the projection plane normal:
|
||||
// grounded → contact_plane.N (slope-aligned camera basis)
|
||||
// airborne → world up (projection becomes a no-op because
|
||||
// baseHeading is already in the XY plane — but
|
||||
// grounded → contact_plane.N (slope-aligned camera basis)
|
||||
// airborne → world up (projection becomes a no-op because
|
||||
// baseHeading is already in the XY plane — but
|
||||
// keeping the code path uniform makes the airborne
|
||||
// case impossible to swing vertically).
|
||||
Vector3 normal;
|
||||
|
|
@ -375,13 +375,13 @@ public sealed class RetailChaseCamera : ICamera
|
|||
|
||||
// Project baseHeading onto plane perpendicular to normal:
|
||||
// projected = forward - normal * dot(forward, normal)
|
||||
// On flat ground this is a no-op (dot ≈ 0). On a slope the
|
||||
// On flat ground this is a no-op (dot ≈ 0). On a slope the
|
||||
// projected vector gains a Z component matching the slope angle,
|
||||
// which tilts the camera basis with the terrain.
|
||||
float dot = Vector3.Dot(baseHeading, normal);
|
||||
Vector3 projected = baseHeading - normal * dot;
|
||||
|
||||
// Degenerate: facing nearly parallel to normal (rare — would
|
||||
// Degenerate: facing nearly parallel to normal (rare — would
|
||||
// require player rotated to face into the ground). Fall back to
|
||||
// the unprojected base heading.
|
||||
if (projected.LengthSquared() < 1e-4f) return baseHeading;
|
||||
|
|
@ -449,7 +449,7 @@ public sealed class RetailChaseCamera : ICamera
|
|||
Vector3 right;
|
||||
if (MathF.Abs(forward.Z) > 0.99f)
|
||||
{
|
||||
// Near-vertical forward — use world +X as the secondary axis.
|
||||
// Near-vertical forward — use world +X as the secondary axis.
|
||||
right = Vector3.Normalize(Vector3.Cross(forward, new Vector3(1f, 0f, 0f)));
|
||||
}
|
||||
else
|
||||
|
|
@ -495,7 +495,7 @@ public sealed class RetailChaseCamera : ICamera
|
|||
/// <summary>
|
||||
/// Exponential-damping rate per frame.
|
||||
/// <c>alpha = clamp(stiffness * dt * 10, 0, 1)</c>. At
|
||||
/// <c>stiffness=0.45</c>, <c>dt=1/60</c> → <c>~0.075</c>
|
||||
/// <c>stiffness=0.45</c>, <c>dt=1/60</c> → <c>~0.075</c>
|
||||
/// (~150 ms half-life). Matches retail's
|
||||
/// <c>x_1 = stiffness * dt * 10</c> formulation.
|
||||
/// </summary>
|
||||
|
|
@ -508,11 +508,11 @@ public sealed class RetailChaseCamera : ICamera
|
|||
}
|
||||
|
||||
/// <summary>
|
||||
/// Retail <c>CameraManager::UpdateCamera</c> dead-band (decomp 0x00456fcd–0x00457035).
|
||||
/// Retail <c>CameraManager::UpdateCamera</c> dead-band (decomp 0x00456fcd–0x00457035).
|
||||
/// After the per-frame lerp, if the translation step from <paramref name="viewerEye"/>
|
||||
/// (the interpolation base = the current swept viewer) to <paramref name="candidateEye"/>
|
||||
/// is below <see cref="SnapEpsilon"/> AND the rotation step is below
|
||||
/// <see cref="RotCloseEpsilon"/>, retail returns the VIEWER unchanged — the sought
|
||||
/// <see cref="RotCloseEpsilon"/>, retail returns the VIEWER unchanged — the sought
|
||||
/// parks exactly on it (<c>return viewer</c>, 0x00457025). Returns <c>frozen=true</c>
|
||||
/// with the viewer state in that case; otherwise <c>frozen=false</c> with the candidate.
|
||||
/// Both conditions are required (retail couples origin + rotation in the test),
|
||||
|
|
@ -562,7 +562,7 @@ public sealed class RetailChaseCamera : ICamera
|
|||
/// distance. <c>0</c> = fully opaque, <c>1</c> = fully transparent.
|
||||
/// Opaque at and beyond 0.45 m; fully transparent at and within
|
||||
/// 0.20 m; linear ramp between. Matches retail's <c>CameraSet::
|
||||
/// UpdateCamera</c> distance check (decomp :97703–97725).
|
||||
/// UpdateCamera</c> distance check (decomp :97703–97725).
|
||||
/// </summary>
|
||||
internal static float ComputeTranslucency(float distance)
|
||||
{
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue