erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 1

docs: file #465 — post-campaign panel fill for retail's cathedral seam leak, with the regression guards and A/B acceptance

Browse source 
Owner decision 2026-09-03: an improvement on retail, deferred until G4
passes; retail mode off; registered when built.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-09-03 21:02:06 +02:00
parent 455de7f24d
commit cddd3d236b
1 changed files with 19 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

19
docs/ISSUES.md
View file

@ -39,6 +39,25 @@ confirmed closed by the owner, 11 need a focused live gate, and 43 are safe to
remain closed. See
[`docs/research/2026-08-28-owner-closed-issue-validity-audit.md`](research/2026-08-28-owner-closed-issue-validity-audit.md).
## #465 — [post-OVERHAUL] Panel fill: paint unreachable interior portal polygons as opaque panels (improve on retail's cathedral seam leak)
**Status:** OPEN, DEFERRED by owner decision 2026-09-03 — a post-campaign improvement, NOT for Campaign OVERHAUL v2 (which reproduces retail's frame, leak included, as its axiom). Do not start before G4 passes and the campaign closes.
**Severity:** cosmetic (retail-visible artifact, owner-confirmed in the 2013 and EoR clients at the cathedral floating stairs)
**Component:** the interior flood's exit/portal handling in `WalkFrameDriver` / `RetailPViewPassExecutor` (S3–S4 machinery)
**The hole:** at the cathedral seam bands a portal polygon is authored that leads to a cell the flood does not reach from the pose, so retail neither draws it as a wall nor sees through it, and whatever the frame painted earlier (the exterior slab after the landscape pass) stays visible in the opening — the "panels = never-drawn portal polys" family of the PV campaign. Retail's clear-and-seal trick only re-stamps exit portals of flooded cells, so an unflooded seam opening is never covered.
**The improvement:** after the flood, for an INTERIOR root only, every portal polygon of a flooded cell whose destination cell is NOT in the flood (and is not the outside, `0xFFFF`) is drawn as an opaque panel at its own true depth with the owning cell's wall material (or a neutral fill — an authored choice retail never made), before the interior repaint. Retail mode leaves it OFF; it is a registered deviation (a new AD row) and a deliberate post-retail option in the same class as the extended particle range.
**Regression risk (owner asked 2026-09-03) — where it can bite, and the guards:**
1. A genuine opening whose destination the flood skipped only because the portal fell outside the narrowed view at that pose but part of the polygon is still on screen (grazing angles at seam bands): painting it hides a legitimate view. Guard: fill only polygons that are ENTIRELY outside every live view of their owning cell (the walk already computes per-cell view slices), never a polygon any view admits.
2. Buildings seen from outside (look-in floods) and outdoor roots: an exit portal that is unreachable from outside is the far side of a doorway. Guard: interior roots only, never `0xFFFF` portals, never look-in floods.
3. Stacked cells where the "unreachable" cell is loaded and visible through ANOTHER path (the cathedral's balconies): the panel would occlude a cell that is drawn later through a different portal. Guard: skip a polygon whose destination cell is in the flood via any route (membership of the flood set, not just this portal's path).
4. Texture choice: a wall-material panel can look like a wall where retail shows a hole into darkness; a neutral fill can look like a black slab. Both are guesses; the owner picks per side-by-side.
5. Ordinary dungeons: every portal is normally reachable, so the fill draws nothing there — but that is the claim to PROVE, not assume: the acceptance is an A/B screenshot sweep over the full §10 matrix plus the two ordinary dungeons with the fill on and off, zero pixel change everywhere except the cathedral seams, plus the transcript unchanged (the fill is a leaf draw, not a walk event).
**Acceptance:** owner side-by-side at the cathedral floating stairs (retail leak gone, nothing else changed), the A/B sweep above pixel-clean, register row filed, default OFF in retail mode; the option's name and default documented in `docs/launch-options.md` or the Options panel per the settings digest.
## #464 — Camera zoomed out in the cathedral stairwell leaves the cell; the frame roots from outside and draws the hall through the walls
**Status:** OPEN — owner-reported 2026-09-03 night during the S3 double-check (Release at `ea76a3803`); every other pose PASSED the owner's look.