erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

docs: correct the color-table doc's refuted main-window-filter claim (re-review S1)

Browse source 
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-10 13:24:33 +02:00
parent 69e355bbdf
commit ccab53d9a1
1 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
docs/research/2026-08-09-chat-retail-color-table.md
View file

@ -326,8 +326,16 @@ There is nothing for acdream to make configurable for retail parity.
when the option changes. `ChatInterface::TypeIsActive @0x004F2F10` tests when the option changes. `ChatInterface::TypeIsActive @0x004F2F10` tests
`(1ULL << type) & m_llTextTypeFilter`. Two consequences: `(1ULL << type) & m_llTextTypeFilter`. Two consequences:
- `UpdateFromPlayerModule` early-returns when `m_eWindowID == 0`, so the - ~~`UpdateFromPlayerModule` early-returns when `m_eWindowID == 0`, so the
**main window has no user filter** — it keeps the `PostInit` default. main window has no user filter~~ **CORRECTED 2026-08-10 (CH6a/b review,
`docs/research/2026-08-10-ch6ab-review-findings.md`):** the main chat
window is `m_eWindowID == 8` and the floaties are 2–5;
`m_eWindowID == 0` is the UNAUTHORED constructor default, which is what
that early-return guards. The main window's filter IS user-settable —
`gmChatOptionsUI::InitOptions @0x0049FC60` builds its filter block at
`SetUserData` id 8 (default `0x00000000_FBFFFFFF` @0x0049FDC9, with a
dedicated high-dword Society child @0x0049FEFB, so 0x20 Society is
opt-in on main).
- `RecvNotice_DisplayFinalStringInfo` displays when - `RecvNotice_DisplayFinalStringInfo` displays when
`windowId == m_eWindowID` (explicitly addressed — e.g. command output uses `windowId == m_eWindowID` (explicitly addressed — e.g. command output uses
`m_idCurrentCommandSource`) **or** `windowId == 0 && TypeIsActive(type)` `m_idCurrentCommandSource`) **or** `windowId == 0 && TypeIsActive(type)`