diff --git a/CLAUDE.md b/CLAUDE.md index ad33cad1..ad590b94 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -168,10 +168,17 @@ PlayerModule blob with Apply/logout/480 s flushes, header always `0x460`); headless bots declare options by name (OP7's live bot-vs-ACE gate PASSED); OP9 retired the dead F11 `SettingsPanel`/`SettingsVM` surface and the `GameplaySettings` record outright. OP1/OP2/OP7/OP9 CLOSED through dual/ -combined Opus review; **OP3–OP6 + OP8 owe their connected user gates** — -script `docs/research/2026-08-11-campaign-op-test-script.md`, launch with -`ACDREAM_RETAIL_UI=1` (#372's blank-tabs half is FIXED at `057d8cd7`; its -Gameplay-buttons half needs the re-gate with the new click logs). Tail: +combined Opus review. **2026-08-14 re-gate round:** the whole gate-4 fix +batch (#372 both halves, #374, #375, #378–#382, #385) is USER-PASSED; the +OP8 first look filed + same-day-fixed #394/#395/#396 (authored 18px-serif +row-caption font; the retail `GetNameFromKey` key-name pipeline — DAT +tables `0x2300000A`/`0x2300000B`/`0x23000007` via GetDIDByEnum category 4, +OS-localized fallback, register AD-96; the `InitiateBinding` capture- +instruction WAIT dialog) plus the WaitDialog-type-0x19 crash (`2a81e813`, +live-verified no-crash). **STILL OWED: the full §OP3–§OP6 script sections +and §OP8's visual re-check** — script +`docs/research/2026-08-11-campaign-op-test-script.md`, launch with +`ACDREAM_RETAIL_UI=1`. Tail: #371, #373, AP-198/199/201/202/203. START at `claude-memory/project_settings_options_digest.md`. diff --git a/docs/ISSUES.md b/docs/ISSUES.md index ef7bfad5..f39bc608 100644 --- a/docs/ISSUES.md +++ b/docs/ISSUES.md @@ -26,7 +26,11 @@ What does NOT go here: ## #396 — Configure Keyboard: no capture-instruction dialog on a mapping-button click -**Status:** ROOT-CAUSED + FIXED (this commit) — pending the user's re-gate. +**Status:** ROOT-CAUSED + FIXED — pending the user's visual re-gate of the +dialog itself. The follow-up crash (`2a81e813`: the wait root's retail class +type 0x19 was unmapped in DatWidgetFactory, so the first mapping-button +click threw out of OnClick and killed the client) was live-verified fixed +2026-08-14 — the user exercised the mapping-button path, no crash. Filed 2026-08-14 at the OP8 re-gate (user report: "nothing happens when I press an option button", with the retail screenshot showing the instruction dialog). The OP8 port armed `InputDispatcher.BeginCapture` with no visible @@ -337,7 +341,8 @@ the menu). Register row AD-88 (unclear) tracks it. ## #385 — Options-panel dropdowns: gold left-aligned text + fixed 6-row popup (retail: white, centered, size-to-content) -**Status:** DONE 2026-08-13 (this commit). User gate report (Campaign OP +**Status:** DONE 2026-08-13 (this commit); re-gate USER-PASSED 2026-08-14. +User gate report (Campaign OP happy-testing round): every Config-tab dropdown (Sound Features, Resolution, …) drew its text yellow and left-aligned, and the popup a fixed 6 rows regardless of item count. All three symptoms were @@ -471,7 +476,7 @@ existing fixtures until the drift is understood. ## #382 — Floating chat-window tab buttons are invisible until first hovered -**Status:** ROOT-CAUSED + FIXED (this commit) — pending the user's re-gate. +**Status:** DONE — re-gate USER-PASSED 2026-08-14 (pass-1 re-check round). Filed 2026-08-11 at Campaign OP gate 4 (user report: nothing renders at rest on the four main-chat-window indicator buttons — `0x10000522`- `0x10000525`, `ChatWindowController.Indicator1Id`-`Indicator4Id` — hover @@ -552,8 +557,8 @@ needed. ## #381 — Options-panel footer (Apply/Reset/Defaults) needs an opaque backing field; list content shows through between the buttons -**Status:** ROOT-CAUSED + FIXED (this commit) — pending the user's -re-gate. Filed 2026-08-11 at Campaign OP gate 4 (user report). +**Status:** DONE — re-gate USER-PASSED 2026-08-14 (pass-1 re-check round). +Filed 2026-08-11 at Campaign OP gate 4 (user report). **ROOT CAUSE — confirmed a genuine acdream synthesis, retail authors no backing element either.** A live-DAT probe dumped the Character/Chat/ @@ -584,8 +589,8 @@ tabs.** ## #380 — Chat tab: the two opacity sliders are missing their retail row captions -**Status:** ROOT-CAUSED + FIXED (this commit) — pending the user's -re-gate. Filed 2026-08-11 at Campaign OP gate 4 (user report: "I also +**Status:** DONE — re-gate USER-PASSED 2026-08-14 (pass-1 re-check round). +Filed 2026-08-11 at Campaign OP gate 4 (user report: "I also miss the text next to the bars for Inactive and Active Opacity"). **ROOT CAUSE — a DAT-resident runtime catalog, not a compiled symbol, @@ -623,8 +628,8 @@ slider.** ## #379 — Chat-window opacity applies to ALL retained windows/panels, not only the chat windows -**Status:** ROOT-CAUSED + FIXED (this commit) — pending the user's -re-gate. Filed 2026-08-11 at Campaign OP gate 4 (user report: "When I +**Status:** DONE — re-gate USER-PASSED 2026-08-14 (pass-1 re-check round). +Filed 2026-08-11 at Campaign OP gate 4 (user report: "When I change the opacity for the chat window only the chatwindows shall change not the other panels"). @@ -656,8 +661,8 @@ slider position.** ## #378 — Config-tab dropdown menus render bare (no button well, no arrow) and no popup opens on click -**Status:** ROOT-CAUSED + FIXED (this commit) — pending the user's -re-gate. Filed 2026-08-11 at Campaign OP gate 4 (user screenshots: +**Status:** DONE — re-gate USER-PASSED 2026-08-14 (pass-1 re-check round). +Filed 2026-08-11 at Campaign OP gate 4 (user screenshots: retail's Resolution row shows a sunken value well + green arrow cap; acdream's same rows rendered as bare text with no button chrome). @@ -759,8 +764,11 @@ modes; validate against the monitor's mode list first). ## #375 — Configure Keyboard screen renders as a visual mess at the live mount (missing button/tab captions, buttons outside the window, overlapping text) -**Status:** ROOT-CAUSED + FIXED (this commit) — pending the user's -re-gate. Filed 2026-08-11 at Campaign OP's second connected gate (user +**Status:** DONE — re-gate USER-PASSED 2026-08-14: the OP8 first look +showed captioned tabs/buttons inside the frame (this issue's own defects); +its three NEW findings — wrong caption font, raw enum key names, missing +capture dialog — are #394/#395/#396, filed + fixed the same day. +Filed 2026-08-11 at Campaign OP's second connected gate (user report, verbatim): "all buttons lacked descriptive text", "some buttons were outside of the window", "lacked text in the tabs", "text next to the buttons was overlapping. Looked like a mess." @@ -806,8 +814,8 @@ throughout, again): ## #374 — Config tab: picking a new Resolution does not resize the window (live gate failure) -**Status:** ROOT-CAUSED + FIXED (this commit) — pending the user's -re-gate. Filed 2026-08-11 at Campaign OP's second connected gate ("I was +**Status:** DONE — re-gate USER-PASSED 2026-08-14 (pass-1 re-check round). +Filed 2026-08-11 at Campaign OP's second connected gate ("I was not able to change the screen resolution"). **ROOT CAUSE — popup hit-test priority, a UiRoot-level routing hole.** @@ -874,9 +882,10 @@ false prompts as new breakage until this lands. ## #372 — Options panel: Character/Chat/Config tabs render BLANK on screen and most Gameplay buttons do nothing (connected-gate failure) -**Status:** BLANK-TABS ROOT-CAUSED + FIXED (`c3ed32fb` probe, fix this -commit); the Gameplay-buttons observation still needs a re-gate. Filed -2026-08-11 at Campaign OP's first connected gate. +**Status:** DONE — blank-tabs half fixed (`c3ed32fb` probe + fix at +`057d8cd7`); the Gameplay-buttons half re-gate USER-PASSED 2026-08-14 +(pass-1 re-check round). Filed 2026-08-11 at Campaign OP's first connected +gate. **ROOT CAUSE (blank tabs) — found + fixed.** `UiTemplateListBox` creates its row viewport lazily (post-Build, during a page controller's `Bind`) at