erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix(ui): OP3 re-review residuals R1/R2/R3 (coordinator pass)

Browse source 
R1: the gate script no longer promises a timestamp prefix on the Magic
macro lines — acdream renders no chat timestamps yet (the Display
Timestamps consumer is OP4 scope; no chat-log file exists, TS-69). A
bare light-blue transcript line is the CORRECT gate outcome.

R2: IsGrounded yields null (silent) for a NULL controller in player
mode — the prior pattern returned false and fired the mid-air refusal
retail cannot produce in that state; comments now match the code.

R3: the dormant-ActivePageChanged pin now applies the real stimulus —
every authored tab button on a dormant host must carry NO click handler
(RetailTabBinding.SetClick never ran), which is AD-73's actual dormancy
mechanism; SwitchTo deliberately has no guard.

OP3 is CLOSED: dual APPROVE-WITH-FIXES -> fix round 386076af ->
re-review REOPEN(narrow) -> this pass. Connected gate now READY.

Full Release suite: 12,956 passed / 4 skipped / 0 failed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-11 03:25:40 +02:00
parent 7b60e71b85
commit cb3346907d
3 changed files with 33 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

13
docs/research/2026-08-11-campaign-op-test-script.md
View file

@ -108,11 +108,14 @@ for this slice, not a bug.
session sees zero lines (everything already at the macro's target).
**These six lines are byte-verified `RetailLogTextType.Magic` (0x07),
NOT the client-local refusal type** — expect LIGHT BLUE text in the
SCROLLING CHAT TRANSCRIPT (not the transient SpewBox overlay), with
a timestamp prefix, same as any other Magic-colored system line. If
you see bright red text in a transient 5-second overlay instead (the
ClientLocal/SpewBox look used by the mid-air refusal and UA/RA
above), that is the pre-fix-round bug — report it.
SCROLLING CHAT TRANSCRIPT (not the transient SpewBox overlay). Do
NOT expect a timestamp prefix: acdream renders no chat timestamps
yet (the Display Timestamps consumer is OP4 scope, and there is no
chat-log file — TS-69), so a bare light-blue line is CORRECT here
(OP3 re-review R1). If you see bright red text in a transient
5-second overlay instead (the ClientLocal/SpewBox look used by the
mid-air refusal and UA/RA above), that is the pre-fix-round bug —
report it.
**Known, registered gap (TS-74): acdream has no persistent
"turn to face camera" mouse-turning MODE yet, so this button changes
stored preferences and sends the wire bit, but you will not see the