From ca62d745fb1f0a9a271684a675a06c975b4749fb Mon Sep 17 00:00:00 2001 From: Erik Date: Fri, 29 May 2026 10:46:36 +0200 Subject: [PATCH] =?UTF-8?q?docs:=20A8.F=20spec=20=E2=80=94=20correct=20Ste?= =?UTF-8?q?p=200=20(A8=20batch=20already=20committed=20in=205dc4140)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The 2026-05-28 handoff's "uncommitted A8 batch" is stale: 5dc4140 landed the batch after the handoff. Step 0 reduces to stripping the leftover ACDREAM_A8_DIAG_* flags (still present in RuntimeOptions + GameWindow). Co-Authored-By: Claude Opus 4.7 --- ...hase-a8f-portal-frame-visibility-design.md | 21 +++++++++++-------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/docs/superpowers/specs/2026-05-29-phase-a8f-portal-frame-visibility-design.md b/docs/superpowers/specs/2026-05-29-phase-a8f-portal-frame-visibility-design.md index c6a536e..0d38490 100644 --- a/docs/superpowers/specs/2026-05-29-phase-a8f-portal-frame-visibility-design.md +++ b/docs/superpowers/specs/2026-05-29-phase-a8f-portal-frame-visibility-design.md @@ -9,7 +9,8 @@ portal-clip port that completes A8's indoor-visibility goal by fixing the residu **Builds on (does NOT supersede):** [2026-05-26-phase-a8-wb-full-port-design.md](2026-05-26-phase-a8-wb-full-port-design.md) — the A8 WB full port (per-building cell scoping + stencil pipeline + EntitySet -partition + RenderOutsideIn). That work ships as the baseline commit (Step 0 below). +partition + RenderOutsideIn). That work is **already committed** (`5dc4140`, landed after the +2026-05-28 handoff was written); Step 0 below only strips its leftover diagnostic flags. **Required predecessor reading:** - [docs/research/2026-05-28-a8-cellar-flap-option2-handoff.md](../../research/2026-05-28-a8-cellar-flap-option2-handoff.md) @@ -89,7 +90,7 @@ no exterior drawn). A8.F restores WB's structure as part of the rewrite — this |---|---|---| | Q1 | Which fix family? | **A — port retail's `PView` clip-frame recursion** (faithful-to-retail). Faithful-to-WB is off the table because WB itself flaps. | | Q2 | Staging of the three wire-ins? | **All three in one pass** before the first visual gate (full faithful port). | -| Q3 | Commit the uncommitted A8 batch first? | **Yes** — strip `ACDREAM_A8_DIAG_*`, keep the `ACDREAM_PROBE_VIS` apparatus, commit as the baseline (Step 0). | +| Q3 | Baseline before A8.F? | A8 batch is **already committed** (`5dc4140`, landed after the handoff). Step 0 reduces to stripping the leftover `ACDREAM_A8_DIAG_*` flags (still present in `RuntimeOptions`/`GameWindow`), keeping the `ACDREAM_PROBE_VIS` apparatus. | | Q4 | Per-cell *geometry* clip (#2) enforcement on GPU? | **Observable-result fidelity, not naive per-cell stencil** — depth-test for opaque cells (same observable result, keeps MDI batching); targeted stencil only where it changes the picture (translucent geometry; a cell with no depth occluder in front). | | Q5 | Phase label? | **A8.F** — added to the roadmap with this spec. | @@ -225,17 +226,19 @@ Struct fields (`acclient.h`): `CEnvCell`:32072, `portal_view_type`:32346, `porta --- -## Step 0 — commit the A8 baseline (first execution step) +## Step 0 — strip leftover A8 diag flags (first execution step) -Before any A8.F code: -1. Remove the temporary `ACDREAM_A8_DIAG_*` step-disable flags from `RuntimeOptions` and their - use sites in `RenderInsideOutAcdream` (the `diagDisableStep*` locals). +The A8 WB-port batch is **already committed** (`5dc4140`, landed after the 2026-05-28 handoff +was written), so there is no batch to commit — `5dc4140` is the baseline and the known-good +"working-with-cellar-flap" rollback point. What remains is the diag-flag cleanup that the +batch did not include: +1. Remove the temporary `ACDREAM_A8_DIAG_*` step-disable flags from `RuntimeOptions` (~18 + occurrences) and their use sites in `RenderInsideOutAcdream` (the `diagDisableStep*` locals, + ~6 in GameWindow.cs). 2. **Keep** the `ACDREAM_PROBE_VIS` apparatus (`[buildings]`/`[envcells]`/`[stencil]`/ `[draworder]` probes) — it is the visual-gate evidence tool. 3. `dotnet build` green, `dotnet test` green (App baseline ~90; Core baseline maintained). -4. Commit the working A8 batch as the clean baseline (`feat(render): Phase A8 — WB full port - baseline (per-building scoping + stencil pipeline)` or similar), so A8.F's diff is - reviewable in isolation and there is a known-good "working-with-cellar-flap" rollback point. +4. Commit the cleanup, so A8.F's diff starts from a flag-free baseline. ---