erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

feat(journal): QJ3/QJ4/QJ5 — both remaining tabs are live

Browse source 
The Journal panel now has all three tabs working: contracts from the server,
and a per-character notebook with its searchable index.

Two ported details that a reimplementation would get wrong in a way nobody
notices until they lose work:

Every navigation button commits the current page FIRST. Retail's
ListenToElementMessage @0x004968D0 calls SaveThisPage on the way out of all
five of them, which is why paging away never eats what you just typed. And the
file is written when the notes page is HIDDEN, not only at exit — a crash then
costs at most the page in front of you.

The search is CASE-SENSITIVE across label, title and notes: retail compares
with wcsstr and lowercases neither side. Making it insensitive would be
friendlier and would be a divergence, so it is ported as-is with a test naming
the reason. The double-click window is a full SECOND (m_LastClickTime + 1.0,
@0x00493158) rather than the 500 ms the item-interaction path uses, and firing
it clears the tracker so a third click does not re-open.

Two unlabelled buttons on the notes page turned out to be prev/next: retail
switches on (idElement - 0x10000565), which names them without a caption. The
running-timer readout is authored at the same x as the three day/hour/minute
boxes, so the strip is one or the other — that overlap is the data form of
ShowEditableTimer versus ShowRunningTimer, not a layout bug.

DeltaTimeToString moved out of the contract code into AcDream.Core.Ui. It is
ClientUISystem's, not gmContractsUI's — the journal timer and the contract
repeat countdown both call it, and it only lived under Quests because that was
its first caller. A bridge class to reach it across features would have been
the wrong answer to the same observation.

The journal file lives in the client's data directory rather than beside the
executable, for the same reason the chat log does. Register QJ-1.

Campaign QJ slices 3, 4 and 5 of 5 — code-complete, connected gate owed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-21 15:42:05 +02:00
parent 536d17456d
commit c5cc8ae5fc
15 changed files with 1380 additions and 76 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/AcDream.Core.Tests/Quests/ContractProgressTextTests.cs
View file

@ -1,5 +1,6 @@
using System;
using AcDream.Core.Quests;
using AcDream.Core.Ui;
namespace AcDream.Core.Tests.Quests;
@ -32,7 +33,7 @@ public sealed class ContractProgressTextTests
[InlineData(2592000 + 86400 + 3600 + 61, "1mo 1d 1h 1m 1s")]
public void DeltaTimeFormatsLargestUnitFirstAndAlwaysShowsSeconds(
double seconds, string expected)
=> Assert.Equal(expected, ContractProgressText.DeltaTimeToString(seconds));
=> Assert.Equal(expected, RetailDurationText.Format(seconds));
[Fact]
public void DeltaTimeHasNoTrailingSpace()
@ -42,7 +43,7 @@ public sealed class ContractProgressTextTests
// gives "Done (30s to Repeat)" with a double space — and the
// instruction is invisible in the decompiler output, so this is the
// assertion that pins the byte-level reading.
string text = ContractProgressText.DeltaTimeToString(30);
string text = RetailDurationText.Format(30);
Assert.Equal("30s", text);
Assert.DoesNotContain(" ", ContractProgressText.Build(
@ -52,7 +53,7 @@ public sealed class ContractProgressTextTests
[Fact]
public void DeltaTimeTruncatesTowardZeroLikeRetailsFtol()
{
Assert.Equal("59s", ContractProgressText.DeltaTimeToString(59.99));
Assert.Equal("59s", RetailDurationText.Format(59.99));
}
// ── the stage arms ──────────────────────────────────────────────────