fix(ui): night-round review — F9/F10/F12 register + structure riders
F9: filed register row AD-108 for MapPageController.ResolveSwallowedIcon — the standalone re-import of the Map tab's player/house icons, which m_pMap's own Type-1 UiButton authoring swallows as dat children (UiButton.ConsumesDatChildren). This adaptation was implemented but never had a register row. F10: extracted the popup-locator pair (0x10000395/0x21000041), previously duplicated as three separately-cited private constants across UiItemSlot.cs, RetailTooltipPresenter.cs, and MapPageController.cs, into ONE public pair on RetailTooltipPresenter (SharedPopupSkinRootElementId/SharedPopupSkinLayoutDid) with a single canonical citation. The other two sites now reference it instead of carrying their own copy. F12: fixed TS-85's SetTooltip-site arithmetic. The register (and a mirrored ISSUES.md log entry) claimed "15 known sites, all accounted for" — recounting the row's own enumerated list finds 17 distinct sites (the tally had dropped gmPaperDollUI::UpdateItemSlotTooltip @0x004A52EF and undercounted by one more), of which 16 are ported and one — UIElement_Text::RecalculateTruncation @0x00466F80, the headline highest-volume site sub-mechanism (1) itself named as deliberately deferred — was never actually closed. The "all 15 accounted for" close was wrong twice over: wrong count, and a site the row's own text already scoped as open. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
parent
df062d2eda
commit
c403f57815
6 changed files with 64 additions and 49 deletions
|
|
@ -174,7 +174,7 @@ public sealed class MapHousePanelControllerTests
|
|||
// GetTooltipText()) — the retail SetTooltip/m_TTText mechanism, NOT
|
||||
// the DAT-authored AuthoredTooltipText path. The popup-skin locator
|
||||
// is unconditionally required even on the runtime-text path (see
|
||||
// MapPageController.MarkerTooltipRootElementId's doc).
|
||||
// RetailTooltipPresenter.SharedPopupSkinRootElementId's doc).
|
||||
Assert.All(townMarkers, c => Assert.NotEqual(0u, c.AuthoredTooltipRootElementId));
|
||||
Assert.All(townMarkers, c => Assert.NotEqual(0u, c.AuthoredTooltipLayoutDid));
|
||||
Assert.All(townMarkers, c => Assert.IsType<UiButton>(c));
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue