docs(overhaul): close S5 c2 landing gate

This commit is contained in:
Erik 2026-09-04 18:44:50 +02:00
parent ef819eedf5
commit c3ac20b2ad
4 changed files with 102 additions and 5 deletions

View file

@ -1,7 +1,7 @@
# Campaign OVERHAUL v2 — S5 consumers, material, and closeout packet
**Status:** S5-c1 LANDED + lead graphical gate PROVISIONAL PASS 2026-09-04;
S5-c2 CONTRACTED below.
**Status:** S5-c1 and S5-c2 LANDED + lead graphical gates PROVISIONAL PASS
2026-09-04; S5-c3 is next.
**Branch:** `claude/campaign-w-retail-frame-walk`.
**Gate:** G4 remains unpassed. Nothing merges to `main` before G4.
@ -885,3 +885,65 @@ One narrow independent production/gate-honesty re-review then checks only the
two corrected documents against the three clean artifact directories and the
two recorded review verdicts. A new correction-worthy finding would be fix
round 2; a third fix round still stops S5-c2 and is written up.
## 16. S5-c2 review closeout, landing, and lead graphical A/B — 2026-09-04
The narrow independent production/gate-honesty re-review returned **PASS**
with no finding. It checked the two-document fix-round scope, all three clean
artifact directories and manifests, both InstalledDat filters and counts, the
two unchanged nonpassing-identity comparisons, and the recorded sequential
review verdicts. No production or test file changed in fix round 1.
The reviewed scratch stack maps to the campaign branch as follows:
- implementation `603d4bbb05e` -> `a4de2efc4`;
- lead fix-round contract `0025bb2c097` -> `048027e71`;
- evidence/status correction `521f5edda54` -> `ef819eedf`.
The integrated campaign tree at `ef819eedf` is byte-identical to reviewed
scratch tip `521f5edda54`. Fresh campaign verification passed: Release solution
build 0 warnings / 0 errors and the affected 137-test lane 137/137. The
official clean evidence remains §14.7's hermetic 16,768/16,768, broader
InstalledDat 468 pass / 10 documented fail / 1 skip, and canonical
InstalledDat 385 pass / the same 10 documented fail / 1 skip, with all
manifests and nonpassing identities verified.
The first graphical run at
`logs/selfgate-20260904-182320-s5c2-shadow-selection` captured all seven
transition PNGs and reached its checkpoint without a fatal log entry, but its
route omitted `close-client`. GLFW exposes no main-window handle to the runner,
so the runner's graceful external close could not succeed. The owner was away
from the computer and explicitly directed the lead to close it; after the
graceful path was exhausted, the lead terminated only the verified campaign
PID. This run is retained as visual evidence but its teardown is **FAIL**, not
the valid c2 gate.
The lead then added an out-of-tree A/B route with an in-client `close-client`
step and built exact parent `5c106bcdf` in detached worktree
`s5-c2-ab-parent` (Release 0 warnings / 0 errors). Before each run ACE was UP on
UDP 9000 as PID 13340 and no graphical client was running. Exact evidence:
- parent: `s5-c2-ab-parent/logs/selfgate-20260904-183815-s5c2-parent-shadow-ab`;
- candidate:
`logs/selfgate-20260904-183925-s5c2-candidate-shadow-ab` at clean
`ef819eedf`.
Both runs produced all seven PNGs, exited 0, logged graceful logout confirmed,
left no client process, and contained no fatal/unhandled/device-lost/validation
match. Candidate metadata shows exact active selection rather than retained
topology fallback: 2,500 selected casters on the first high frame and 3,087
after re-enable, with four cascades and 26 draws; pack-off reports zero pack
work. Terrain, buildings, actors, UI, weather transitions, resize, and pack
off/on recovery remain present. The lead verdict for S5-c2's own scope is
**PROVISIONAL PASS pending owner inspection**.
The A/B also proves a conspicuous darkening on atmospheric re-enable is
pre-existing: exact parent and candidate both reproduce it. The receiver
shaders switch outdoor directional lighting from authored
`-uLights[0].dirAndRange` to `uShadowLightDirectionAndSource` whenever the
shadow flag becomes nonzero; the shadow-strength weight does not blend that
lighting-direction change. This is not an S5-c2 regression, but it is not
silently accepted as a solid-renderer result: issue #469 records it and IA-24
now names the gate-visible discontinuity. It must be resolved or explicitly
owner-accepted before G4. S5-c3 is next; G4 remains unpassed and nothing may
merge to `main`.