fix #435 (part 2, closes it): attribute the unowned probes — delete 7, reclassify 8, restore 1
Part 1 deleted probes whose owning issues were closed. These 14 named no issue at all, so each was traced to its introducing commit (git log -S) instead of guessed at. Attribution split them three ways: DELETED (7, investigations closed): ACDREAM_A8_DUMP_PV and ACDREAM_DUMP_LIVE_SPAWNS (Phase A8), ACDREAM_DUMP_CLOTHING (#37), ACDREAM_DUMP_EDGE_SLIDE (#32), ACDREAM_DUMP_STEPUP (L.2.3d-f), ACDREAM_DUMP_VENDOR (the vendor campaign, 25 call sites across 8 files), ACDREAM_DUMP_VITALS (#5, four independent read sites). VendorDiagnostics.cs went entirely. RECLASSIFIED (8, tools misfiled as probes): the DUMP_CELLS/DUMP_GFXOBJS fixture-extraction family (replay-harness tooling with a roundtrip test), PROBE_CELL (standing cell-transit tracer, pair of the permanent PROBE_RESOLVE), DUMP_SKY and HIDE_PART (generic isolation tools), and DUMP_STEEP_ROOF — which looked like an L.4 relic but observes LIVE divergence-register row AD-56; deleting it would have removed the only runtime lens on an active divergence. All moved to Permanent diagnostics with their attribution recorded. RESTORED (1): ACDREAM_DUMP_MOVE_TRUTH was deleted and un-deleted the same day. It is not a probe — the canonical nine-stop soak (run-connected-r6-soak.ps1) hard-fails every destination without its 'move-truth OUT' records, with a message that would misdirect the next operator. Under the no-workarounds rule the gate's mechanism is restored, not left broken with an IOU (#437, closed). Process lesson recorded on both issues: a closed owning issue is NOT sufficient to delete a probe — grep tools/ and the contract tests for consumers first. Also lands the owner-requested default-off invariant: every diagnostic in the codebase is inert until its env var is explicitly set. Exactly four flags default ON and none is a diagnostic — RETAIL_CHASE, CAMERA_COLLIDE, CAMERA_ALIGN_SLOPE, RETAIL_CLOSE_DEGRADES are retail behaviors wearing an A/B off-switch. That set is now FROZEN by LaunchOptionsDocumentationTests.OnlyTheFourRetailBehaviorFlagsDefaultOn; docs/launch-options.md's Conventions and CLAUDE.md state the rule, and CLAUDE.md now binds future probes to a documented row in the same commit. The client reads 137 environment variables (161 at audit start); 40 temporary probes remain, every one attributed. Full hermetic suite 15,322 passed / 0 failed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik
parent
0c5057c9ff
commit
c1e6e3da44
26 changed files with 256 additions and 693 deletions
|
|
@ -58,17 +58,6 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
/// </summary>
|
||||
private readonly RuntimeWorldTransitState _transit;
|
||||
|
||||
private int _received;
|
||||
private int _hydrated;
|
||||
private int _noPosition;
|
||||
private int _noSetup;
|
||||
private int _missingSetup;
|
||||
private int _noMesh;
|
||||
private int _noCycle;
|
||||
private int _zeroFramerate;
|
||||
private int _singleFrame;
|
||||
private int _missingPartFrames;
|
||||
|
||||
public DatLiveEntityProjectionMaterializer(
|
||||
RuntimeOptions options,
|
||||
IDatReaderWriter dats,
|
||||
|
|
@ -116,16 +105,6 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
|
||||
public void ResetSessionState()
|
||||
{
|
||||
_received = 0;
|
||||
_hydrated = 0;
|
||||
_noPosition = 0;
|
||||
_noSetup = 0;
|
||||
_missingSetup = 0;
|
||||
_noMesh = 0;
|
||||
_noCycle = 0;
|
||||
_zeroFramerate = 0;
|
||||
_singleFrame = 0;
|
||||
_missingPartFrames = 0;
|
||||
}
|
||||
|
||||
public bool TryMaterialize(
|
||||
|
|
@ -157,18 +136,10 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
if (appearanceUpdate is not null && expectedRecord is null)
|
||||
return false;
|
||||
|
||||
_received++;
|
||||
bool dumpLiveSpawns = _options.DumpLiveSpawns;
|
||||
DumpSpawn(canonicalSpawn, dumpLiveSpawns);
|
||||
|
||||
if (!_origin.IsKnown)
|
||||
return false;
|
||||
if (canonicalSpawn.Position is null || canonicalSpawn.SetupTableId is null)
|
||||
{
|
||||
if (canonicalSpawn.Position is null)
|
||||
_noPosition++;
|
||||
else
|
||||
_noSetup++;
|
||||
return false;
|
||||
}
|
||||
|
||||
|
|
@ -216,13 +187,6 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
_collisionAssets.CacheSetup(canonicalSpawn.SetupTableId.Value, setup);
|
||||
if (setup is null)
|
||||
{
|
||||
_missingSetup++;
|
||||
if (dumpLiveSpawns)
|
||||
{
|
||||
Console.WriteLine(
|
||||
$"live: DROP setup dat 0x{canonicalSpawn.SetupTableId.Value:X8} missing "
|
||||
+ $"(guid=0x{canonicalSpawn.Guid:X8})");
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
|
|
@ -248,14 +212,6 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
List<MeshRef> flattened = [.. SetupMesh.Flatten(setup, idleFrame)];
|
||||
IReadOnlyList<CreateObject.AnimPartChange> animPartChanges =
|
||||
canonicalSpawn.AnimPartChanges ?? Array.Empty<CreateObject.AnimPartChange>();
|
||||
bool dumpClothing = _options.DumpClothing && setup.Parts.Count >= 10;
|
||||
DumpClothingHeader(
|
||||
canonicalSpawn,
|
||||
setup,
|
||||
flattened,
|
||||
idleFrame,
|
||||
animPartChanges,
|
||||
dumpClothing);
|
||||
|
||||
foreach (CreateObject.AnimPartChange change in animPartChanges)
|
||||
{
|
||||
|
|
@ -273,17 +229,14 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
baseId => ResolveCollisionPart(baseId));
|
||||
|
||||
if (_options.RetailCloseDegrades && IsIssue47HumanoidSetup(setup))
|
||||
ApplyRetailCloseDegrades(flattened, dumpClothing);
|
||||
ApplyRetailCloseDegrades(flattened);
|
||||
|
||||
IReadOnlyList<CreateObject.TextureChange> textureChanges =
|
||||
canonicalSpawn.TextureChanges ?? Array.Empty<CreateObject.TextureChange>();
|
||||
Dictionary<int, Dictionary<uint, uint>>? surfaceOverrides =
|
||||
ResolveSurfaceOverrides(
|
||||
canonicalSpawn,
|
||||
flattened,
|
||||
textureChanges,
|
||||
dumpClothing,
|
||||
dumpLiveSpawns);
|
||||
textureChanges);
|
||||
|
||||
float scale = canonicalSpawn.ObjScale ?? 1f;
|
||||
Matrix4x4 scaleMatrix = Matrix4x4.CreateScale(scale);
|
||||
|
|
@ -294,7 +247,6 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
var indexedPartAvailable = new bool[flattened.Count];
|
||||
var animatedPartTemplate = new LiveAnimationPartTemplate[flattened.Count];
|
||||
var bounds = new LocalBoundsAccumulator();
|
||||
int clothingTriangles = 0;
|
||||
|
||||
for (int partIndex = 0; partIndex < flattened.Count; partIndex++)
|
||||
{
|
||||
|
|
@ -318,23 +270,10 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
drawable);
|
||||
if (gfx is null)
|
||||
{
|
||||
if (dumpClothing)
|
||||
Console.WriteLine($" EMIT part={partIndex:D2} gfx=0x{part.GfxObjId:X8} GFXOBJ_DAT_MISSING -> 0 tris");
|
||||
continue;
|
||||
}
|
||||
|
||||
_collisionAssets.CacheGfxObj(part.GfxObjId, gfx);
|
||||
if (dumpClothing)
|
||||
{
|
||||
var subMeshes = GfxObjMesh.Build(gfx, _dats);
|
||||
int triangles = 0;
|
||||
foreach (var subMesh in subMeshes)
|
||||
triangles += subMesh.Indices.Length / 3;
|
||||
clothingTriangles += triangles;
|
||||
Console.WriteLine(
|
||||
$" EMIT part={partIndex:D2} gfx=0x{part.GfxObjId:X8} "
|
||||
+ $"subMeshes={subMeshes.Count} tris={triangles}");
|
||||
}
|
||||
|
||||
if (GfxObjBounds.Get(gfx) is { } partBounds)
|
||||
bounds.Add(transform, partBounds);
|
||||
|
|
@ -346,21 +285,8 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
|
||||
if (meshRefs.Count == 0)
|
||||
{
|
||||
_noMesh++;
|
||||
if (dumpLiveSpawns)
|
||||
{
|
||||
Console.WriteLine(
|
||||
$"live: DROP no mesh refs from setup 0x{canonicalSpawn.SetupTableId.Value:X8} "
|
||||
+ $"(guid=0x{canonicalSpawn.Guid:X8})");
|
||||
}
|
||||
return false;
|
||||
}
|
||||
if (dumpClothing)
|
||||
{
|
||||
Console.WriteLine(
|
||||
$" TOTAL tris={clothingTriangles} meshRefs={meshRefs.Count} "
|
||||
+ $"(parts.Count={flattened.Count})");
|
||||
}
|
||||
|
||||
PaletteOverride? paletteOverride = CreatePaletteOverride(canonicalSpawn);
|
||||
PartOverride[] partOverrides = CreatePartOverrides(animPartChanges);
|
||||
|
|
@ -456,7 +382,6 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
indexedPartAvailable,
|
||||
animatedPartTemplate,
|
||||
bounds,
|
||||
dumpLiveSpawns,
|
||||
expectedCreateIntegrationVersion,
|
||||
synchronizeAnimation: supersessionRecovery);
|
||||
}
|
||||
|
|
@ -477,9 +402,7 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
return slotZeroId;
|
||||
}
|
||||
|
||||
private void ApplyRetailCloseDegrades(
|
||||
List<MeshRef> parts,
|
||||
bool dumpClothing)
|
||||
private void ApplyRetailCloseDegrades(List<MeshRef> parts)
|
||||
{
|
||||
for (int partIndex = 0; partIndex < parts.Count; partIndex++)
|
||||
{
|
||||
|
|
@ -495,33 +418,13 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
}
|
||||
|
||||
parts[partIndex] = new MeshRef(resolvedId, part.PartTransform);
|
||||
if (dumpClothing)
|
||||
{
|
||||
Console.WriteLine(
|
||||
$" DEGRADE part={partIndex:D2} gfx=0x{part.GfxObjId:X8} "
|
||||
+ $"-> close=0x{resolvedId:X8}");
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private Dictionary<int, Dictionary<uint, uint>>? ResolveSurfaceOverrides(
|
||||
WorldSession.EntitySpawn spawn,
|
||||
IReadOnlyList<MeshRef> parts,
|
||||
IReadOnlyList<CreateObject.TextureChange> textureChanges,
|
||||
bool dumpClothing,
|
||||
bool dumpLiveSpawns)
|
||||
IReadOnlyList<CreateObject.TextureChange> textureChanges)
|
||||
{
|
||||
if (dumpClothing)
|
||||
{
|
||||
Console.WriteLine($" TextureChanges count={textureChanges.Count}");
|
||||
foreach (CreateObject.TextureChange change in textureChanges)
|
||||
{
|
||||
Console.WriteLine(
|
||||
$" TC part={change.PartIndex:D2} oldTex=0x{change.OldTexture:X8} "
|
||||
+ $"-> newTex=0x{change.NewTexture:X8}");
|
||||
}
|
||||
}
|
||||
|
||||
if (textureChanges.Count == 0)
|
||||
return null;
|
||||
|
||||
|
|
@ -536,8 +439,6 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
oldToNew[change.OldTexture] = change.NewTexture;
|
||||
}
|
||||
|
||||
bool statueDiagnostic = dumpLiveSpawns
|
||||
&& spawn.Name?.Contains("Statue", StringComparison.OrdinalIgnoreCase) == true;
|
||||
var result = new Dictionary<int, Dictionary<uint, uint>>();
|
||||
for (int partIndex = 0; partIndex < parts.Count; partIndex++)
|
||||
{
|
||||
|
|
@ -547,12 +448,6 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
GfxObj? gfx = _dats.Get<GfxObj>(parts[partIndex].GfxObjId);
|
||||
if (gfx is null)
|
||||
{
|
||||
if (statueDiagnostic)
|
||||
{
|
||||
Console.WriteLine(
|
||||
$"live: [STATUE] resolve part={partIndex} "
|
||||
+ $"GfxObj 0x{parts[partIndex].GfxObjId:X8} missing");
|
||||
}
|
||||
continue;
|
||||
}
|
||||
_collisionAssets.CacheGfxObj(parts[partIndex].GfxObjId, gfx);
|
||||
|
|
@ -729,7 +624,6 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
IReadOnlyList<bool> indexedPartAvailable,
|
||||
IReadOnlyList<LiveAnimationPartTemplate> animatedPartTemplate,
|
||||
LocalBoundsAccumulator bounds,
|
||||
bool dumpLiveSpawns,
|
||||
ulong expectedCreateIntegrationVersion,
|
||||
bool synchronizeAnimation)
|
||||
{
|
||||
|
|
@ -835,7 +729,6 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
_worldEvents.UpsertCurrent(snapshot);
|
||||
if (_runtime.TryMarkWorldSpawnPublished(spawn.Guid))
|
||||
_worldEvents.FireEntitySpawned(snapshot);
|
||||
_hydrated++;
|
||||
|
||||
if (!_runtime.IsCurrentCreateIntegration(
|
||||
expectedRecord,
|
||||
|
|
@ -921,18 +814,6 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
return false;
|
||||
}
|
||||
|
||||
if (dumpLiveSpawns && _received % 20 == 0)
|
||||
{
|
||||
Console.WriteLine(
|
||||
$"live: animated={_runtime.AnimationRuntimeCount} "
|
||||
+ $"animReject: noCycle={_noCycle} fr0={_zeroFramerate} "
|
||||
+ $"1frame={_singleFrame} partFrames={_missingPartFrames}");
|
||||
Console.WriteLine(
|
||||
$"live: summary recv={_received} hydrated={_hydrated} "
|
||||
+ $"drops: noPos={_noPosition} noSetup={_noSetup} "
|
||||
+ $"setupMissing={_missingSetup} noMesh={_noMesh}");
|
||||
}
|
||||
|
||||
return _runtime.IsCurrentCreateIntegration(
|
||||
expectedRecord,
|
||||
expectedCreateIntegrationVersion);
|
||||
|
|
@ -961,18 +842,6 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
spawn,
|
||||
idleCycle);
|
||||
}
|
||||
if (!retainedAnimation)
|
||||
{
|
||||
if (idleCycle is null)
|
||||
_noCycle++;
|
||||
else if (idleCycle.Framerate == 0f)
|
||||
_zeroFramerate++;
|
||||
else if (idleCycle.HighFrame <= idleCycle.LowFrame)
|
||||
_singleFrame++;
|
||||
else if (idleCycle.Animation.PartFrames.Count <= 1)
|
||||
_missingPartFrames++;
|
||||
}
|
||||
|
||||
if (!retainedAnimation
|
||||
&& idleCycle is not null
|
||||
&& idleCycle.Framerate != 0f
|
||||
|
|
@ -1159,56 +1028,6 @@ internal sealed class DatLiveEntityProjectionMaterializer
|
|||
: null;
|
||||
}
|
||||
|
||||
private void DumpSpawn(WorldSession.EntitySpawn spawn, bool enabled)
|
||||
{
|
||||
if (!enabled)
|
||||
return;
|
||||
|
||||
string position = spawn.Position is { } p
|
||||
? $"({p.PositionX:F1},{p.PositionY:F1},{p.PositionZ:F1})@0x{p.LandblockId:X8}"
|
||||
: "no-pos";
|
||||
string setup = spawn.SetupTableId is { } setupId
|
||||
? $"0x{setupId:X8}"
|
||||
: "no-setup";
|
||||
string physicsTable = spawn.Physics?.PhysicsScriptTableId is { } tableId
|
||||
? $"0x{tableId:X8}"
|
||||
: "no-petable";
|
||||
string name = spawn.Name is { Length: > 0 } foundName
|
||||
? $"\"{foundName}\""
|
||||
: "no-name";
|
||||
string itemType = spawn.ItemType is { } foundItemType
|
||||
? $"0x{foundItemType:X8}"
|
||||
: "no-itemtype";
|
||||
Console.WriteLine(
|
||||
$"live: spawn guid=0x{spawn.Guid:X8} name={name} setup={setup} pos={position} "
|
||||
+ $"petable={physicsTable} itemType={itemType} "
|
||||
+ $"animParts={spawn.AnimPartChanges?.Count ?? 0} "
|
||||
+ $"texChanges={spawn.TextureChanges?.Count ?? 0} "
|
||||
+ $"subPalettes={spawn.SubPalettes?.Count ?? 0}");
|
||||
}
|
||||
|
||||
private void DumpClothingHeader(
|
||||
WorldSession.EntitySpawn spawn,
|
||||
Setup setup,
|
||||
IReadOnlyList<MeshRef> flattened,
|
||||
AnimationFrame? idleFrame,
|
||||
IReadOnlyList<CreateObject.AnimPartChange> changes,
|
||||
bool enabled)
|
||||
{
|
||||
if (!enabled)
|
||||
return;
|
||||
|
||||
Console.WriteLine(
|
||||
$"\n=== DUMP_CLOTHING: guid=0x{spawn.Guid:X8} name='{spawn.Name}' "
|
||||
+ $"setup=0x{setup.Id:X8} setup.Parts.Count={setup.Parts.Count} "
|
||||
+ $"flatten.Count={flattened.Count} APC={changes.Count} ===");
|
||||
foreach (CreateObject.AnimPartChange change in changes)
|
||||
Console.WriteLine($" APC part={change.PartIndex:D2} -> gfx=0x{change.NewModelId:X8}");
|
||||
Console.WriteLine(
|
||||
$" basePalette=0x{spawn.BasePaletteId ?? 0:X8} "
|
||||
+ $"subPalettes={spawn.SubPalettes?.Count ?? 0}");
|
||||
}
|
||||
|
||||
private static bool IsIssue47HumanoidSetup(Setup setup)
|
||||
{
|
||||
if (setup.Parts.Count != 34)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue